From patchwork Thu Jul 30 17:08:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 51703 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by patches.linaro.org (Postfix) with ESMTPS id 33BBF22DB5 for ; Thu, 30 Jul 2015 17:09:21 +0000 (UTC) Received: by lafd3 with SMTP id d3sf16088837laf.1 for ; Thu, 30 Jul 2015 10:09:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=c0PheK23J6Jf6sBOEIbiHPebAFxVPyRXuowzPJffAg8=; b=N8Bzf13OfqTCaH1nN/JnSyvBV4Ya/wh0IjkNuWLTFKbxraNkkvZdTg07EoWUYSFJzz vgbP8EzJEfitdW4r0TzhhaTNs2JPwHHZqgVyz1quEnHgJEDgugwy4OipnO7uVmEs1ZuS E/2rmj4jEY1FuAc+2soutAydoHxaXGI2Y/zXb2YJWG/FUt4OlMibf+qyAdCSl2mDfnUP fiIUH4Q29dwtNN4fDDin3a8py+HrmnF9JX1ZuCajUC+8TdwBR56277U3rQ7khg6+Pf0U tFretFkHBg1d8jyGNie0Mj1tcrNKSpdpRcNAxy4LyK44liRiD1KVsjbDjJOWFhRi1qJX oKKw== X-Gm-Message-State: ALoCoQn2NX4nbJYdm3hRUK+xcMNuTBtmdl7F6Hvf/D1tPW/uH7jx9ZX8dkVbFXD9fr2Kp+ei0AJW X-Received: by 10.112.54.166 with SMTP id k6mr18062281lbp.0.1438276160164; Thu, 30 Jul 2015 10:09:20 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.28.5 with SMTP id x5ls33498lag.58.gmail; Thu, 30 Jul 2015 10:09:19 -0700 (PDT) X-Received: by 10.152.18.232 with SMTP id z8mr1505615lad.66.1438276159928; Thu, 30 Jul 2015 10:09:19 -0700 (PDT) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com. [209.85.217.170]) by mx.google.com with ESMTPS id v8si1291138laj.130.2015.07.30.10.09.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 10:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by lbqc9 with SMTP id c9so5922793lbq.1 for ; Thu, 30 Jul 2015 10:09:19 -0700 (PDT) X-Received: by 10.152.6.69 with SMTP id y5mr44847915lay.72.1438276159821; Thu, 30 Jul 2015 10:09:19 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp743153lba; Thu, 30 Jul 2015 10:09:18 -0700 (PDT) X-Received: by 10.66.90.166 with SMTP id bx6mr107656617pab.76.1438276157535; Thu, 30 Jul 2015 10:09:17 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi2si3643796pad.106.2015.07.30.10.09.14; Thu, 30 Jul 2015 10:09:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbbG3RJL (ORCPT + 28 others); Thu, 30 Jul 2015 13:09:11 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38368 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753414AbbG3RJI (ORCPT ); Thu, 30 Jul 2015 13:09:08 -0400 Received: by wibxm9 with SMTP id xm9so583569wib.1 for ; Thu, 30 Jul 2015 10:09:07 -0700 (PDT) X-Received: by 10.194.172.130 with SMTP id bc2mr98774767wjc.85.1438276147559; Thu, 30 Jul 2015 10:09:07 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by smtp.gmail.com with ESMTPSA id lm16sm82853wic.18.2015.07.30.10.09.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Jul 2015 10:09:06 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, mchehab@osg.samsung.com, m.krufky@samsung.com Cc: peter.griffin@linaro.org, lee.jones@linaro.org, hugues.fruchet@st.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, joe@perches.com Subject: [PATCH v2 01/11] [media] stv0367: Refine i2c error trace to include i2c address Date: Thu, 30 Jul 2015 18:08:51 +0100 Message-Id: <1438276141-16902-2-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1438276141-16902-1-git-send-email-peter.griffin@linaro.org> References: <1438276141-16902-1-git-send-email-peter.griffin@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , When using stv0367 demodulator with STi STB platforms, we can have easily have four or more stv0367 demods running in the system at one time. As typically the b2120 reference design ships with a b2004a daughter board, which can accept two dvb NIM cards, and each b2100A NIM has 2x stv0367 demods and 2x NXPs tuner on it. In such circumstances it is useful to print the i2c address on error messages to know which one is failing due to I2C issues. Signed-off-by: Peter Griffin --- drivers/media/dvb-frontends/stv0367.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index ec3e18e..9a49db1 100644 --- a/drivers/media/dvb-frontends/stv0367.c +++ b/drivers/media/dvb-frontends/stv0367.c @@ -791,11 +791,13 @@ int stv0367_writeregs(struct stv0367_state *state, u16 reg, u8 *data, int len) memcpy(buf + 2, data, len); if (i2cdebug) - printk(KERN_DEBUG "%s: %02x: %02x\n", __func__, reg, buf[2]); + printk(KERN_DEBUG "%s: [%02x] %02x: %02x\n", __func__, + state->config->demod_address, reg, buf[2]); ret = i2c_transfer(state->i2c, &msg, 1); if (ret != 1) - printk(KERN_ERR "%s: i2c write error!\n", __func__); + printk(KERN_ERR "%s: i2c write error! ([%02x] %02x: %02x)\n", + __func__, state->config->demod_address, reg, buf[2]); return (ret != 1) ? -EREMOTEIO : 0; } @@ -829,10 +831,12 @@ static u8 stv0367_readreg(struct stv0367_state *state, u16 reg) ret = i2c_transfer(state->i2c, msg, 2); if (ret != 2) - printk(KERN_ERR "%s: i2c read error\n", __func__); + printk(KERN_ERR "%s: i2c read error ([%02x] %02x: %02x)\n", + __func__, state->config->demod_address, reg, b1[0]); if (i2cdebug) - printk(KERN_DEBUG "%s: %02x: %02x\n", __func__, reg, b1[0]); + printk(KERN_DEBUG "%s: [%02x] %02x: %02x\n", __func__, + state->config->demod_address, reg, b1[0]); return b1[0]; }