From patchwork Mon Dec 7 11:50:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 57777 Delivered-To: patch@linaro.org Received: by 10.202.179.86 with SMTP id c83csp945125oif; Mon, 7 Dec 2015 03:53:15 -0800 (PST) X-Received: by 10.66.65.109 with SMTP id w13mr3010245pas.142.1449489195521; Mon, 07 Dec 2015 03:53:15 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id d68si61068pfj.198.2015.12.07.03.53.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Dec 2015 03:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a5uKb-0002Rz-OP; Mon, 07 Dec 2015 11:51:49 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a5uJt-00023A-CO for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2015 11:51:08 +0000 Received: by wmvv187 with SMTP id v187so162469095wmv.1 for ; Mon, 07 Dec 2015 03:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=cTQ5Y8Ci9H83JjL/osE6oq6djb2uTIWGIiPhWsK/Ub4=; b=W8Dm/daojJg+Pw9kPYgcwmGbmRGKMDgZ0mdaeHHsFd2EOO/PX2albAtmJLG6qqYCye emL3JitJyjx9EawfGY6gW3KZvFprhzB/6IGGn+dosB9uoAMJIvSsnHoQfx6+h/FYROZR vjI06XP/GNiUbo3KvfDwowO9eWR1xoDTyzOSq8plYFU4yPIAp1P6K6e9s+TdafGveefw wsZxeherOmfh+1hbuPuyNUyie0C3Ad3Mut15cpqMsgJQkaosiNu8pjC5t9YskFEdOIbk lfjBTrQDYY3+AJm5RXfszVDgl4pdoPn3eLlt03y9kjplgcXouodkYJqjU7YfeEF7PPsd o77Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=cTQ5Y8Ci9H83JjL/osE6oq6djb2uTIWGIiPhWsK/Ub4=; b=icGObEyqtE0KdlSOrb1FKkQO9FGqF+mKCGG90mRf47sPt+jEe5umlvd2hmMsy+9jOc o/pu2UfjFOASSbaO6n6S/1WIITBcjfI/N7bkp8QVlZl5pFxKZs9z/ZdYvMdmwX4/zoy/ R2Y+wLB5nzvHiPOL0DduKILGkndhuZLUAJhFFXWdFg3M0y9ZF1qsvo049y5qJbAEVwRH 3KGbj33rDLxKbJyVHREuTsTsTizwiIF/3M+n/YL50OmqBEbU0Hvi+livHzCMc2Tft6qj aDEgHrUZA46ROxsgJJpyi0cXA7qwRXnauFXAmdWrflKtNdNQuHR+BqNDDneDyVAuqUoq vtmw== X-Gm-Message-State: ALoCoQn/MWoRx8KDINGSJDFDVhWEah89S7g3OVBqJk8GlhmlGB4GJn63eBVuy8Hr+OhR91OW3n0R X-Received: by 10.194.179.33 with SMTP id dd1mr37879760wjc.133.1449489043984; Mon, 07 Dec 2015 03:50:43 -0800 (PST) Received: from localhost.localdomain (host81-129-174-134.range81-129.btcentralplus.com. [81.129.174.134]) by smtp.gmail.com with ESMTPSA id z1sm24806533wje.35.2015.12.07.03.50.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Dec 2015 03:50:43 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/19] mfd: ab2100-otp: Remove pointless 'out of memory' error message Date: Mon, 7 Dec 2015 11:50:16 +0000 Message-Id: <1449489032-14374-4-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> References: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151207_035105_759150_A326594A X-CRM114-Status: GOOD ( 12.55 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:234 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org WARNING: Possible unnecessary 'out of memory' message + if (!otp) { + dev_err(&pdev->dev, "could not allocate AB3100 OTP device\n"); total: 0 errors, 1 warnings, 250 lines checked Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab3100-otp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/drivers/mfd/ab3100-otp.c b/drivers/mfd/ab3100-otp.c index f391c5fe..55b207a4 100644 --- a/drivers/mfd/ab3100-otp.c +++ b/drivers/mfd/ab3100-otp.c @@ -188,10 +188,9 @@ static int __init ab3100_otp_probe(struct platform_device *pdev) int i; otp = devm_kzalloc(&pdev->dev, sizeof(struct ab3100_otp), GFP_KERNEL); - if (!otp) { - dev_err(&pdev->dev, "could not allocate AB3100 OTP device\n"); + if (!otp) return -ENOMEM; - } + otp->dev = &pdev->dev; /* Replace platform data coming in with a local struct */