From patchwork Tue Nov 22 21:19:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 5284 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4DBB823FFD for ; Tue, 22 Nov 2011 21:20:16 +0000 (UTC) Received: from mail-gy0-f180.google.com (mail-gy0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 0F529A18787 for ; Tue, 22 Nov 2011 21:20:15 +0000 (UTC) Received: by ghbg18 with SMTP id g18so863447ghb.11 for ; Tue, 22 Nov 2011 13:20:15 -0800 (PST) Received: by 10.152.144.136 with SMTP id sm8mr13027026lab.33.1321996814860; Tue, 22 Nov 2011 13:20:14 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.41.198 with SMTP id h6cs201279lal; Tue, 22 Nov 2011 13:20:13 -0800 (PST) Received: by 10.204.9.204 with SMTP id m12mr20830698bkm.131.1321996812298; Tue, 22 Nov 2011 13:20:12 -0800 (PST) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.17.10]) by mx.google.com with ESMTP id z22si7808830fam.54.2011.11.22.13.20.12; Tue, 22 Nov 2011 13:20:12 -0800 (PST) Received-SPF: neutral (google.com: 212.227.17.10 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.10; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.17.10 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from wuerfel.localnet (port-92-200-58-120.dynamic.qsc.de [92.200.58.120]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0La6Uk-1R007H15m2-00lXJr; Tue, 22 Nov 2011 22:19:58 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Russell King - ARM Linux , Mark Brown , "patches@linaro.org" , Sascha Hauer , Will Deacon , "kernel@pengutronix.de" , Uwe Kleine-K?nig , Shawn Guo Subject: Re: [PATCH] arm/imx: use Kconfig choice for low-level debug UART selection Date: Tue, 22 Nov 2011 22:19:53 +0100 Message-ID: <1484610.g1p0X99tcV@wuerfel> User-Agent: KMail/4.7.2 (Linux/3.1.0-rc8nosema+; KDE/4.7.2; x86_64; ; ) In-Reply-To: <20111122202425.GD9581@n2100.arm.linux.org.uk> References: <1313530873-24961-1-git-send-email-will.deacon@arm.com> <20111122164707.GJ6624@sirena.org.uk> <20111122202425.GD9581@n2100.arm.linux.org.uk> MIME-Version: 1.0 X-Provags-ID: V02:K0:CTEBawjDzuhFbGbprTV/KqE1OkslDbC9MCjiOpxDDuq rhlHHi3mXNN5vrZMNdthXtSD3KQTB/DbCRqWcNXmHXVV4QJRiy X8Ql1PBS8E9orDTXr2y8/LepI06dcP2Twx4EWY0tLSAxjSw2IJ 1Rngii+bz3Mbc6VPTHhvsLgs78KLriGPN1wfoHdNcQH/0Wn3NG mHAc+67SVCpx6yZjidM5KPZas/bev+O5DGAh8msv8OcLc8fP5O kpGpdQjLUX244oS0zm2PhyYSG7C4hPjEBBBbGk6pMkXrH5bmB+ Z2lWj/aiQy0JxRVG3eD8U5Dtm7WsqRvqOKyY2kByjmSg6mXcQ9 neNKb9gMRY9KVGQ3LiNI= On Tuesday 22 November 2011 20:24:25 Russell King - ARM Linux wrote: > On Tue, Nov 22, 2011 at 04:47:07PM +0000, Mark Brown wrote: > > On Tue, Nov 22, 2011 at 05:38:12PM +0100, Uwe Kleine-K?nig wrote: > > > On Tue, Nov 22, 2011 at 03:48:38PM +0000, Russell King - ARM Linux wrote: > > > > > > > Ah, I see the problem. It's more subtile than just failure to build: it > > > > > autoselects DEBUG_ICEDCC then. > > > > > > At this point, I think the right answer is to remove the option in > > > > linux-next, and tell anyone who complains that they need to convert > > > > their platform properly. (We're going to need them converted in this > > > > way anyway for the single zImage project.) > > > > > I agree. > > > > It'd be nice if things could be arranged so that the build breaks rather > > than selecting ICEDCC on unconverted platforms - when you run into the > > problem it's not that easy to diagnose. > > Well, we could leave the choice as is, and make the NONE option cause a > #error. In my randconfig branch, I have a temporary patch doing We can also move ICEDCC to the bottom of the list to ensure that the default choice is a platform specific one. In order to make the conversion nicer (avoiding a conflicting patch every time someone adds "depends on !MY_PLATFORM", how about expressing it as this: config DEBUG_LL_UART_NONE depends on !DEBUG_LL_LEGACY and then selecting DEBUG_LL_LEGACY from all platforms that do their own thing. That would avoid the possible randconfig errors. Arnd --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -83,6 +83,8 @@ choice depends on DEBUG_LL config DEBUG_LL_UART_NONE + depends on !FOOTBRIDGE && !ARCH_CLPS711X && !ARCH_MXC && \ + !PLAT_SAMSUNG && !ARCH_REALVIEW && !ARCH_HIGHBANK bool "No low-level debugging UART" help Say Y here if your platform doesn't provide a UART option