From patchwork Tue Jan 17 15:22:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 91675 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp543249qgi; Tue, 17 Jan 2017 07:23:59 -0800 (PST) X-Received: by 10.98.131.136 with SMTP id h130mr40968921pfe.4.1484666639026; Tue, 17 Jan 2017 07:23:59 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id 23si24098837pfy.74.2017.01.17.07.23.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 07:23:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cTVc5-0003LB-Bh; Tue, 17 Jan 2017 15:23:57 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cTVbQ-0002AN-By for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2017 15:23:18 +0000 Received: by mail-wm0-x22a.google.com with SMTP id c206so227924739wme.0 for ; Tue, 17 Jan 2017 07:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zfpd1eO7xxGzNokheRELTOmW0w9HWUScNlNa89gvn3Y=; b=IyL2SJ7/2+LvlZU8MSF6NlzHN0e3zkljoLKPGwpxEd+QIOUwzTQVmyPxZ8agelEkU1 BBlu2AxD8OqoGo90/wOWlqg2iY6fcAaX/0AjRlMEKLpTUy2O9jvkYz5kkCQALBu47HIx HMLbIU4CiccwTs42P92Mi3RZ9gcKWf/YdUT9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zfpd1eO7xxGzNokheRELTOmW0w9HWUScNlNa89gvn3Y=; b=Xqx1vrkBTSCc7LdcggFdTRHBM+kAOe3rnFjl+ROWuCxJJvyny/ydYrM65EYCuniH0L SNhSuLMdeWPbZG9/KaFdUyvWeY3MQuUPFg7fcp/Hwll3EpNAyk/X14VcwZjEPsM3FMdz sBZhMEtYRYRBfun5MDHoToKBiu+0j5lQrZQRmn1eVsKBKNlx/QFP0mrlArXUU1Pu/A/y bEqqXBuDjzAuxkGSqOAq0ppLq1FmDEqOuEUH4uansKRUXXnF6Bq3aU7oZi6KbTqXMpTe mOtjnB7kx0lyV5cK2g3u7NswdoWVSp/zHp5AjsJjkgIQHw+itoJuu/0IuPhg99P2fMAP jyHQ== X-Gm-Message-State: AIkVDXINCpEb3/00hKMuhsI//ZijBuA4pbp7B3Hh43Fh5ohY9jDP2Knd0RuNgUvWvedEqULF X-Received: by 10.223.154.132 with SMTP id a4mr32128225wrc.188.1484666582841; Tue, 17 Jan 2017 07:23:02 -0800 (PST) Received: from localhost.localdomain ([160.167.203.25]) by smtp.gmail.com with ESMTPSA id y127sm37590359wmg.12.2017.01.17.07.22.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Jan 2017 07:23:01 -0800 (PST) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au Subject: [PATCH 06/10] crypto: arm64/chacha20 - remove cra_alignmask Date: Tue, 17 Jan 2017 15:22:33 +0000 Message-Id: <1484666557-31458-7-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484666557-31458-1-git-send-email-ard.biesheuvel@linaro.org> References: <1484666557-31458-1-git-send-email-ard.biesheuvel@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170117_072316_676653_0A43567E X-CRM114-Status: GOOD ( 10.54 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:22a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org Remove the unnecessary alignmask: it is much more efficient to deal with the misalignment in the core algorithm than relying on the crypto API to copy the data to a suitably aligned buffer. Signed-off-by: Ard Biesheuvel --- arch/arm64/crypto/chacha20-neon-glue.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm64/crypto/chacha20-neon-glue.c b/arch/arm64/crypto/chacha20-neon-glue.c index a7f2337d46cf..a7cd575ea223 100644 --- a/arch/arm64/crypto/chacha20-neon-glue.c +++ b/arch/arm64/crypto/chacha20-neon-glue.c @@ -93,7 +93,6 @@ static struct skcipher_alg alg = { .base.cra_priority = 300, .base.cra_blocksize = 1, .base.cra_ctxsize = sizeof(struct chacha20_ctx), - .base.cra_alignmask = 1, .base.cra_module = THIS_MODULE, .min_keysize = CHACHA20_KEY_SIZE,