From patchwork Sat Mar 17 21:13:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7342 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id A64F323DEA for ; Sat, 17 Mar 2012 21:14:11 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 4D144A18463 for ; Sat, 17 Mar 2012 21:14:11 +0000 (UTC) Received: by iage36 with SMTP id e36so9777337iag.11 for ; Sat, 17 Mar 2012 14:14:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to :subject:date:user-agent:cc:references:in-reply-to:mime-version :content-type:content-transfer-encoding:message-id:x-provags-id :x-gm-message-state; bh=Gy33QsaMVGnzKfctlnbRTj9FQbEbf1egLcMZhfhjmDU=; b=N7HyRFIkES4Y526bshuzy0WlspQmNa1d6twt/0O65NHiFk4QD6L4xa9vEzPZGnjwwD llQUEesJ8rYnjSD21uJzw0OMQNFA4griEc1nTQN/NyDl30P8furC8nYd/DdrtN1+IeGI tUVnC++YO3+PxoEpWTWNiVxI92XI0JbLEYMaP2Jt6GwCB5NfO+inDp3rnc96xzVwJOuZ qwmAqxqAZLQBXtUCjmi1N1/+b0rC1w6tjEv89+4FAquNfRqAPa3b6Vg0zmJXawNs11wr EgiZCYmtJG0ZrtOWhVfydXktIrsBvF8fu/DlP7UeSeofP3/78xKmrZjZzRqeXz4+8bFO gy8Q== Received: by 10.50.183.163 with SMTP id en3mr2607129igc.12.1332018850770; Sat, 17 Mar 2012 14:14:10 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.203.79 with SMTP id fh15csp41072ibb; Sat, 17 Mar 2012 14:14:09 -0700 (PDT) Received: by 10.180.85.70 with SMTP id f6mr8465492wiz.5.1332018848690; Sat, 17 Mar 2012 14:14:08 -0700 (PDT) Received: from moutng.kundenserver.de (moutng.kundenserver.de. [212.227.17.8]) by mx.google.com with ESMTP id hu4si4281419wib.27.2012.03.17.14.14.08; Sat, 17 Mar 2012 14:14:08 -0700 (PDT) Received-SPF: neutral (google.com: 212.227.17.8 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.17.8; Authentication-Results: mx.google.com; spf=neutral (google.com: 212.227.17.8 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) smtp.mail=arnd@arndb.de Received: from klappe2.localnet (HSI-KBW-46-223-44-216.hsi.kabel-badenwuerttemberg.de [46.223.44.216]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MSHd5-1RlWlT2Zf1-00T7DJ; Sat, 17 Mar 2012 22:13:33 +0100 From: Arnd Bergmann To: Sascha Hauer Subject: Re: [PATCH v7 1/3] Documentation: common clk API Date: Sat, 17 Mar 2012 21:13:30 +0000 User-Agent: KMail/1.12.2 (Linux/3.3.0-rc1; KDE/4.3.2; x86_64; ; ) Cc: "Turquette, Mike" , Paul Walmsley , linux-arm-kernel@lists.infradead.org, Amit Kucheria , Nicolas Pitre , linaro-dev@lists.linaro.org, Linus Walleij , Grant Likely , Saravana Kannan , Jeremy Kerr , Magnus Damm , Deepak Saxena , patches@linaro.org, Rob Herring , Russell King , Thomas Gleixner , Richard Zhao , Shawn Guo , Linus Walleij , Mark Brown , Stephen Boyd , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org References: <1331878280-2758-1-git-send-email-mturquette@linaro.org> <20120317202931.GN3852@pengutronix.de> In-Reply-To: <20120317202931.GN3852@pengutronix.de> MIME-Version: 1.0 Message-Id: <201203172113.31122.arnd@arndb.de> X-Provags-ID: V02:K0:yj8CmfOXLDNAPh9N0fD/c18HP8ZiOsgbNqn9o9hbMxE cLzXhyHi+HXUGO0nIMa0DI2Qh+0TLxxliKlWNXJBFmUa6tj2VK plloAI3Jo4uderrUAv1wkbdz2xbPZUXclhHuffEfm9hAbudSHh 8S3mtdMWHLp0HtiMt7tw3ppIUtBlFR7T6E+a5Xpu09UGq9rCzT G7B2NHx7HANXhh+OlZHe1T8wGDuLlbwXssQ/t+fcfsVQ95rUWr 3t9Ght78lPtpXZnMZj3CYKqhIZrBO4Lz+26thAuLD15JTNWfK8 4nQGGdndl4Djrl0bWF3LzpkMiJo0Q4w9UkfupArcXt2NRscwBe UQPgRpsqxWWFiCM6kAjA= X-Gm-Message-State: ALoCoQmI+9QCyJpYRT27M64JAhlX3reRvYOarBAFQ54lHSNBzJPAt4qIral1Vr7bIkr2iVr021Ls On Saturday 17 March 2012, Sascha Hauer wrote: > On Sat, Mar 17, 2012 at 11:02:11AM -0700, Turquette, Mike wrote: > > > > Much like experimental I'm not sure how needed this change is. The > > help section does say to leave it disabled by default, if unsure. If > > you merge it I won't object but this might be fixing an imaginary > > problem. > > Architectures without common clock support won't build with this option > enabled (multiple definition of clk_enable etc), so I think this should > not be user visible. I've applied this patch now. Arnd commit c173033d154e9792b1b5059783b802f82536d48f Author: Arnd Bergmann Date: Sat Mar 17 21:10:51 2012 +0000 clk: make CONFIG_COMMON_CLK invisible All platforms that use the common clk infrastructure should select COMMON_CLK from platform code, and on all other platforms, it must not be enabled, so there is no point making the option visible to users, and when it is visible, we break randconfig builds. Signed-off-by: Arnd Bergmann diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 2eaf17e..82bcfbd 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -10,18 +10,14 @@ config HAVE_MACH_CLKDEV bool menuconfig COMMON_CLK - bool "Common Clock Framework" + bool select HAVE_CLK_PREPARE ---help--- The common clock framework is a single definition of struct clk, useful across many platforms, as well as an implementation of the clock API in include/linux/clk.h. Architectures utilizing the common struct clk should select - this automatically, but it may be necessary to manually select - this option for loadable modules requiring the common clock - framework. - - If in doubt, say "N". + this option. if COMMON_CLK