From patchwork Thu Aug 21 21:11:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 35786 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B15DA20540 for ; Thu, 21 Aug 2014 21:13:03 +0000 (UTC) Received: by mail-pa0-f72.google.com with SMTP id eu11sf79052667pac.11 for ; Thu, 21 Aug 2014 14:13:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:subject:message-id :mime-version:user-agent:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:reply-to :content-type:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list; bh=5lMUUYyTJ2H5R+Uz03COa+Oh+0oYcxP+z4Bs1r3ADtA=; b=CJjHADzivhpRryNHTBTWSGtGqljrDyUkEl3eo52PdFKyadvnm0ezEIgEpNor0/5FtO blt7hA84I9DN9liGwfSCO81gzYghkGJQ2POEmYKD1ewPHXbXWgHBXhWGgELj+tY9MlNP dtQZm2tZ6msuduU3R3DEpGxao7YAb6885BdHdpPV5RaLSAMNmg7G4QeiEUsXnIiPnDO0 wgNBZLVUlr7KnhIYCmTNhh9yegngNc5Tm+E4DMMKFrKVpwFMfCqWZVvQ7bsEjeOB780y dmVrI+Tt0KpVq1cUnnszzohv7GurqqYYZsI1Q//w8I1hhNP3C4ZTpsCHfbpQWKjhynhy K13g== X-Gm-Message-State: ALoCoQn5ZAJX96Is8FHrvwsXZRdcRCS9CIjfrhcxon8zDJxk6SKwn3EL+TnSshUFuki+ROtaniF4 X-Received: by 10.66.168.197 with SMTP id zy5mr807335pab.7.1408655583052; Thu, 21 Aug 2014 14:13:03 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.41.11 with SMTP id y11ls961088qgy.23.gmail; Thu, 21 Aug 2014 14:13:02 -0700 (PDT) X-Received: by 10.220.251.200 with SMTP id mt8mr822145vcb.24.1408655582887; Thu, 21 Aug 2014 14:13:02 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id i6si12784654vdt.83.2014.08.21.14.13.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 Aug 2014 14:13:02 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id hy4so11655798vcb.27 for ; Thu, 21 Aug 2014 14:13:02 -0700 (PDT) X-Received: by 10.220.194.130 with SMTP id dy2mr687453vcb.47.1408655582780; Thu, 21 Aug 2014 14:13:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp167622vcb; Thu, 21 Aug 2014 14:13:02 -0700 (PDT) X-Received: by 10.70.35.15 with SMTP id d15mr1041313pdj.48.1408655581665; Thu, 21 Aug 2014 14:13:01 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id or6si38077395pdb.144.2014.08.21.14.13.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Aug 2014 14:13:01 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XKZe8-0001hr-QE; Thu, 21 Aug 2014 21:11:48 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XKZe5-0001c1-Mb for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2014 21:11:46 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s7LLB6w1028407; Thu, 21 Aug 2014 16:11:06 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s7LLB5WM023507; Thu, 21 Aug 2014 16:11:06 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Thu, 21 Aug 2014 16:11:05 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s7LLB5N2001601; Thu, 21 Aug 2014 16:11:05 -0500 Date: Thu, 21 Aug 2014 16:11:00 -0500 From: Felipe Balbi To: Russell King Subject: Build failure with v3.17-rc1 Message-ID: <20140821211100.GS11146@saruman.home> MIME-Version: 1.0 User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140821_141145_823741_9019F686 X-CRM114-Status: GOOD ( 11.60 ) X-Spam-Score: -5.7 (-----) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-5.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [198.47.26.153 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [198.47.26.153 listed in wl.mailspike.net] -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Reply-To: balbi@ti.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Hi Russell, When running my randconfig build tests, I noticed that I had a build failure at arch/arm/kernel/patch.c KCONFIG_SEED=0x26B77624 arch/arm/kernel/patch.c: In function ‘__patch_text’: arch/arm/kernel/patch.c:35:4: error: implicit declaration of function ‘__opcode_to_mem_thumb32’ [-Werror=implicit-function-declaration] insn = __opcode_to_mem_thumb32(insn); ^ cc1: some warnings being treated as errors make[1]: *** [arch/arm/kernel/patch.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [arch/arm/kernel] Error 2 make: *** Waiting for unfinished jobs.... Looking at the definition of __opcode_to_mem_thumb32 it's easy to see that it's not defined when ! CONFIG_CPU_ENDIAN_BE8 and that's exactly what I have in my generated defconfig (attached). Would below patch be the correct fix for this ? if it is, I can send it as a formal patch and/or add it to your patch tracking system. Otherwise, let me know what would be the best fix and I'll either fix or build-test a patch from you, whatever works best. cheers diff --git a/arch/arm/include/asm/opcodes.h b/arch/arm/include/asm/opcodes.h index e796c59..d74eb26 100644 --- a/arch/arm/include/asm/opcodes.h +++ b/arch/arm/include/asm/opcodes.h @@ -111,6 +111,7 @@ extern asmlinkage unsigned int arm_check_condition(u32 opcode, u32 psr); #define __opcode_to_mem_arm(x) ___opcode_identity32(x) #define __opcode_to_mem_thumb16(x) ___opcode_identity16(x) +#define __opcode_to_mem_thumb32(x) ___opcode_identity32(x) #define ___asm_opcode_to_mem_arm(x) ___asm_opcode_identity32(x) #define ___asm_opcode_to_mem_thumb16(x) ___asm_opcode_identity16(x) #ifndef CONFIG_CPU_ENDIAN_BE32