From patchwork Mon Jul 14 05:01:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 33548 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f71.google.com (mail-qg0-f71.google.com [209.85.192.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 85F1220CAD for ; Mon, 14 Jul 2014 05:04:43 +0000 (UTC) Received: by mail-qg0-f71.google.com with SMTP id f51sf10376015qge.10 for ; Sun, 13 Jul 2014 22:04:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=GLd8BKtMOUri3CxRIwGgzgsO4DyRjsUeQiBYRDOqCko=; b=RrHst9wTW9AkG2Mvcvdkib+W0K/PRK6e1hyX9XzRGsPy4m+286GqiX5TMCTjTq/mlf MuoZUBAr7F5rMfYHhZjI0fwcKvsuZ8e4b2PwCx8bNKVf7oQyUn/x3XDrNUKhHpUx0y08 bhr8MP0V28k+d9xGs1CZPjOk9Yf9EEf4FgEQCRXv85dMS58ya3ZJBHbNdteD2iOWx3bS RLwryUGxkXMr7sclbP2bTOC74i2YfFL+TCNGEs7bUlHDBKMOdnTsF9EYpTtnmI49Pynx jrBx5ZZ+VcKF+aZcuNz22X6hY/OhMiCBFUmKg6IFwNAYlrKsCLh/ph4Y4j8rXllJZ+JS TZVA== X-Gm-Message-State: ALoCoQlHqVmgXtl81ULuAZkUINpvMRnw9Tj0mw+Ez7JIWQZ6Y+uMN3nEfA6/ahMmLUhoHUsCAhSW X-Received: by 10.236.99.8 with SMTP id w8mr5856340yhf.31.1405314283011; Sun, 13 Jul 2014 22:04:43 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.47.113 with SMTP id l104ls440087qga.61.gmail; Sun, 13 Jul 2014 22:04:42 -0700 (PDT) X-Received: by 10.52.252.4 with SMTP id zo4mr12209120vdc.20.1405314282934; Sun, 13 Jul 2014 22:04:42 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id sq3si4953741vdb.76.2014.07.13.22.04.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Jul 2014 22:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id hq11so6333704vcb.13 for ; Sun, 13 Jul 2014 22:04:42 -0700 (PDT) X-Received: by 10.58.149.170 with SMTP id ub10mr14865337veb.0.1405314282760; Sun, 13 Jul 2014 22:04:42 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp106148vcb; Sun, 13 Jul 2014 22:04:42 -0700 (PDT) X-Received: by 10.70.41.110 with SMTP id e14mr14480216pdl.15.1405314281833; Sun, 13 Jul 2014 22:04:41 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id xy3si8245612pbb.230.2014.07.13.22.04.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Jul 2014 22:04:41 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X6YP5-00068O-4h; Mon, 14 Jul 2014 05:02:19 +0000 Received: from mail-ob0-f174.google.com ([209.85.214.174]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X6YP1-00065a-RG for linux-arm-kernel@lists.infradead.org; Mon, 14 Jul 2014 05:02:16 +0000 Received: by mail-ob0-f174.google.com with SMTP id vb8so3367888obc.5 for ; Sun, 13 Jul 2014 22:01:53 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.23.65 with SMTP id k1mr12107827oef.20.1405314113783; Sun, 13 Jul 2014 22:01:53 -0700 (PDT) Received: by 10.182.233.166 with HTTP; Sun, 13 Jul 2014 22:01:53 -0700 (PDT) In-Reply-To: <20140710213937.GB15190@google.com> References: <9430e4b284928e4919297de5602e803d03f82d7b.1404976058.git.viresh.kumar@linaro.org> <20140710213937.GB15190@google.com> Date: Mon, 14 Jul 2014 10:31:53 +0530 Message-ID: Subject: Re: [PATCH V9 1/7] pcie: Add designware wrapper driver for SPEAr13xx From: Viresh Kumar To: Bjorn Helgaas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140713_220215_937026_B2E7E1DA X-CRM114-Status: GOOD ( 18.17 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.174 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.174 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Cc: Pratyush Anand , Bartlomiej Zolnierkiewicz , "linux-pci@vger.kernel.org" , spear-devel , Mark Nicholson , Mohit Kumar , "olof@lixom.net" , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 11 July 2014 03:09, Bjorn Helgaas wrote: > I guess I'm obsessive, but I think it's nice when people run > "git log --oneline" on the file or directory they're changing, > and then follow the existing style. > > In this case, that would lead to a subject line like: > > PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx > >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 702ca10..443dd05 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6820,6 +6820,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/pci/host-generic-pci.txt >> F: drivers/pci/host/pci-host-generic.c >> >> +PCIE DRIVER FOR ST SPEAR13XX >> +M: Mohit Kumar >> +L: linux-pci@vger.kernel.org >> +S: Maintained >> +F: drivers/pci/host/pcie-spear13xx.c > > Wildcards work here, so you could follow the lead of IMX6, MVEBU, RCAR, > and DESIGNWARE and use: > > F: drivers/pci/host/*spear* > >> --- /dev/null >> +++ b/drivers/pci/host/pcie-spear13xx.c >> ... >> +#define PCI_CAP_ID_EXP_OFFSET 0x70 > > A nit, but I'd use a name like EXP_CAP_ID_OFFSET to make it > more clear that this is specific to SPEAr, not something from > the PCI specs. Hi Bjorn, So this is how the diff looks like over this patch: dev_err(pp->dev, "link already up\n"); And the subject looks like this now: PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx I may skip sending a V10 for this and directly send a pull request as there aren't any significant changes suggested in V9. Thanks. diff --git a/MAINTAINERS b/MAINTAINERS index 443dd05..766948e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6824,7 +6824,7 @@ PCIE DRIVER FOR ST SPEAR13XX M: Mohit Kumar L: linux-pci@vger.kernel.org S: Maintained -F: drivers/pci/host/pcie-spear13xx.c +F: drivers/pci/host/*spear* PCMCIA SUBSYSTEM P: Linux PCMCIA Team diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c index a6fc332..99738e4 100644 --- a/drivers/pci/host/pcie-spear13xx.c +++ b/drivers/pci/host/pcie-spear13xx.c @@ -139,7 +139,7 @@ struct pcie_app_reg { #define VEN_MSI_TC_MASK ((u32)0x7 << VEN_MSI_TC_ID) #define VEN_MSI_VECTOR_MASK ((u32)0x1F << VEN_MSI_VECTOR_ID) -#define PCI_CAP_ID_EXP_OFFSET 0x70 +#define EXP_CAP_ID_OFFSET 0x70 #define to_spear13xx_pcie(x) container_of(x, struct spear13xx_pcie, pp) @@ -149,7 +149,7 @@ static int spear13xx_pcie_establish_link(struct pcie_port *pp) int count = 0; struct spear13xx_pcie *spear13xx_pcie = to_spear13xx_pcie(pp); struct pcie_app_reg *app_reg = spear13xx_pcie->app_base; - u32 exp_cap_off = PCI_CAP_ID_EXP_OFFSET; + u32 exp_cap_off = EXP_CAP_ID_OFFSET; if (dw_pcie_link_up(pp)) {