From patchwork Tue May 23 14:16:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 100366 Delivered-To: patch@linaro.org Received: by 10.182.142.97 with SMTP id rv1csp1894939obb; Tue, 23 May 2017 07:16:59 -0700 (PDT) X-Received: by 10.98.148.2 with SMTP id m2mr32088626pfe.194.1495549019823; Tue, 23 May 2017 07:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495549019; cv=none; d=google.com; s=arc-20160816; b=Ez4uHPPHdDCVyuJ1eK8WShPYY15wEKjRh5so5bT6Wr5Q9saDPLiqYfd3qCEHJDrNjZ +1oi83SkLhD7FJfe/ULiGYsWEAIMSpzaOpQFIUZiuYHFZCUCimd3eSyCaUQ6RPKVhIj5 PdmMWG5Io0PzMDeKGS2FuQrHjyK8/tBMHYb19wsC+6EUtht2tnjSs2w0htfEwqbblQyg La3K43c5hkX3Moq+mJDKplPAnPgW6XDCegyomxSkGS0+E2STSkpCHSlP1oFI/RtMglkW glxNAaI0JVPxrFI1AWWk8zeyCKUssq9gFb50E7El4eQduRmkY2jH07wLPzt1VMTH/ZUT S1+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=+5tZ985kzCA7nVLrzv2sskN/Si4oM9P3DNoaLfeQChE=; b=Rwih35cPF47sooKTeeB2THADHUa5zahi/S98pdGGOjZoFwht+qxWpjpLTzbdVLr/eT OHLXx7b0qi5wn/hRGiTxFZU/fUwtWQOFCDN9pXj6D3ZbA5K7i8uPSY/bno+UcpeN+ihG KWE9c2WDTFbnAUPo1H6sOXeJBdbP+gwTI3RSdp1rlfmPspKbsN59z0tCSHjK9wP1c8Nj APpUYDN6e7ZN6AOp9nkCpFQqEG6zGjxFO4TywFB8xmoo2fHXRTOSHpmFI1XmwfGbNOy7 AbexZcD2gLQNWH13Ee4ChApTjV0MC6CQJ/nipgg13uDjJxAWMJ/DMrIl0MBlyN7yTOrc NvEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t67si21157764pfj.51.2017.05.23.07.16.59; Tue, 23 May 2017 07:16:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936349AbdEWOQ5 (ORCPT + 10 others); Tue, 23 May 2017 10:16:57 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35520 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934215AbdEWOQy (ORCPT ); Tue, 23 May 2017 10:16:54 -0400 Received: by mail-pf0-f171.google.com with SMTP id n23so116038525pfb.2 for ; Tue, 23 May 2017 07:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=AI+lOKop4AdXPj21utxXHcOKrUI2HP8YBLl71oFu5ZE=; b=cvo4qpBWW8r2rYuZJZHuH5cFNXPGq5uJoh5cCM1vlreZbm2On1kM1GD6BPDFgdw/lf n1uwywS7mWuMbltos774ZOFB41aAa21OLv6scXodaqXZDqO84Qg9VaGloLLgxFwRtOnT rxroAPkIaCHyFqDjCpCrWASpsjQINf6IGuwt8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AI+lOKop4AdXPj21utxXHcOKrUI2HP8YBLl71oFu5ZE=; b=WY8fzLV/E358RA90FzR/rnvTEivDTc4HO1OCyQAPMHCKBAceGG3ZfSFgTBLH+r2pGD gPOouM1vSXi82uJ8Igfb93/QBUrpcyQVNDy/7H18aRKqB793ePcCVxukJSrzMmOqqJ1P ynddCYmofYNpglY6OIAWkK8SEj9QodxekDlHthZXiDkKQ2OdfI6mMCpyYyEVtENLb8Da 21NGqX5ZV7TcSktHJlOohZB3airyN+tZV7/XqV2aPjHly6gWqWp8gJc6ynVKGl869mp2 GYAtN/smMY5DLS/EBXCcfo1jCgmUKoHBHjTqu8bccmdSbRdrN3IzTsBoNFRoaWbET1Z9 UJgw== X-Gm-Message-State: AODbwcASXbx1NTKOS8CNZ33yjnt1D0VEZS+pgJXdqXo4WOGyzKMZCCxC rrBt1stalEq0YG07 X-Received: by 10.99.247.83 with SMTP id f19mr33052725pgk.190.1495549010641; Tue, 23 May 2017 07:16:50 -0700 (PDT) Received: from localhost.localdomain (li1068-205.members.linode.com. [106.184.3.205]) by smtp.gmail.com with ESMTPSA id x80sm1953334pff.105.2017.05.23.07.16.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 May 2017 07:16:48 -0700 (PDT) From: Leo Yan To: Jonathan Corbet , Mathieu Poirier , Rob Herring , Mark Rutland , Liviu Dudau , Wei Xu , Catalin Marinas , Will Deacon , Andy Gross , David Brown , Greg Kroah-Hartman , Suzuki K Poulose , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Stephen Boyd , Mike Leach Cc: Leo Yan Subject: [PATCH v11 0/9] coresight: enable debug module Date: Tue, 23 May 2017 22:16:11 +0800 Message-Id: <1495548980-30432-1-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter H7 "The Sample-based Profiling Extension" has description for sampling registers, we can utilize these registers to check program counter value with combined CPU exception level, secure state, etc. So this is helpful for CPU lockup bugs, e.g. if one CPU has run into infinite loop with IRQ disabled; the 'hang' CPU cannot switch context and handle any interrupt, so it cannot handle SMP call for stack dump, etc. This patch series is to enable coresight debug module with sample-based registers and register call back notifier for PCSR register dumping when panic happens, so we can see below dumping info for panic; and this patch series has considered the conditions for access permission for debug registers self, so this can avoid access debug registers when CPU power domain is off; the driver also try to figure out the CPU is in secure or non-secure state. Patch 0001 is to document the dt binding; patch 0002 adds one detailed document to describe the Coresight debug module implementation, the clock and power domain impaction on the driver, some examples for usage. Patch 0003 is to document boot parameters used in kernel command line. Patch 0004 is to add file entries for MAINTAINERS. Patch 0005 is used to fix the func of_get_coresight_platform_data() doesn't properly drop the reference to the CPU node pointer; and patch 0006 is refactor to add new function of_coresight_get_cpu(). Patch 0007 is the driver for CPU debug module. Patch 0008 in this series are to enable debug unit on 96boards Hikey, Patch 0009 is to enable debug on 96boards DB410c. Have verified on both two boards. We can enable debugging with two methods, adding parameters into kernel command line for build-in module: coresight_cpu_debug.enable=1 Or we can wait the system has booted up to use debugfs nodes to enable debugging: # echo 1 > /sys/kernel/debug/coresight_cpu_debug/enable As result we can get below log after input command: echo c > /proc/sysrq-trigger: ARM external debug module: coresight-cpu-debug 850000.debug: CPU[0]: coresight-cpu-debug 850000.debug: EDPRSR: 00000001 (Power:On DLK:Unlock) coresight-cpu-debug 850000.debug: EDPCSR: [] handle_IPI+0x174/0x1d8 coresight-cpu-debug 850000.debug: EDCIDSR: 00000000 coresight-cpu-debug 850000.debug: EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) coresight-cpu-debug 852000.debug: CPU[1]: coresight-cpu-debug 852000.debug: EDPRSR: 00000001 (Power:On DLK:Unlock) coresight-cpu-debug 852000.debug: EDPCSR: [] debug_notifier_call+0x23c/0x358 coresight-cpu-debug 852000.debug: EDCIDSR: 00000000 coresight-cpu-debug 852000.debug: EDVIDSR: 90000000 (State:Non-secure Mode:EL1/0 Width:64bits VMID:0) [...] Changes from v10: * Followed Liviu suggestion to improve readability of the documentation. * ARM Juno DTS binding patch has been picked by Sudeep, so this patch set has not included anymore. Great! Changes from v9: * Used dev_xyz() to replace pr_xyz() for print log. * Added DT binding patch for Juno shared by Suzuki. Changes from v8: * According to Mathieu suggestions to split the doc into two patches, one is for kernel parameter and another is for driver documentation. * Add file entries to MAINTAINERS. * According to Mathieu suggestions, refined functions debug_enable_func()/debug_disable_func(). Changes from v7: * Fix operator priority bug. * Minor sequence adjustment for function debug_func_exit(). Changes from v6: * According to Suzuki and Mathieu suggestions, refined debug module driver to install panic notifier when insmod module; refined function debug_force_cpu_powered_up() for CPU power state checking; some minor fixing for output log, adding comments for memory barrier, code alignment. Changes from v5: * According to Suzuki and Mathieu suggestions, refined debug module driver to drop unused structure members, refactored initialization code to distinguish hardware implementation features, refactored flow for forcing CPU powered up, supported pm_runtime operations. * Added one new doc file: Documentation/trace/coresight-cpu-debug.txt, which is used to describe detailed info for implementation, clock and power domain impaction on debug module, and exmaples for common usage. * Removed "idle constraints" from debug driver. Changes from v4: * This version is mainly credit to ARM colleagues many contribution ideas for better quality (Thanks a lot Suzuki, Mike and Sudeep!). * According to Suzuki suggestion, refined debug module driver to avoid memory leak for drvdata struct, handle PCSAMPLE_MODE=1, use flag drvdata.pc_has_offset to indicate if PCSR has offset, minor fixes. * According to Mathieu suggestion, refined dt binding description. * Changed driver to support module mode; * According to Mike suggestion and very appreciate the pseudo code, added support to force CPU powered up with register EDPRCR; * According to discussions, added command line and debugfs nodes to support enabling debugging for boot time, or later can dynamically enable/disable debugging by debugfs. * According to Rob Herring suggestion, one minor fixes in DT binding. * According to Stephen Boyd suggestion, add const quality to structure device_node. And used use of_cpu_device_node_get() to replace of_get_cpu_node() in patch 0003. Changes from v3: * Added Suzuki K Poulose's patch to fix issue for the func of_get_coresight_platform_data() doesn't properly drop the reference to the CPU node pointer. * According to Suzuki suggestion, added code to handl the corner case for ARMv8 CPU with aarch32 mode. * According to Suzuki suggestion, changed compatible string to "arm,coresight-cpu-debug". * According to Mathieu suggestion, added "power-domains" as optional properties. Changes from v2: * According to Mathieu Poirier suggestion, applied some minor fixes. * Added two extra patches for enabling debug module on Hikey. Changes from v1: * According to Mike Leach suggestion, removed the binding for debug module clocks which have been directly provided by CPU clocks. * According to Mathieu Poirier suggestion, added function of_coresight_get_cpu() and some minor refactors for debug module driver. Changes from RFC: * According to Mike Leach suggestion, added check for EDPRSR to avoid lockup; added supporting EDVIDSR and EDCIDSR registers. * According to Mark Rutland and Mathieu Poirier suggestion, rewrote the documentation for DT binding. * According to Mark and Mathieu suggestion, refined debug driver. Leo Yan (8): coresight: bindings for CPU debug module doc: Add documentation for Coresight CPU debug doc: Add coresight_cpu_debug.enable to kernel-parameters.txt MAINTAINERS: update file entries for Coresight subsystem coresight: refactor with function of_coresight_get_cpu coresight: add support for CPU debug module arm64: dts: hi6220: register debug module arm64: dts: qcom: msm8916: Add debug unit Suzuki K Poulose (1): coresight: of_get_coresight_platform_data: Add missing of_node_put Documentation/admin-guide/kernel-parameters.txt | 7 + .../bindings/arm/coresight-cpu-debug.txt | 49 ++ Documentation/trace/coresight-cpu-debug.txt | 175 ++++++ MAINTAINERS | 2 + arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 ++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 32 + drivers/hwtracing/coresight/Kconfig | 14 + drivers/hwtracing/coresight/Makefile | 1 + drivers/hwtracing/coresight/coresight-cpu-debug.c | 696 +++++++++++++++++++++ drivers/hwtracing/coresight/of_coresight.c | 40 +- include/linux/coresight.h | 3 + 11 files changed, 1071 insertions(+), 12 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt create mode 100644 Documentation/trace/coresight-cpu-debug.txt create mode 100644 drivers/hwtracing/coresight/coresight-cpu-debug.c -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html