| Message ID | 1577421760-1174-1-git-send-email-tdas@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add modem Clock controller (MSS CC) driver for SC7180 | expand |
Hi Rob, Thanks for your review. On 1/5/2020 3:06 AM, Rob Herring wrote: >> +description: | >> + Qualcomm modem clock control module which supports the clocks. >> + >> +properties: >> + compatible : > > drop space ^ > Will take care in the next patch. >> + enum: >> + - qcom,sc7180-mss >> + >> + '#clock-cells': >> + const: 1 >> + >> + reg: >> + maxItems: 1 >> + >> + additionalItems: false > > With the indentation here, you are defining a property. Should be no > indent. > I tried removing the indent too, but I keep getting this error. Additional properties are not allowed ('additionalItems' was unexpected) Please let me know if I am missing something? >> + >> +required: >> + - compatible >> + - reg >> + - '#clock-cells' >> + >> +examples: >> + # Example of MSS with clock nodes properties for SC7180: >> + - | >> + clock-controller@41aa000 { >> + compatible = "qcom,sc7180-mss"; >> + reg = <0x041aa000 0x100>; >> + #clock-cells = <1>; >> + }; >> +... >> -- >> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member >> of the Code Aurora Forum, hosted by the Linux Foundation. >>
On Mon, Jan 13, 2020 at 4:00 AM Taniya Das <tdas@codeaurora.org> wrote: > > Hi Rob, > > Thanks for your review. > > On 1/5/2020 3:06 AM, Rob Herring wrote: > > >> +description: | > >> + Qualcomm modem clock control module which supports the clocks. > >> + > >> +properties: > >> + compatible : > > > > drop space ^ > > > > Will take care in the next patch. > > >> + enum: > >> + - qcom,sc7180-mss > >> + > >> + '#clock-cells': > >> + const: 1 > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + additionalItems: false > > > > With the indentation here, you are defining a property. Should be no > > indent. > > > > I tried removing the indent too, but I keep getting this error. > Additional properties are not allowed ('additionalItems' was unexpected) > > Please let me know if I am missing something? Sorry, I was reading that as 'additionalProperties' which is what you want at the top level. Generally, 'additionalItems' is not needed. Rob
[v2] * Update the license for the documentation and fix minor comments in the YAML bindings. [v1] * Add driver support for Modem clock controller for SC7180 and also update device tree bindings for the various clocks supported in the clock controller. Taniya Das (3): dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings dt-bindings: clock: Introduce QCOM Modem clock bindings clk: qcom: Add modem clock controller driver for SC7180 .../devicetree/bindings/clock/qcom,mss.yaml | 41 ++++++++++ drivers/clk/qcom/Kconfig | 9 +++ drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-sc7180.c | 70 ++++++++++++++++ drivers/clk/qcom/mss-sc7180.c | 94 ++++++++++++++++++++++ include/dt-bindings/clock/qcom,gcc-sc7180.h | 5 ++ include/dt-bindings/clock/qcom,mss-sc7180.h | 12 +++ 7 files changed, 232 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml create mode 100644 drivers/clk/qcom/mss-sc7180.c create mode 100644 include/dt-bindings/clock/qcom,mss-sc7180.h -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.