| Message ID | 1603354958-24025-1-git-send-email-hemantk@codeaurora.org |
|---|---|
| Headers | show |
| Series | userspace MHI client interface driver | expand |
On Thu, 22 Oct 2020 01:22:34 -0700 Hemant Kumar wrote: > This patch series adds support for UCI driver. UCI driver enables userspace > clients to communicate to external MHI devices like modem and WLAN. UCI driver > probe creates standard character device file nodes for userspace clients to > perform open, read, write, poll and release file operations. These file > operations call MHI core layer APIs to perform data transfer using MHI bus > to communicate with MHI device. Patch is tested using arm64 based platform. Until you CC netdev on this (as suggested [1]), here's my: Nacked-by: Jakub Kicinski <kuba@kernel.org> [1] https://lore.kernel.org/netdev/20201016183759.7fa7c0ef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
Hi Jakub, On 10/23/20 9:37 AM, Jakub Kicinski wrote: > On Thu, 22 Oct 2020 01:22:34 -0700 Hemant Kumar wrote: >> This patch series adds support for UCI driver. UCI driver enables userspace >> clients to communicate to external MHI devices like modem and WLAN. UCI driver >> probe creates standard character device file nodes for userspace clients to >> perform open, read, write, poll and release file operations. These file >> operations call MHI core layer APIs to perform data transfer using MHI bus >> to communicate with MHI device. Patch is tested using arm64 based platform. > > Until you CC netdev on this (as suggested [1]), here's my: > > Nacked-by: Jakub Kicinski <kuba@kernel.org> > > [1] > https://lore.kernel.org/netdev/20201016183759.7fa7c0ef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/ > UCI driver patch series includes following patches 1) bus: mhi: core: Add helper API to return number of free TREs 2) bus: mhi: core: Move MHI_MAX_MTU to external header file 3) docs: Add documentation for userspace client interface 4) bus: mhi: Add userspace client interface driver mhi net driver can use #1 and #2 and these two are part of MHI core driver change. These are helper API/macro which can be used by any mhi clients like UCI or mhi net dev. #3 and #4 are MHI UCI character driver completely unrelated to netdev. How about splitting the patch series between #1,#2 and #3, #4 and add netdev to #1, #2? #1,#2 were already reviewed by two folks in community so it would be much easier for netdev folks to refer that in context of mhi net device driver. Please let me know what do you think about this idea. Thanks, Hemant -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
On Fri, 23 Oct 2020 10:22:19 -0700 Hemant Kumar wrote: > On 10/23/20 9:37 AM, Jakub Kicinski wrote: > > On Thu, 22 Oct 2020 01:22:34 -0700 Hemant Kumar wrote: > >> This patch series adds support for UCI driver. UCI driver enables userspace > >> clients to communicate to external MHI devices like modem and WLAN. UCI driver > >> probe creates standard character device file nodes for userspace clients to > >> perform open, read, write, poll and release file operations. These file > >> operations call MHI core layer APIs to perform data transfer using MHI bus > >> to communicate with MHI device. Patch is tested using arm64 based platform. > > > > Until you CC netdev on this (as suggested [1]), here's my: > > > > Nacked-by: Jakub Kicinski <kuba@kernel.org> > > > > [1] > > https://lore.kernel.org/netdev/20201016183759.7fa7c0ef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/ > > > > UCI driver patch series includes following patches > > 1) bus: mhi: core: Add helper API to return number of free TREs > 2) bus: mhi: core: Move MHI_MAX_MTU to external header file > 3) docs: Add documentation for userspace client interface > 4) bus: mhi: Add userspace client interface driver > > mhi net driver can use #1 and #2 and these two are part of MHI core > driver change. These are helper API/macro which can be used by any mhi > clients like UCI or mhi net dev. > > #3 and #4 are MHI UCI character driver completely unrelated to netdev. > > How about splitting the patch series between #1,#2 and #3, #4 and add > netdev to #1, #2? > > #1,#2 were already reviewed by two folks in community so it would be > much easier for netdev folks to refer that in context of mhi net device > driver. > > Please let me know what do you think about this idea. CC netdev on the entire series. We will judge what is and isn't related to networking.