Message ID | 1623783824-13395-1-git-send-email-sidgup@codeaurora.org |
---|---|
Headers | show |
Series | remoteproc: core: Fixes for rproc cdev and add | expand |
On Tue, Jun 15, 2021 at 12:03:42PM -0700, Siddharth Gupta wrote: > We can validate whether the remoteproc is correctly setup before > making the cdev_add and device_add calls. This saves us the > trouble of cleaning up later on. > > Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: stable@vger.kernel.org > --- > drivers/remoteproc/remoteproc_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Why is this relevant for stable? What commit does this fix? Please put a Fixes: tag for that. thanks, greg k-h
On Tue, Jun 15, 2021 at 12:03:43PM -0700, Siddharth Gupta wrote: > The rproc_char_device_remove() call currently unmaps the cdev > region instead of simply deleting the cdev that was added as a > part of the rproc_char_device_add() call. This change fixes that > behaviour, and also fixes the order in which device_del() and > cdev_del() need to be called. > > Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org> > Cc: stable@vger.kernel.org Is this really needed for stable? What bug does this solve? ANd again, fixes: ?