mbox series

[v3,0/4] soc: qcom: rpmhpd: Cleanups and fixups for sc7280/sm8450

Message ID 1639063917-9011-1-git-send-email-quic_rjendra@quicinc.com
Headers show
Series soc: qcom: rpmhpd: Cleanups and fixups for sc7280/sm8450 | expand

Message

Rajendra Nayak Dec. 9, 2021, 3:31 p.m. UTC
v3:
* used the _w_<parent-name>_parent suffix instead of _no_parent
* Added a minor fix for sm8450 while rebasing 

v2:
* Fixed the wrong assumption in v1 that only sdm845 needed mx to be
parent of cx, turned out all existing upstream SoCs need it except sc7280
* Added another cleanup patch to sort power-domain defines and lists in
alphabetical order as suggested by Matthias

Mostly cleanups, with a fixup to remove the parent/child relationship
across mx/cx for sc7280 SoC, and a fixup to add missing .peer for sm8450

Rajendra Nayak (4):
  soc: qcom: rpmhpd: sm8450: Add the missing .peer for sm8450_cx_ao
  soc: qcom: rpmhpd: Rename rpmhpd struct names
  soc: qcom: rpmhpd: Remove mx/cx relationship on sc7280
  soc: qcom: rpmhpd: Sort power-domain definitions and lists

 drivers/soc/qcom/rpmhpd.c | 358 +++++++++++++++++++++++-----------------------
 1 file changed, 181 insertions(+), 177 deletions(-)

Comments

Dmitry Baryshkov Dec. 9, 2021, 5 p.m. UTC | #1
On Thu, 9 Dec 2021 at 18:32, Rajendra Nayak <quic_rjendra@quicinc.com> wrote:
>
> sm8450_cx and sm8450_cx_ao should be peers of each other, add the
> missing .peer entry for sm8450_cx_ao
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>  drivers/soc/qcom/rpmhpd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index e7e150c..2032cf3 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -264,6 +264,7 @@ static struct rpmhpd sm8450_cx = {
>  static struct rpmhpd sm8450_cx_ao = {
>         .pd = { .name = "cx_ao", },
>         .active_only = true,
> +       .peer = &sm8450_cx,
>         .res_name = "cx.lvl",
>  };
>
> --
> 2.7.4
>
Vinod Koul Dec. 14, 2021, 5:30 a.m. UTC | #2
On 09-12-21, 21:01, Rajendra Nayak wrote:
> sm8450_cx and sm8450_cx_ao should be peers of each other, add the
> missing .peer entry for sm8450_cx_ao

Reviewed-by: Vinod Koul <vkoul@kernel.org>
Bjorn Andersson Dec. 15, 2021, 10:27 p.m. UTC | #3
On Thu, 9 Dec 2021 21:01:53 +0530, Rajendra Nayak wrote:
> v3:
> * used the _w_<parent-name>_parent suffix instead of _no_parent
> * Added a minor fix for sm8450 while rebasing
> 
> v2:
> * Fixed the wrong assumption in v1 that only sdm845 needed mx to be
> parent of cx, turned out all existing upstream SoCs need it except sc7280
> * Added another cleanup patch to sort power-domain defines and lists in
> alphabetical order as suggested by Matthias
> 
> [...]

Applied, thanks!

[1/4] soc: qcom: rpmhpd: sm8450: Add the missing .peer for sm8450_cx_ao
      commit: 7e1377712ba2da42edd354dc8da363f0fd68d33e
[2/4] soc: qcom: rpmhpd: Rename rpmhpd struct names
      commit: 8f3d4dd65abd03a5edcf7b5d5a7a3e2a4866db15
[3/4] soc: qcom: rpmhpd: Remove mx/cx relationship on sc7280
      commit: 65e7b31cc48581e32bee4546b59cea404252a138
[4/4] soc: qcom: rpmhpd: Sort power-domain definitions and lists
      commit: 8beb290d17f280f690857897af11dc90ac2e1f3d

Best regards,