mbox series

[V6,0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver

Message ID 1644915231-7308-1-git-send-email-quic_c_skakit@quicinc.com
Headers show
Series Add Qualcomm Technologies, Inc. PM8008 regulator driver | expand

Message

Satya Priya Kakitapalli (Temp) Feb. 15, 2022, 8:53 a.m. UTC 
Satya Priya (6):
  dt-bindings: regulator: Add pm8008 regulator bindings
  dt-bindings: mfd: pm8008: Add regulators node
  mfd: pm8008: Add mfd cell struct to register LDOs
  regulator: Add a regulator driver for the PM8008 PMIC
  arm64: dts: qcom: pm8008: Add base dts file
  arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp

 .../devicetree/bindings/mfd/qcom,pm8008.yaml       |  49 ++++-
 .../bindings/regulator/qcom,pm8008-regulator.yaml  |  28 +++
 arch/arm64/boot/dts/qcom/pm8008.dtsi               |  46 +++++
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |  66 +++++++
 drivers/mfd/qcom-pm8008.c                          |  26 ++-
 drivers/regulator/Kconfig                          |   9 +
 drivers/regulator/Makefile                         |   1 +
 drivers/regulator/qcom-pm8008-regulator.c          | 213 +++++++++++++++++++++
 8 files changed, 431 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/regulator/qcom,pm8008-regulator.yaml
 create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
 create mode 100644 drivers/regulator/qcom-pm8008-regulator.c

Comments

Guru Das Srinagesh Feb. 16, 2022, 2:58 a.m. UTC | #1 
On Tue, Feb 15, 2022 at 02:23:48PM +0530, Satya Priya wrote:
>  static const struct of_device_id pm8008_match[] = {
> -	{ .compatible = "qcom,pm8008", },
> -	{ },
> +	{ .compatible = "qcom,pm8008", .data = (void *)PM8008_INFRA},
> +	{ .compatible = "qcom,pm8008-regulators", .data = (void *)PM8008_REGULATORS},

Typo perhaps: Please set the last element of this array to the sentinel value NULL.
        {},

>  };
> +MODULE_DEVICE_TABLE(of, pm8008_match)

Missing a semicolon at the end.

>  
>  static struct i2c_driver pm8008_mfd_driver = {
>  	.driver = {
Satya Priya Kakitapalli (Temp) Feb. 16, 2022, 9:49 a.m. UTC | #2 
On 2/16/2022 8:28 AM, Guru Das Srinagesh wrote:
> On Tue, Feb 15, 2022 at 02:23:48PM +0530, Satya Priya wrote:
>>   static const struct of_device_id pm8008_match[] = {
>> -	{ .compatible = "qcom,pm8008", },
>> -	{ },
>> +	{ .compatible = "qcom,pm8008", .data = (void *)PM8008_INFRA},
>> +	{ .compatible = "qcom,pm8008-regulators", .data = (void *)PM8008_REGULATORS},
> Typo perhaps: Please set the last element of this array to the sentinel value NULL.
>          {},


Yes, I'll correct this.


>>   };
>> +MODULE_DEVICE_TABLE(of, pm8008_match)
> Missing a semicolon at the end.


Yes, will add it.


Thanks.