mbox series

[RESEND,V6,00/10] A bunch of fix and optimization patches in spmi-pmic-arb.c

Message ID 1651108369-11059-1-git-send-email-quic_fenglinw@quicinc.com
Headers show
Series A bunch of fix and optimization patches in spmi-pmic-arb.c | expand

Message

Fenglin Wu April 28, 2022, 1:12 a.m. UTC
Changes in v6:
  Rebased [v5 08/10] on
    https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/#t

Changes in v5:
  Drop [v4 11/11] because of a similar change is under review:
    https://lore.kernel.org/linux-arm-msm/YdRJcv2kpp1vgUTb@robh.at.kernel.org/T/#t

Changes in v4:
  In [v4 02/11], separated spurious interrupt handling.
  In [v4 03/11], added Fixes tag for ("spmi: pmic-arb: do not ack and clear peripheral").
  In [v4 11/11], updated the binding to address few warnings in "make dtbs_check"

Changes in v3:
  Drop [v2 07/10] as this is no longer needed after this change:
                50fc4c8cd240 ("spmi: spmi-pmic-arb: fix irq_set_type race condition")
  In [v3 07/10], updated the author email to match with Signed-off-by.
  In [v3 10/10], added the binding change in this series, and addressed issues in "make dt_binding_check"

Changes in v2:
  In [v2 01/10], added code to handle spurious interrupt.
  In [v2 03/10], adressed minor comments to update the code logic.
  In [v2 04/10], minor update to detect spurious interrupt.
  In [v2 05/10], added Fixes tag.
  In [v2 07/10], added Fixes tag and updated commit text to explain the problem.
  In [v2 08/10], added binding change to make interrupt properties as optional.
  In [v2 09/10], updated to check presence of "interrupt-controller" property.


Abhijeet Dharmapurikar (1):
  spmi: pmic-arb: add a print in cleanup_irq

Ashay Jaiswal (1):
  spmi: pmic-arb: add support to dispatch interrupt based on IRQ status

David Collins (6):
  spmi: pmic-arb: check apid against limits before calling irq handler
  spmi: pmic-arb: correct duplicate APID to PPID mapping logic
  spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes
  dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as
    optional
  spmi: pmic-arb: make interrupt support optional
  spmi: pmic-arb: increase SPMI transaction timeout delay

Fenglin Wu (1):
  spmi: pmic-arb: handle spurious interrupt

Subbaraman Narayanamurthy (1):
  spmi: pmic-arb: do not ack and clear peripheral interrupts in
    cleanup_irq

 .../bindings/spmi/qcom,spmi-pmic-arb.yaml          |   3 -
 drivers/spmi/spmi-pmic-arb.c                       | 136 +++++++++++++++------
 2 files changed, 96 insertions(+), 43 deletions(-)

Comments

Fenglin Wu May 13, 2022, 5:15 a.m. UTC | #1
hi Steven,

Can you help to review the series of the changes?
Thanks

Fenglin Wu

On 2022/4/28 9:12, Fenglin Wu wrote:
> Changes in v6:
>    Rebased [v5 08/10] on
>      https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/#t
> 
> Changes in v5:
>    Drop [v4 11/11] because of a similar change is under review:
>      https://lore.kernel.org/linux-arm-msm/YdRJcv2kpp1vgUTb@robh.at.kernel.org/T/#t
> 
> Changes in v4:
>    In [v4 02/11], separated spurious interrupt handling.
>    In [v4 03/11], added Fixes tag for ("spmi: pmic-arb: do not ack and clear peripheral").
>    In [v4 11/11], updated the binding to address few warnings in "make dtbs_check"
> 
> Changes in v3:
>    Drop [v2 07/10] as this is no longer needed after this change:
>                  50fc4c8cd240 ("spmi: spmi-pmic-arb: fix irq_set_type race condition")
>    In [v3 07/10], updated the author email to match with Signed-off-by.
>    In [v3 10/10], added the binding change in this series, and addressed issues in "make dt_binding_check"
> 
> Changes in v2:
>    In [v2 01/10], added code to handle spurious interrupt.
>    In [v2 03/10], adressed minor comments to update the code logic.
>    In [v2 04/10], minor update to detect spurious interrupt.
>    In [v2 05/10], added Fixes tag.
>    In [v2 07/10], added Fixes tag and updated commit text to explain the problem.
>    In [v2 08/10], added binding change to make interrupt properties as optional.
>    In [v2 09/10], updated to check presence of "interrupt-controller" property.
> 
> 
> Abhijeet Dharmapurikar (1):
>    spmi: pmic-arb: add a print in cleanup_irq
> 
> Ashay Jaiswal (1):
>    spmi: pmic-arb: add support to dispatch interrupt based on IRQ status
> 
> David Collins (6):
>    spmi: pmic-arb: check apid against limits before calling irq handler
>    spmi: pmic-arb: correct duplicate APID to PPID mapping logic
>    spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes
>    dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as
>      optional
>    spmi: pmic-arb: make interrupt support optional
>    spmi: pmic-arb: increase SPMI transaction timeout delay
> 
> Fenglin Wu (1):
>    spmi: pmic-arb: handle spurious interrupt
> 
> Subbaraman Narayanamurthy (1):
>    spmi: pmic-arb: do not ack and clear peripheral interrupts in
>      cleanup_irq
> 
>   .../bindings/spmi/qcom,spmi-pmic-arb.yaml          |   3 -
>   drivers/spmi/spmi-pmic-arb.c                       | 136 +++++++++++++++------
>   2 files changed, 96 insertions(+), 43 deletions(-)
>
Subbaraman Narayanamurthy June 7, 2022, 4:55 a.m. UTC | #2
On 4/27/22 6:12 PM, Fenglin Wu wrote:
> Changes in v6:
>   Rebased [v5 08/10] on
>     https://lore.kernel.org/linux-arm-msm/20211227170151.73116-1-david@ixit.cz/#t
>
> Changes in v5:
>   Drop [v4 11/11] because of a similar change is under review:
>     https://lore.kernel.org/linux-arm-msm/YdRJcv2kpp1vgUTb@robh.at.kernel.org/T/#t
>
> Changes in v4:
>   In [v4 02/11], separated spurious interrupt handling.
>   In [v4 03/11], added Fixes tag for ("spmi: pmic-arb: do not ack and clear peripheral").
>   In [v4 11/11], updated the binding to address few warnings in "make dtbs_check"
>
> Changes in v3:
>   Drop [v2 07/10] as this is no longer needed after this change:
>                 50fc4c8cd240 ("spmi: spmi-pmic-arb: fix irq_set_type race condition")
>   In [v3 07/10], updated the author email to match with Signed-off-by.
>   In [v3 10/10], added the binding change in this series, and addressed issues in "make dt_binding_check"
>
> Changes in v2:
>   In [v2 01/10], added code to handle spurious interrupt.
>   In [v2 03/10], adressed minor comments to update the code logic.
>   In [v2 04/10], minor update to detect spurious interrupt.
>   In [v2 05/10], added Fixes tag.
>   In [v2 07/10], added Fixes tag and updated commit text to explain the problem.
>   In [v2 08/10], added binding change to make interrupt properties as optional.
>   In [v2 09/10], updated to check presence of "interrupt-controller" property.
>
>
> Abhijeet Dharmapurikar (1):
>   spmi: pmic-arb: add a print in cleanup_irq
>
> Ashay Jaiswal (1):
>   spmi: pmic-arb: add support to dispatch interrupt based on IRQ status
>
> David Collins (6):
>   spmi: pmic-arb: check apid against limits before calling irq handler
>   spmi: pmic-arb: correct duplicate APID to PPID mapping logic
>   spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes
>   dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as
>     optional
>   spmi: pmic-arb: make interrupt support optional
>   spmi: pmic-arb: increase SPMI transaction timeout delay
>
> Fenglin Wu (1):
>   spmi: pmic-arb: handle spurious interrupt
>
> Subbaraman Narayanamurthy (1):
>   spmi: pmic-arb: do not ack and clear peripheral interrupts in
>     cleanup_irq
>
>  .../bindings/spmi/qcom,spmi-pmic-arb.yaml          |   3 -
>  drivers/spmi/spmi-pmic-arb.c                       | 136 +++++++++++++++------
>  2 files changed, 96 insertions(+), 43 deletions(-)
>

Hi Stephen,
Is there any problem with the patch series format? If not, can you please review these changes as they've been pending for a while?

Thanks,
Subbaraman