| Message ID | 1658910477-6494-1-git-send-email-quic_c_skakit@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for audio clock gating resets for SC7280 | expand |
On Wed 27 Jul 03:27 CDT 2022, Satya Priya wrote: > The LPASS Peripheral loader clocks would be used to bring > LPASS out of reset, when this property is present. > Can you please elaborate on what you mean here? When this property is set you assume that remoteproc is used to boot the LPASS and therefor some clocks should be handled differently? This needs to be written in a way that someone outside of your project can understand the purpose. > This is a cleanup done to handle overlap of regmap of > lpasscc and lpass_aon blocks. As a part of this, remove > the "cc" regmap from lpasscc node. > "regmap" is an implementation detail, the binding change should describe the changes to the representation of the hardware description. Thanks, Bjorn > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Stephen Boyd <sboyd@kernel.org> > --- > Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml | 6 ++---- > .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 7 +++++++ > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml > index 47028d7..633887d 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml > @@ -36,13 +36,11 @@ properties: > items: > - description: LPASS qdsp6ss register > - description: LPASS top-cc register > - - description: LPASS cc register > > reg-names: > items: > - const: qdsp6ss > - const: top_cc > - - const: cc > > required: > - compatible > @@ -59,8 +57,8 @@ examples: > #include <dt-bindings/clock/qcom,lpass-sc7280.h> > clock-controller@3000000 { > compatible = "qcom,sc7280-lpasscc"; > - reg = <0x03000000 0x40>, <0x03c04000 0x4>, <0x03389000 0x24>; > - reg-names = "qdsp6ss", "top_cc", "cc"; > + reg = <0x03000000 0x40>, <0x03c04000 0x4>; > + reg-names = "qdsp6ss", "top_cc"; > clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>; > clock-names = "iface"; > #clock-cells = <1>; > diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > index bad9135..5ccfb24 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml > @@ -41,6 +41,12 @@ properties: > reg: > maxItems: 1 > > + qcom,adsp-pil-mode: > + description: > + Indicates if the LPASS would be brought out of reset using > + peripheral loader. > + type: boolean > + > required: > - compatible > - reg > @@ -165,6 +171,7 @@ examples: > clocks = <&rpmhcc RPMH_CXO_CLK>, <&rpmhcc RPMH_CXO_CLK_A>, > <&lpasscore LPASS_CORE_CC_CORE_CLK>; > clock-names = "bi_tcxo", "bi_tcxo_ao","iface"; > + qcom,adsp-pil-mode; > #clock-cells = <1>; > #power-domain-cells = <1>; > }; > -- > 2.7.4 >
On 8/10/2022 2:49 AM, Bjorn Andersson wrote: > On Wed 27 Jul 03:27 CDT 2022, Satya Priya wrote: > >> The LPASS Peripheral loader clocks would be used to bring >> LPASS out of reset, when this property is present. >> > Can you please elaborate on what you mean here? > > When this property is set you assume that remoteproc is used to boot the > LPASS and therefor some clocks should be handled differently? Yes, you are right, I'll add this to the description. > This needs to be written in a way that someone outside of your project > can understand the purpose. > >> This is a cleanup done to handle overlap of regmap of >> lpasscc and lpass_aon blocks. As a part of this, remove >> the "cc" regmap from lpasscc node. >> > "regmap" is an implementation detail, the binding change should describe > the changes to the representation of the hardware description. Okay I'll remove the last part from description while re-posting. > Thanks, > Bjorn > >> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Stephen Boyd <sboyd@kernel.org> >> --- >> Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml | 6 ++---- >> .../devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 7 +++++++ >> 2 files changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml >> index 47028d7..633887d 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml >> @@ -36,13 +36,11 @@ properties: >> items: >> - description: LPASS qdsp6ss register >> - description: LPASS top-cc register >> - - description: LPASS cc register >> >> reg-names: >> items: >> - const: qdsp6ss >> - const: top_cc >> - - const: cc >> >> required: >> - compatible >> @@ -59,8 +57,8 @@ examples: >> #include <dt-bindings/clock/qcom,lpass-sc7280.h> >> clock-controller@3000000 { >> compatible = "qcom,sc7280-lpasscc"; >> - reg = <0x03000000 0x40>, <0x03c04000 0x4>, <0x03389000 0x24>; >> - reg-names = "qdsp6ss", "top_cc", "cc"; >> + reg = <0x03000000 0x40>, <0x03c04000 0x4>; >> + reg-names = "qdsp6ss", "top_cc"; >> clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>; >> clock-names = "iface"; >> #clock-cells = <1>; >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> index bad9135..5ccfb24 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml >> @@ -41,6 +41,12 @@ properties: >> reg: >> maxItems: 1 >> >> + qcom,adsp-pil-mode: >> + description: >> + Indicates if the LPASS would be brought out of reset using >> + peripheral loader. >> + type: boolean >> + >> required: >> - compatible >> - reg >> @@ -165,6 +171,7 @@ examples: >> clocks = <&rpmhcc RPMH_CXO_CLK>, <&rpmhcc RPMH_CXO_CLK_A>, >> <&lpasscore LPASS_CORE_CC_CORE_CLK>; >> clock-names = "bi_tcxo", "bi_tcxo_ao","iface"; >> + qcom,adsp-pil-mode; >> #clock-cells = <1>; >> #power-domain-cells = <1>; >> }; >> -- >> 2.7.4 >>
[v7] * Fix commit text of [5/5]. Remove '.' from Fixes tag. [v6] * Add [1], [2] to handle the regmap overlap of lpasscc and lpass_aon [v5] * Fix the fail path and add pm_runtime_disable(). [v4] * Fix the "fixes" tag. [v3] * Remove the maxItems from reg property. [v2] * Update/fix the YAML for reg property against each compatible. [v1] * Add support for clock gating resets for lpass audio clock controller & MCLKs. Satya Priya (2): dt-bindings: clock: Add "qcom,adsp-pil-mode" property clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon Taniya Das (3): dt-bindings: clock: Add resets for LPASS audio clock controller for SC7280 dt-bindings: clock: Add support for external MCLKs for LPASS on SC7280 clk: qcom: lpass: Add support for resets & external mclk for SC7280 .../bindings/clock/qcom,sc7280-lpasscc.yaml | 6 +- .../bindings/clock/qcom,sc7280-lpasscorecc.yaml | 26 ++++++++- drivers/clk/qcom/lpassaudiocc-sc7280.c | 66 +++++++++++++++++++++- drivers/clk/qcom/lpasscc-sc7280.c | 44 --------------- drivers/clk/qcom/lpasscorecc-sc7280.c | 33 +++++++++++ .../dt-bindings/clock/qcom,lpassaudiocc-sc7280.h | 5 ++ .../dt-bindings/clock/qcom,lpasscorecc-sc7280.h | 2 + 7 files changed, 130 insertions(+), 52 deletions(-)