mbox series

[V4,0/3] Add DT support for audio clock gating resets for SC7280

Message ID 1660026909-7365-1-git-send-email-quic_c_skakit@quicinc.com
Headers show
Series Add DT support for audio clock gating resets for SC7280 | expand

Message

Satya Priya Kakitapalli (Temp) Aug. 9, 2022, 6:35 a.m. UTC
This series depends on [1], which adds the dt-binding changes.

[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=663372

Satya Priya (2):
  arm64: dts: qcom: sc7280: Cleanup the lpasscc node
  arm64: dts: qcom: sc7280: Update lpasscore node

Taniya Das (1):
  arm64: dts: qcom: sc7280: Update lpassaudio clock controller for
    resets

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Stephen Boyd Aug. 9, 2022, 4:34 p.m. UTC | #1
Quoting Satya Priya (2022-08-08 23:35:08)
> From: Taniya Das <quic_tdas@quicinc.com>
>
> The lpass audio supports TX/RX/WSA block resets.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Satya Priya Kakitapalli (Temp) Aug. 10, 2022, 4:38 a.m. UTC | #2
On 8/9/2022 10:04 PM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-08-08 23:35:07)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 13d7f26..71735bb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2168,9 +2168,8 @@
>>                  lpasscc: lpasscc@3000000 {
>>                          compatible = "qcom,sc7280-lpasscc";
>>                          reg = <0 0x03000000 0 0x40>,
>> -                             <0 0x03c04000 0 0x4>,
>> -                             <0 0x03389000 0 0x24>;
>> -                       reg-names = "qdsp6ss", "top_cc", "cc";
>> +                                 <0 0x03c04000 0 0x4>;
> This looks oddly tabbed out? I'd expect it to align with the first reg
> property, so be unchanged.


Okay, I will correct the tabbing. But this wouldn't remain unchanged 
because the comma is being replaced by semi-colon.


>> +                       reg-names = "qdsp6ss", "top_cc";
>>                          clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
>>                          clock-names = "iface";