From patchwork Fri May 31 03:53:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 165485 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp185715ili; Thu, 30 May 2019 20:53:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqzvmVLVyxvR5GNCt5H2EXqBNDaMYfla123wStlzHxTDAc35p3Z9TVyrc7EtQwpn1bSIZ42d X-Received: by 2002:a62:e217:: with SMTP id a23mr7260977pfi.128.1559274837881; Thu, 30 May 2019 20:53:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559274837; cv=none; d=google.com; s=arc-20160816; b=NZKk+Dt8RaRWqPQQe+WvcsL4abVrpEikwNbVmSm6hWAq5xyhhNJw4sDveEUIg/9xDX xQPqjEFU8XSK5WRF7kxiANaNJqCORZJ5UsmT6rNb6CytYwCiOH7ozovvxsB8xNZ3d9PX JZSMm8TObEm9arM7g2U9DsN7JidfOmAzn0W0PMeOn0xkedKs9zDwPY7oXAZYD66CvJ8T Zgpzjq8MVWuXzUiDPMBmDbgzUxI0xqDETiK7JC6OkW5jqnDLe1RtD+bqr9NIY7ysU8hL DEj5qyOByLgR8c/dq12duU+DIDuev6yQWZw3sLKs6BF2Cl/+Nz0Eux+eiSyU7L9Jy5oL 2/Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qiDwYYLK/UhIbl9s/WpybFHrIbRZZe2OI2BUDB/tIvk=; b=QUCZBFYofCPHRDs/Loi/m5CYzDcsduC3TnQccoWVMuChzRM6YmyJrTA+1nRX/Q+HqA vLBaJZMEjGGBo50ED6Y4zWpDuu3gaLTb5uqODOe8LKmy8OvixpG5kYg65Bi+ebDNf0jp j9ZxJ/VnMxt2RKAOtvT9C6jtbWPZ8tAhxRI/Ak6RvOsY/eFAkh+6AwmZcXBge7r8ZKMA sXkkeKM8RgglY0MCVq6m2EDaMgGmdgbgRvWXegN5M+LgN33YFSMF2eTpnOARZ4SsDz8x QC+EjGHhFoERim9AbjjiqNuWxJES1BekKAc7IOh3D3cZeoeHH6tJUSql35RvCu3ZTVs+ vwOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=px5Z06Fd; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si4601423pls.221.2019.05.30.20.53.57; Thu, 30 May 2019 20:53:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=px5Z06Fd; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbfEaDx4 (ORCPT + 15 others); Thu, 30 May 2019 23:53:56 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:34193 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbfEaDx4 (ORCPT ); Thu, 30 May 2019 23:53:56 -0400 Received: by mail-io1-f67.google.com with SMTP id k8so7050667iot.1 for ; Thu, 30 May 2019 20:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qiDwYYLK/UhIbl9s/WpybFHrIbRZZe2OI2BUDB/tIvk=; b=px5Z06FdMy/JpNuYqv+FKrw8GhwQsE2VohNj+jatep9R5Meu5nZ6CSqyF4wiTBg+xF 0yi5y+nqqEhQQrC7vcqN06gyr531mdgyGueFaO1IUnXQABlnhTTu63LTa81AgumVKnMg s4FiYRUm/fRZx2k4Cu5TChMV0yqefpmNf3iak4VhDBn7ppY1J9vr9ScrYzuRmoKAqHne b1UG2reRgeVrqBn9/zANoLv5beuZsT//8PAoVEFJAWYFV4eK6l3r9iVNJM0WY7x0naUv mZLE05DKlE6PhWtYXdLbaSnCV8jeTLuh3f/Qisjg6DnY5pllliSoFDcSoOjOt6trHwOt VNjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qiDwYYLK/UhIbl9s/WpybFHrIbRZZe2OI2BUDB/tIvk=; b=jmj/oRNyIdDY4//Jt+KV3f4OWFA+6CAc4jGDW+nWj0oVRzaRnjsNkS3NdcOUKzkpBn tglxgOfGNCvL0YYTDxah+oy3WEzuJRnM3sb7vW+3kjYza1R71V+g+ploJ6UVwO+eFfyY opE9nSitdF+Hk3VDNt+wJIl4ayqbKp9MQO41K3iF1mwt/GuI3NsCt03+r7GgVSrIt/xK mivMpA+6/zM1PWgdGik35KljP4TJmMfoo2ECYMQjXhhH2v8FlaVYpMWBcH7N3gNJnhg/ vMGukx93Rtc6T7RnQJ0lSmjD8vzF1zQQp7naei2bLTAiQQfa4fsBCFV5tn2fjhGQRz91 pdwQ== X-Gm-Message-State: APjAAAXyRzNy+1GiI2yRWRmbreMLe++n7wVDn4ejJPL+9+X5VZVd0UiO 4SC/kIAhWU1Uaq7DABDjBZgzHw== X-Received: by 2002:a5d:804f:: with SMTP id b15mr4963187ior.189.1559274835505; Thu, 30 May 2019 20:53:55 -0700 (PDT) Received: from localhost.localdomain (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.gmail.com with ESMTPSA id q15sm1626947ioi.15.2019.05.30.20.53.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 May 2019 20:53:55 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, arnd@arndb.de, bjorn.andersson@linaro.org, ilias.apalodimas@linaro.org Cc: evgreen@chromium.org, benchan@google.com, ejcaruso@google.com, cpratapa@codeaurora.org, syadagir@codeaurora.org, subashab@codeaurora.org, abhishek.esse@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 00/17] net: introduce Qualcomm IPA driver Date: Thu, 30 May 2019 22:53:31 -0500 Message-Id: <20190531035348.7194-1-elder@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This series presents the driver for the Qualcomm IP Accelerator (IPA). This is version 2 of the series. This version has addressed almost all of the feedback received in the first version: https://lore.kernel.org/lkml/20190512012508.10608-1-elder@linaro.org/ More detail is included in the individual patches, but here is a high-level summary of what's changed since then: - Two spinlocks have been removed. - The code for enabling and disabling endpoint interrupts has been simplified considerably, and the spinlock is no longer required - A spinlock used when updating ring buffer pointers is no longer needed. Integers indexing the ring are used instead (and they don't even have to be atomic). - One spinlock remains to protect list updates, but it is always acquired using spin_lock_bh() (no more irqsave). - Information about the queueing and completion of messages is now supplied to the network stack in batches rather than one at a time. - I/O completion handling has been simplified, with the IRQ handler now consisting mainly of disabling the interrupt and calling napi_schedule(). - Some comments have been updated and improved througout. What follows is the introduction supplied with v1 of the series. ----- The IPA is a component present in some Qualcomm SoCs that allows network functions such as aggregation, filtering, routing, and NAT to be performed without active involvement of the main application processor (AP). Initially, these advanced features are disabled; the IPA driver simply provides a network interface that makes the modem's LTE network available to the AP. In addition, only support for the IPA found in the Qualcomm SDM845 SoC is provided. This code is derived from a driver developed internally by Qualcomm. A version of the original source can be seen here: https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree in the "drivers/platform/msm/ipa" directory. Many were involved in developing this, but the following individuals deserve explicit acknowledgement for their substantial contributions: Abhishek Choubey Ady Abraham Chaitanya Pratapa David Arinzon Ghanim Fodi Gidon Studinski Ravi Gummadidala Shihuan Liu Skylar Chang A version of this code was posted in November 2018 as an RFC. https://lore.kernel.org/lkml/20181107003250.5832-1-elder@linaro.org/ All feedback received was addressed. The code has undergone considerable further rework since that time, and most of the "future work" described then has now been completed. This code is available in buildable form here, based on kernel v5.2-rc1: remote: ssh://git@git.linaro.org/people/alex.elder/linux.git branch: ipa-v2_kernel-v5.2-rc2 75adf2ac1266 arm64: defconfig: enable build of IPA code The branch depends on a commit now found in in net-next. It has been cherry-picked, and (in this branch) has this commit ID: 13c627b5a078 net: qualcomm: rmnet: Move common struct definitions to include by -Alex Alex Elder (17): bitfield.h: add FIELD_MAX() and field_max() dt-bindings: soc: qcom: add IPA bindings soc: qcom: ipa: main code soc: qcom: ipa: configuration data soc: qcom: ipa: clocking, interrupts, and memory soc: qcom: ipa: GSI headers soc: qcom: ipa: the generic software interface soc: qcom: ipa: GSI transactions soc: qcom: ipa: IPA interface to GSI soc: qcom: ipa: IPA endpoints soc: qcom: ipa: immediate commands soc: qcom: ipa: IPA network device and microcontroller soc: qcom: ipa: AP/modem communications soc: qcom: ipa: support build of IPA code MAINTAINERS: add entry for the Qualcomm IPA driver arm64: dts: sdm845: add IPA information arm64: defconfig: enable build of IPA code .../devicetree/bindings/net/qcom,ipa.yaml | 180 ++ MAINTAINERS | 6 + arch/arm64/boot/dts/qcom/sdm845.dtsi | 51 + arch/arm64/configs/defconfig | 1 + drivers/net/Kconfig | 2 + drivers/net/Makefile | 1 + drivers/net/ipa/Kconfig | 16 + drivers/net/ipa/Makefile | 7 + drivers/net/ipa/gsi.c | 1635 +++++++++++++++++ drivers/net/ipa/gsi.h | 246 +++ drivers/net/ipa/gsi_private.h | 148 ++ drivers/net/ipa/gsi_reg.h | 376 ++++ drivers/net/ipa/gsi_trans.c | 624 +++++++ drivers/net/ipa/gsi_trans.h | 116 ++ drivers/net/ipa/ipa.h | 131 ++ drivers/net/ipa/ipa_clock.c | 297 +++ drivers/net/ipa/ipa_clock.h | 52 + drivers/net/ipa/ipa_cmd.c | 377 ++++ drivers/net/ipa/ipa_cmd.h | 116 ++ drivers/net/ipa/ipa_data-sdm845.c | 245 +++ drivers/net/ipa/ipa_data.h | 267 +++ drivers/net/ipa/ipa_endpoint.c | 1283 +++++++++++++ drivers/net/ipa/ipa_endpoint.h | 97 + drivers/net/ipa/ipa_gsi.c | 48 + drivers/net/ipa/ipa_gsi.h | 49 + drivers/net/ipa/ipa_interrupt.c | 279 +++ drivers/net/ipa/ipa_interrupt.h | 53 + drivers/net/ipa/ipa_main.c | 921 ++++++++++ drivers/net/ipa/ipa_mem.c | 234 +++ drivers/net/ipa/ipa_mem.h | 83 + drivers/net/ipa/ipa_netdev.c | 251 +++ drivers/net/ipa/ipa_netdev.h | 24 + drivers/net/ipa/ipa_qmi.c | 402 ++++ drivers/net/ipa/ipa_qmi.h | 35 + drivers/net/ipa/ipa_qmi_msg.c | 583 ++++++ drivers/net/ipa/ipa_qmi_msg.h | 238 +++ drivers/net/ipa/ipa_reg.h | 279 +++ drivers/net/ipa/ipa_smp2p.c | 304 +++ drivers/net/ipa/ipa_smp2p.h | 47 + drivers/net/ipa/ipa_uc.c | 208 +++ drivers/net/ipa/ipa_uc.h | 32 + include/linux/bitfield.h | 14 + 42 files changed, 10358 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/qcom,ipa.yaml create mode 100644 drivers/net/ipa/Kconfig create mode 100644 drivers/net/ipa/Makefile create mode 100644 drivers/net/ipa/gsi.c create mode 100644 drivers/net/ipa/gsi.h create mode 100644 drivers/net/ipa/gsi_private.h create mode 100644 drivers/net/ipa/gsi_reg.h create mode 100644 drivers/net/ipa/gsi_trans.c create mode 100644 drivers/net/ipa/gsi_trans.h create mode 100644 drivers/net/ipa/ipa.h create mode 100644 drivers/net/ipa/ipa_clock.c create mode 100644 drivers/net/ipa/ipa_clock.h create mode 100644 drivers/net/ipa/ipa_cmd.c create mode 100644 drivers/net/ipa/ipa_cmd.h create mode 100644 drivers/net/ipa/ipa_data-sdm845.c create mode 100644 drivers/net/ipa/ipa_data.h create mode 100644 drivers/net/ipa/ipa_endpoint.c create mode 100644 drivers/net/ipa/ipa_endpoint.h create mode 100644 drivers/net/ipa/ipa_gsi.c create mode 100644 drivers/net/ipa/ipa_gsi.h create mode 100644 drivers/net/ipa/ipa_interrupt.c create mode 100644 drivers/net/ipa/ipa_interrupt.h create mode 100644 drivers/net/ipa/ipa_main.c create mode 100644 drivers/net/ipa/ipa_mem.c create mode 100644 drivers/net/ipa/ipa_mem.h create mode 100644 drivers/net/ipa/ipa_netdev.c create mode 100644 drivers/net/ipa/ipa_netdev.h create mode 100644 drivers/net/ipa/ipa_qmi.c create mode 100644 drivers/net/ipa/ipa_qmi.h create mode 100644 drivers/net/ipa/ipa_qmi_msg.c create mode 100644 drivers/net/ipa/ipa_qmi_msg.h create mode 100644 drivers/net/ipa/ipa_reg.h create mode 100644 drivers/net/ipa/ipa_smp2p.c create mode 100644 drivers/net/ipa/ipa_smp2p.h create mode 100644 drivers/net/ipa/ipa_uc.c create mode 100644 drivers/net/ipa/ipa_uc.h -- 2.20.1 Reviewed-by: Rob Herring