mbox series

[0/9] ALSA: compress: Add wma, alac and ape support

Message ID 20200313070847.1464977-1-vkoul@kernel.org
Headers show
Series ALSA: compress: Add wma, alac and ape support | expand

Message

Vinod Koul March 13, 2020, 7:08 a.m. UTC 
This series adds more WMA profiles and WMA decoder parameters to UAPI and
then support for these in qcom driver. It also adds FLAC and APE IDs and
decoder parameters to UAPI and then support in qcom driver

This was tested on Dragon board RB3.

Last, bump up the compressed version so that userspace can check for the
support.

Since the series touches compress uapi and asoc, it would make sense to go
thru asoc tree with acks.

Vinod Koul (9):
  ALSA: compress: add wma codec profiles
  ALSA: compress: Add wma decoder params
  ASoC: qcom: q6asm: pass codec profile to q6asm_open_write
  ASoC: qcom: q6asm: add support to wma config
  ASoC: qcom: q6asm-dai: add support to wma decoder
  ALSA: compress: add alac & ape decoder params
  ASoC: qcom: q6asm: add support for alac and ape configs
  ASoC: qcom: q6asm-dai: add support for ALAC and APE decoders
  ALSA: compress: bump the version

 include/uapi/sound/compress_offload.h |   2 +-
 include/uapi/sound/compress_params.h  |  37 +++-
 sound/soc/qcom/qdsp6/q6asm-dai.c      | 136 +++++++++++++-
 sound/soc/qcom/qdsp6/q6asm.c          | 243 +++++++++++++++++++++++++-
 sound/soc/qcom/qdsp6/q6asm.h          |  51 +++++-
 5 files changed, 462 insertions(+), 7 deletions(-)

~Vinod

Comments

Takashi Iwai March 13, 2020, 7:22 a.m. UTC | #1 
On Fri, 13 Mar 2020 08:08:39 +0100,
Vinod Koul wrote:
> 
> Some codec profiles were missing for WMA, like WMA9/10 lossless and
> wma10 pro, so add these profiles
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  include/uapi/sound/compress_params.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> index 9c96fb0e4d90..634daa354b58 100644
> --- a/include/uapi/sound/compress_params.h
> +++ b/include/uapi/sound/compress_params.h
> @@ -142,6 +142,9 @@
>  #define SND_AUDIOPROFILE_WMA8                ((__u32) 0x00000002)
>  #define SND_AUDIOPROFILE_WMA9                ((__u32) 0x00000004)
>  #define SND_AUDIOPROFILE_WMA10               ((__u32) 0x00000008)
> +#define SND_AUDIOPROFILE_WMA9_PRO            ((__u32) 0x00000010)
> +#define SND_AUDIOPROFILE_WMA9_LOSSLESS       ((__u32) 0x00000011)
> +#define SND_AUDIOPROFILE_WMA10_LOSSLESS      ((__u32) 0x00000012)

Are the profiles are bit flags, or they are just enums?
All other definitions are set as if bit flags.


thanks,

Takashi