mbox series

[v2,00/15] regulator: Fix W=1 build warning when CONFIG_OF=n

Message ID 20200821111135.0b958d3a@xhacker.debian
Headers show
Series regulator: Fix W=1 build warning when CONFIG_OF=n | expand

Message

Jisheng Zhang Aug. 21, 2020, 3:11 a.m. UTC
Fixing W=1 build warning when no support for device tree is there.

Since v1:
  - fix the warning with __maybe_unused instead of CONFIG_OF macro
  - add 3 more patches to fix the same issue

Jisheng Zhang (15):
  regulator: 88pg86x: Fix W=1 build warning when CONFIG_OF=n
  regulator: da9210: Fix W=1 build warning when CONFIG_OF=n
  regulator: fan53555: Fix W=1 build warning when CONFIG_OF=n
  regulator: fixed: Fix W=1 build warnings when CONFIG_OF=n
  regulator: ltc3589: Fix W=1 build warning when CONFIG_OF=n
  regulator: ltc3676: Fix W=1 build warning when CONFIG_OF=n
  regulator: max1586: Fix W=1 build warning when CONFIG_OF=n
  regulator: max77826: Fix W=1 build warning when CONFIG_OF=n
  regulator: pwm: Fix W=1 build warning when CONFIG_OF=n
  regulator: stm32-pwr: Fix W=1 build warning when CONFIG_OF=n
  regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n
  regulator: sy8106a: Fix W=1 build warning when CONFIG_OF=n
  regulator: qcom-rpmh: Fix W=1 build warning when CONFIG_OF=n
  regulator: stm32-booster: Fix W=1 build warning when CONFIG_OF=n
  regulator: tps65023: Fix W=1 build warning when CONFIG_OF=n

 drivers/regulator/88pg86x.c             |  2 +-
 drivers/regulator/da9210-regulator.c    |  2 +-
 drivers/regulator/fan53555.c            |  2 +-
 drivers/regulator/fixed.c               | 16 ++++++++--------
 drivers/regulator/ltc3589.c             |  2 +-
 drivers/regulator/ltc3676.c             |  2 +-
 drivers/regulator/max1586.c             |  2 +-
 drivers/regulator/max77826-regulator.c  |  2 +-
 drivers/regulator/pwm-regulator.c       |  2 +-
 drivers/regulator/qcom-rpmh-regulator.c |  2 +-
 drivers/regulator/stm32-booster.c       |  2 +-
 drivers/regulator/stm32-pwr.c           |  2 +-
 drivers/regulator/stm32-vrefbuf.c       |  2 +-
 drivers/regulator/sy8106a-regulator.c   |  2 +-
 drivers/regulator/tps65023-regulator.c  |  2 +-
 15 files changed, 22 insertions(+), 22 deletions(-)

Comments

Fabrice Gasnier Aug. 21, 2020, 8:05 a.m. UTC | #1
On 8/21/20 5:17 AM, Jisheng Zhang wrote:
> Fix below warning when CONFIG_OF=n:
> 
> drivers/regulator/stm32-vrefbuf.c:287:34: warning: ‘stm32_vrefbuf_of_match’ defined but not used [-Wunused-const-variable=]
>   287 | static const struct of_device_id stm32_vrefbuf_of_match[] = {
>       |                                  ^~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>

Hi Jisheng,

Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>

Thanks for the patch,
Fabrice
> ---
>  drivers/regulator/stm32-vrefbuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/stm32-vrefbuf.c b/drivers/regulator/stm32-vrefbuf.c
> index 992bc18101ef..161622ea7259 100644
> --- a/drivers/regulator/stm32-vrefbuf.c
> +++ b/drivers/regulator/stm32-vrefbuf.c
> @@ -284,7 +284,7 @@ static const struct dev_pm_ops stm32_vrefbuf_pm_ops = {
>  			   NULL)
>  };
>  
> -static const struct of_device_id stm32_vrefbuf_of_match[] = {
> +static const struct of_device_id __maybe_unused stm32_vrefbuf_of_match[] = {
>  	{ .compatible = "st,stm32-vrefbuf", },
>  	{},
>  };
>
Mark Brown Aug. 21, 2020, 4:40 p.m. UTC | #2
On Fri, 21 Aug 2020 11:11:35 +0800, Jisheng Zhang wrote:
> Fixing W=1 build warning when no support for device tree is there.
> 
> Since v1:
>   - fix the warning with __maybe_unused instead of CONFIG_OF macro
>   - add 3 more patches to fix the same issue
> 
> Jisheng Zhang (15):
>   regulator: 88pg86x: Fix W=1 build warning when CONFIG_OF=n
>   regulator: da9210: Fix W=1 build warning when CONFIG_OF=n
>   regulator: fan53555: Fix W=1 build warning when CONFIG_OF=n
>   regulator: fixed: Fix W=1 build warnings when CONFIG_OF=n
>   regulator: ltc3589: Fix W=1 build warning when CONFIG_OF=n
>   regulator: ltc3676: Fix W=1 build warning when CONFIG_OF=n
>   regulator: max1586: Fix W=1 build warning when CONFIG_OF=n
>   regulator: max77826: Fix W=1 build warning when CONFIG_OF=n
>   regulator: pwm: Fix W=1 build warning when CONFIG_OF=n
>   regulator: stm32-pwr: Fix W=1 build warning when CONFIG_OF=n
>   regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n
>   regulator: sy8106a: Fix W=1 build warning when CONFIG_OF=n
>   regulator: qcom-rpmh: Fix W=1 build warning when CONFIG_OF=n
>   regulator: stm32-booster: Fix W=1 build warning when CONFIG_OF=n
>   regulator: tps65023: Fix W=1 build warning when CONFIG_OF=n
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[01/15] regulator: 88pg86x: Fix W=1 build warning when CONFIG_OF=n
        commit: e11e068ccbdb038e21e24ad2ee0157c902e3c9fc
[02/15] regulator: da9210: Fix W=1 build warning when CONFIG_OF=n
        commit: 2d2a84ae30a3bda57a22b283c55be8e9e6fd158b
[03/15] regulator: fan53555: Fix W=1 build warning when CONFIG_OF=n
        commit: 5e97d7e809a1fd8a2401429df13e0410b77d2142
[04/15] regulator: fixed: Fix W=1 build warnings when CONFIG_OF=n
        commit: 0f037255008386f4ac15a201678e8e4565cd91a3
[05/15] regulator: ltc3589: Fix W=1 build warning when CONFIG_OF=n
        commit: 8ece31564f1964d52eb1180ee33314c63533947e
[06/15] regulator: ltc3676: Fix W=1 build warning when CONFIG_OF=n
        commit: 1d4c1e02b96ea579f68412980ee1fe5f2ce57d8c
[07/15] regulator: max1586: Fix W=1 build warning when CONFIG_OF=n
        commit: 44bc5d168dc209bddafb3269f72a74c3cbb0d820
[08/15] regulator: max77826: Fix W=1 build warning when CONFIG_OF=n
        commit: 7bf0a29c354fc1855dc478916211b5194bab4393
[09/15] regulator: pwm: Fix W=1 build warning when CONFIG_OF=n
        commit: dc8c5ea3574e08e3c7105bbba5af5bb9c055903b
[10/15] regulator: stm32-pwr: Fix W=1 build warning when CONFIG_OF=n
        commit: a94a11ce0d5235e53bb74d54bbd5399c23abfd87
[11/15] regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n
        commit: d5579e7a2c6aa49a183440eb4e199f4a71543762
[12/15] regulator: sy8106a: Fix W=1 build warning when CONFIG_OF=n
        commit: bbe26107204eb64e7be1b3433e8b2252edc0b375
[13/15] regulator: qcom-rpmh: Fix W=1 build warning when CONFIG_OF=n
        commit: a2508eeb8dbdf621518f8c3538d3adcb6960619c
[14/15] regulator: stm32-booster: Fix W=1 build warning when CONFIG_OF=n
        commit: b461ac1cc6c0a0bc4a788d5d65cfd82e5f3bd856
[15/15] regulator: tps65023: Fix W=1 build warning when CONFIG_OF=n
        commit: 8536bf811dd7a25d90d9128f9db98b5ed8e5bd5c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark