| Message ID | 20200928063744.525700-1-ajye_huang@compal.corp-partner.google.com |
|---|---|
| Headers | show |
| Series | Modify documentation and machine driver for SC7180 sound card | expand |
On Mon, 28 Sep 2020 14:37:43 +0800, Ajye Huang wrote: > Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic" > for 2mic case. > > Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com> > --- > This patch depends on this patch series > https://patchwork.kernel.org/patch/11773221/ . > > .../bindings/sound/qcom,sc7180.yaml | 64 ++++++++++++++++++- > 1 file changed, 63 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Sep 28, 2020 at 02:37:43PM +0800, Ajye Huang wrote: > Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic" > for 2mic case. This doesn't apply against current code, please check and resend.
On Fri, Oct 9, 2020 at 9:52 PM Mark Brown <broonie@kernel.org> wrote: > > On Mon, Sep 28, 2020 at 02:37:43PM +0800, Ajye Huang wrote: > > Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic" > > for 2mic case. > > This doesn't apply against current code, please check and resend. Hi, Mark Thank you for your reply, This patch depends on Cheng-Yi's patch series https://patchwork.kernel.org/patch/11773221/. If I misunderstand what you mean, please correct me, Thank you,
On Sat, Oct 10, 2020 at 12:07:54AM +0800, Ajye Huang wrote: > On Fri, Oct 9, 2020 at 9:52 PM Mark Brown <broonie@kernel.org> wrote: > > On Mon, Sep 28, 2020 at 02:37:43PM +0800, Ajye Huang wrote: > > > Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic" > > > for 2mic case. > > This doesn't apply against current code, please check and resend. > Thank you for your reply, > This patch depends on Cheng-Yi's patch series > https://patchwork.kernel.org/patch/11773221/. That's "ASoC: qcom: dt-bindings: Add sc7180 machine bindings" for those playing at home. > If I misunderstand what you mean, please correct me, A version of some SC7180 patches was applied. However it does seem like that didn't include any machine driver bindings so it must've been a different, similar looking series which is presumably waiting for a new version - please resend based on that new version (ideally these patches could be picked up as part of that series). Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
On Mon, Oct 12, 2020 at 9:50 PM Mark Brown <broonie@kernel.org> wrote: > > On Sat, Oct 10, 2020 at 12:07:54AM +0800, Ajye Huang wrote: > > On Fri, Oct 9, 2020 at 9:52 PM Mark Brown <broonie@kernel.org> wrote: > > > On Mon, Sep 28, 2020 at 02:37:43PM +0800, Ajye Huang wrote: > > > > > Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic" > > > > for 2mic case. > > > > This doesn't apply against current code, please check and resend. > > > Thank you for your reply, > > This patch depends on Cheng-Yi's patch series > > https://patchwork.kernel.org/patch/11773221/. > > That's "ASoC: qcom: dt-bindings: Add sc7180 machine bindings" for those > playing at home. > > > If I misunderstand what you mean, please correct me, > > A version of some SC7180 patches was applied. However it does seem like > that didn't include any machine driver bindings so it must've been a > different, similar looking series which is presumably waiting for a new > version - please resend based on that new version (ideally these patches > could be picked up as part of that series). > > Please include human readable descriptions of things like commits and > issues being discussed in e-mail in your mails, this makes them much > easier for humans to read especially when they have no internet access. > I do frequently catch up on my mail on flights or while otherwise > travelling so this is even more pressing for me than just being about > making things a bit easier to read. Hi, Mark Thank you for your reply, I understand you point now, I will resend when it is done. thank you.
On Mon, 28 Sep 2020 14:37:42 +0800, Ajye Huang wrote: > Note: > - This patch depends on this patch series > ASoC: qcom: dt-bindings: Add sc7180 machine bindings > https://patchwork.kernel.org/patch/11773221/ > ASoC: qcom: sc7180: Add machine driver for sound card registration > https://patchwork.kernel.org/patch/11773223/ > - The patch is made by the collaboration of > Ajye Huang <ajye_huang@compal.corp-partner.google.com> > Cheng-Yi Chiang <cychiang@chromium.org> > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: qcom: dt-bindings: Modify sc7180 machine bindings (no commit info) [2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic commit: 3cfbf07c6d2779d24a6f5b999a91f400256b1d4e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark