| Message ID | 20210622201054.532979-1-iskren.chernev@gmail.com |
|---|---|
| Headers | show |
| Series | Add Pinctrl for SM4250 and SM6115 | expand |
On Tue, 22 Jun 2021 23:10:53 +0300, Iskren Chernev wrote: > Add device tree binding Documentation details for Qualcomm SM6115 and > SM4250 pinctrl. > > Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com> > --- > .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 172 ++++++++++++++++++ > 1 file changed, 172 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.example.dts:35.5-6 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1416: dt_binding_check] Error 2 \ndoc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1495840 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Tue 22 Jun 15:10 CDT 2021, Iskren Chernev wrote: > Add device tree binding Documentation details for Qualcomm SM6115 and > SM4250 pinctrl. > > Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com> > --- > .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 172 ++++++++++++++++++ > 1 file changed, 172 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > new file mode 100644 > index 000000000000..461edb7c5a1d > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml > @@ -0,0 +1,172 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,sm6115-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. SM6115, SM4250 TLMM block > + > +maintainers: > + - Iskren Chernev <iskren.chernev@gmail.com> > + > +description: | The '|' denotes that you want to keep the formatting, but there's no need for that in your description. > + This binding describes the Top Level Mode Multiplexer block found in the > + SM6115 and SM4250 platforms. > + > +properties: > + compatible: > + enum: > + - qcom,sm4250-tlmm > + - qcom,sm6115-tlmm > + > + reg: > + minItems: 3 > + maxItems: 3 > + > + reg-names: > + items: > + - const: "west" > + - const: "south" > + - const: "east" > + > + interrupts: > + description: Specifies the TLMM summary IRQ > + maxItems: 1 > + > + interrupt-controller: true > + > + '#interrupt-cells': > + description: > + Specifies the PIN numbers and Flags, as defined in defined in > + include/dt-bindings/interrupt-controller/irq.h > + const: 2 > + > + gpio-controller: true > + > + '#gpio-cells': > + description: Specifying the pin number and flags, as defined in > + include/dt-bindings/gpio/gpio.h > + const: 2 > + > + gpio-ranges: > + maxItems: 1 > + > + wakeup-parent: > + maxItems: 1 > + > +#PIN CONFIGURATION NODES > +patternProperties: > + '^.*$': > + if: > + type: object > + then: This doesn't cover the ability to define pinctrl state both in immediate nodes and nested one level down. So please mimic how this is done in Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$" This says that gpio0-9, gpio10-99 and gpio100-179 are valid, but the driver only presents gpio0-112, so this should be: ^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2]$ > + - enum: [ sdc1_rclk, sdc1_clk, sdc1_cmd, sdc1_data, > + sdc2_clk, sdc2_cmd, sdc2_data, ufs_reset ] > + minItems: 1 > + maxItems: 36 > + > + function: > + description: > + Specify the alternative function to be configured for the specified > + pins. > + > + enum: [ qup0, gpio, ddr_bist, phase_flag0, qdss_gpio8, atest_tsens, > + mpm_pwr, m_voc, phase_flag1, qdss_gpio9, atest_tsens2, > + phase_flag2, qdss_gpio10, dac_calib0, atest_usb10, > + phase_flag3, qdss_gpio11, dac_calib1, atest_usb11, qup1, > + cri_trng0, phase_flag4, dac_calib2, atest_usb12, cri_trng1, > + phase_flag5, dac_calib3, atest_usb13, qup2, phase_flag6, > + dac_calib4, atest_usb1, qup3, pbs_out, pll_bist, qdss_gpio, > + tsense_pwm, agera_pll, pbs0, qdss_gpio0, pbs1, qdss_gpio1, > + qup4, tgu_ch0, tgu_ch1, qup5, tgu_ch2, phase_flag7, > + qdss_gpio4, dac_calib5, tgu_ch3, phase_flag8, qdss_gpio5, > + dac_calib6, phase_flag9, qdss_gpio6, dac_calib7, > + phase_flag10, qdss_gpio7, dac_calib8, sdc2_tb, cri_trng, > + pbs2, qdss_gpio2, sdc1_tb, pbs3, qdss_gpio3, cam_mclk, pbs4, > + adsp_ext, pbs5, cci_i2c, prng_rosc, pbs6, phase_flag11, > + dac_calib9, atest_usb20, pbs7, phase_flag12, dac_calib10, > + atest_usb21, cci_timer1, gcc_gp1, pbs8, phase_flag13, > + dac_calib11, atest_usb22, cci_async, cci_timer0, pbs9, > + phase_flag14, dac_calib12, atest_usb23, pbs10, phase_flag15, > + dac_calib13, atest_usb2, vsense_trigger, qdss_cti, > + cci_timer2, phase_flag16, dac_calib14, atest_char, > + phase_flag17, dac_calib15, atest_char0, gp_pdm0, > + phase_flag18, dac_calib16, atest_char1, cci_timer3, gp_pdm1, > + phase_flag19, dac_calib17, atest_char2, gp_pdm2, > + phase_flag20, dac_calib18, atest_char3, phase_flag21, > + phase_flag22, nav_gpio, phase_flag23, phase_flag24, > + phase_flag25, pbs14, qdss_gpio14, vfr_1, pbs15, qdss_gpio15, > + pa_indicator, gsm1_tx, ssbi_wtr1, pll_bypassnl, pll_reset, > + phase_flag26, ddr_pxi0, gsm0_tx, phase_flag27, gcc_gp2, > + qdss_gpio12, ddr_pxi1, gcc_gp3, qdss_gpio13, dbg_out, > + uim2_data, uim2_clk, uim2_reset, uim2_present, uim1_data, > + uim1_clk, uim1_reset, uim1_present, dac_calib19, mdp_vsync, > + mdp_vsync_out_0, mdp_vsync_out_1, dac_calib20, dac_calib21, > + atest_bbrx1, pbs11, usb_phy, atest_bbrx0, mss_lte, pbs12, > + pbs13, wlan1_adc0, wlan1_adc1, sd_write, jitter_bist, > + atest_gpsadc_dtest0_native, atest_gpsadc_dtest1_native, > + phase_flag28, dac_calib22, ddr_pxi2, phase_flag29, > + dac_calib23, phase_flag30, dac_calib24, ddr_pxi3, > + phase_flag31, dac_calib25 ] > + > + drive-strength: > + enum: [2, 4, 6, 8, 10, 12, 14, 16] > + default: 2 > + description: > + Selects the drive strength for the specified pins, in mA. > + > + bias-pull-down: true > + > + bias-pull-up: true > + > + bias-disable: true > + > + output-high: true > + > + output-low: true > + > + required: > + - pins > + - function > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-controller > + - '#interrupt-cells' > + - gpio-controller > + - '#gpio-cells' > + - gpio-ranges > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + pinctrl@500000 { > + compatible = "qcom,sm4250-tlmm"; > + reg = <0x500000 0x400000>, > + <0x900000 0x400000>, > + <0xd00000 0x400000>; > + reg-names = "west", "south", "east"; > + interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + gpio-ranges = <&tlmm 0 0 121>; You only have 114 (113 GPIOs + UFS_RESET) gpios. Doesn't the &tlmm need to be defined in the example as well? > + wakeup-parent = <&intc>; The wakeup-parent should most likely be &pdc, but feel free to omit "wakup-parent" from the example if that helps. Regards, Bjorn > + } > + > -- > 2.31.1 >