mbox series

[v3,0/2] Add UFS PHY support for SM6115/4250

Message ID 20210821155657.893165-1-iskren.chernev@gmail.com
Headers show
Series Add UFS PHY support for SM6115/4250 | expand

Message

Iskren Chernev Aug. 21, 2021, 3:56 p.m. UTC 
The UFS PHY found on SM6115/4250 has a lot of common registers with ufs phy v2,
even though in downstream it is named v3-660. Due to register similarity with
v2, the few extra registers that are needed are added as v2 registers.

The register values/sequences are taken from OnePlus repo [1].

[1] https://github.com/OnePlusOSS/android_kernel_oneplus_sm4250

v1: https://lkml.org/lkml/2021/8/5/235
v2: https://lkml.org/lkml/2021/8/13/889

Changes from v2:
- Suggested by Vinod
  - the 6115 registers had a lot in common with v2 registers (and not v3, as
    was initially assumed), so those were reused whenever possible, and new
    regs were added along other v2 registers.

Changes from v1:
- Suggested by Vinod
  - removed v3-660 constants for regs with same name and value as v3 regs

Iskren Chernev (2):
  dt-bindings: phy: qcom,qmp: Add SM6115 UFS PHY bindings
  phy: qcom-qmp: Add support for SM6115 UFS phy

 .../devicetree/bindings/phy/qcom,qmp-phy.yaml |   1 +
 drivers/phy/qualcomm/phy-qcom-qmp.c           | 124 ++++++++++++++++++
 drivers/phy/qualcomm/phy-qcom-qmp.h           |  18 +++
 3 files changed, 143 insertions(+)


base-commit: 86ed57fd8c93fdfaabb4f58e78455180fa7d8a84

Comments

Vinod Koul Aug. 23, 2021, 5:43 a.m. UTC | #1 
On 21-08-21, 18:56, Iskren Chernev wrote:
> The UFS PHY found on SM6115/4250 has a lot of common registers with ufs phy v2,
> even though in downstream it is named v3-660. Due to register similarity with
> v2, the few extra registers that are needed are added as v2 registers.
> 
> The register values/sequences are taken from OnePlus repo [1].

This looks very good, thanks for cleaning it up

Applied now