mbox series

[0/2] Two apcs-kpss-global.yaml fixes

Message ID 20220630043536.3308546-1-bryan.odonoghue@linaro.org
Headers show
Series Two apcs-kpss-global.yaml fixes | expand

Message

Bryan O'Donoghue June 30, 2022, 4:35 a.m. UTC 
Adding in msm8939.dtsi and running the binding checks is throwing up two
errors for me.

In the first instance we use syscon on the 8939 and should declare it in
the compat list. Doing a quick grep it looks like that fix should be
applied to a number of existing declarations too.

In the second instance we just need to document clock-output-names for the
a53 mux PLL.

Bryan O'Donoghue (2):
  dt-bindings: mailbox: qcom: Add syscon const for relevant entries
  dt-bindings: mailbox: qcom: Add clock-output-names

 .../mailbox/qcom,apcs-kpss-global.yaml        | 49 +++++++++++--------
 1 file changed, 29 insertions(+), 20 deletions(-)

Comments

Bryan O'Donoghue June 30, 2022, 1:51 p.m. UTC | #1 
On 30/06/2022 14:44, Rob Herring wrote:
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.example.dtb: mailbox@b011000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['qcom,qcs404-apcs-apps-global'] is too short

ah... the example

will fix

---
bod
Krzysztof Kozlowski June 30, 2022, 6:37 p.m. UTC | #2 
On 30/06/2022 06:35, Bryan O'Donoghue wrote:
> msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should
> declare syscon as they have drivers that use syscon inside of the apcs-kpss
> block.
> 
> grep apcs arch/arm64/boot/dts/qcom/* | grep syscon
> 
> Add in the additional syscon in the documentation for the above mentioned
> parts.

Subject should have prefix:
dt-bindings: mailbox: qcom,apcs-kpss-global:

> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../mailbox/qcom,apcs-kpss-global.yaml        | 44 ++++++++++---------
>  1 file changed, 24 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 3b5ba7ecc19d9..f342494fd6108 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -15,26 +15,30 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,ipq6018-apcs-apps-global
> -      - qcom,ipq8074-apcs-apps-global
> -      - qcom,msm8916-apcs-kpss-global
> -      - qcom,msm8939-apcs-kpss-global
> -      - qcom,msm8953-apcs-kpss-global
> -      - qcom,msm8976-apcs-kpss-global
> -      - qcom,msm8994-apcs-kpss-global
> -      - qcom,msm8996-apcs-hmss-global
> -      - qcom,msm8998-apcs-hmss-global
> -      - qcom,qcm2290-apcs-hmss-global
> -      - qcom,qcs404-apcs-apps-global
> -      - qcom,sc7180-apss-shared
> -      - qcom,sc8180x-apss-shared
> -      - qcom,sdm660-apcs-hmss-global
> -      - qcom,sdm845-apss-shared
> -      - qcom,sm6125-apcs-hmss-global
> -      - qcom,sm6115-apcs-hmss-global
> -      - qcom,sm8150-apss-shared
> -
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,ipq6018-apcs-apps-global
> +              - qcom,ipq8074-apcs-apps-global
> +              - qcom,msm8976-apcs-kpss-global
> +              - qcom,msm8996-apcs-hmss-global
> +              - qcom,msm8998-apcs-hmss-global
> +              - qcom,qcm2290-apcs-hmss-global
> +              - qcom,sc7180-apss-shared
> +              - qcom,sc8180x-apss-shared
> +              - qcom,sdm660-apcs-hmss-global
> +              - qcom,sdm845-apss-shared
> +              - qcom,sm6125-apcs-hmss-global
> +              - qcom,sm6115-apcs-hmss-global
> +              - qcom,sm8150-apss-shared

These are not items, but one item, so enum directly under oneOf.

> +      - items:
> +          - enum:
> +              - qcom,msm8916-apcs-kpss-global
> +              - qcom,msm8939-apcs-kpss-global
> +              - qcom,msm8953-apcs-kpss-global
> +              - qcom,msm8994-apcs-kpss-global
> +              - qcom,qcs404-apcs-apps-global
> +          - const: syscon
>    reg:
>      maxItems: 1
>  


Best regards,
Krzysztof