| Message ID | 20220712125922.3461675-1-bryan.odonoghue@linaro.org |
|---|---|
| Headers | show |
| Series | clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver | expand |
On 12.07.2022 14:59, Bryan O'Donoghue wrote: > The Venus clock frequencies are a copy/paste error from msm8916. Looking > at the original clock-gcc-8936.c ftbl_gcc_venus0_vcodec0_clk defines we > have: > > - 133 MHz > - 200 MHz > - 266 MHz > > These values are born out by the relevant qualcomm documentation for the > msm8936/msm8939 Venus core performance levels. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > drivers/clk/qcom/gcc-msm8939.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c > index 6a3e2326c72a3..2aad40dbef8e6 100644 > --- a/drivers/clk/qcom/gcc-msm8939.c > +++ b/drivers/clk/qcom/gcc-msm8939.c > @@ -1824,9 +1824,9 @@ static struct clk_branch gcc_ultaudio_pcnoc_sway_clk = { > }; > > static const struct freq_tbl ftbl_gcc_venus0_vcodec0_clk[] = { > - F(100000000, P_GPLL0, 8, 0, 0), > - F(160000000, P_GPLL0, 5, 0, 0), > - F(228570000, P_GPLL0, 3.5, 0, 0), > + F(133330000, P_GPLL0, 6, 0, 0), > + F(200000000, P_GPLL0, 4, 0, 0), > + F(266670000, P_GPLL0, 3, 0, 0), > { } > }; >
The gcc-msm8939 driver is a copy/paste of the gcc-msm8916 for the good reason that msm8936/msm8939 are an expanded version of msm8916. Reviewing the qcom driver though there are some obvious missing/wrong frequencies which a simple side-by-side comparison can show up. This series captures that side-by-side and transmits into updated frequency tables. Bryan O'Donoghue (6): clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies clk: qcom: gcc-msm8939: Add missing MDSS MDP clock frequencies clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies drivers/clk/qcom/gcc-msm8939.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)