mbox series

[v3,0/5] dt-bindings: mmc: / ARM: qcom: correct reg-names and clock entries

Message ID 20220712144245.17417-1-krzysztof.kozlowski@linaro.org
Headers show
Series dt-bindings: mmc: / ARM: qcom: correct reg-names and clock entries | expand

Message

Krzysztof Kozlowski July 12, 2022, 2:42 p.m. UTC 
Hi,

No dependencies.  DT bindings patches are independent from DTS, so they can go
via separate tree.

Changes since v2
================
1. Add Rb tags.
2. Correct typo in subject of patch 2.

Changes since v1
================
1. Add Rb tags.
2. Rework reg-names constraints according to Doug's feedback.

Best regards,
Krzysztof

Krzysztof Kozlowski (5):
  dt-bindings: mmc: sdhci-msm: fix reg-names entries
  dt-bindings: mmc: sdhci-msm: constrain reg-names per variants
  arm64: dts: qcom: align SDHCI reg-names with DT schema
  ARM: dts: qcom: align SDHCI reg-names with DT schema
  ARM: dts: qcom: align SDHCI clocks with DT schema

 .../devicetree/bindings/mmc/sdhci-msm.yaml    | 61 ++++++++++++-------
 arch/arm/boot/dts/qcom-apq8084.dtsi           | 16 ++---
 arch/arm/boot/dts/qcom-ipq4019.dtsi           |  5 +-
 arch/arm/boot/dts/qcom-msm8226.dtsi           | 24 ++++----
 arch/arm/boot/dts/qcom-msm8974.dtsi           | 24 ++++----
 arch/arm/boot/dts/qcom-msm8974pro.dtsi        |  6 +-
 arch/arm/boot/dts/qcom-sdx65.dtsi             |  2 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi         |  2 +-
 arch/arm64/boot/dts/qcom/msm8916.dtsi         |  4 +-
 arch/arm64/boot/dts/qcom/msm8953.dtsi         |  4 +-
 arch/arm64/boot/dts/qcom/msm8994.dtsi         |  4 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |  4 +-
 arch/arm64/boot/dts/qcom/msm8998.dtsi         |  2 +-
 13 files changed, 87 insertions(+), 71 deletions(-)

Comments

Ulf Hansson July 13, 2022, 10:55 a.m. UTC | #1 
On Tue, 12 Jul 2022 at 16:42, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bindings before conversion to DT schema expected reg-names without
> "_mem" suffix.  This was used by older DTS files and by the MSM SDHCI
> driver.
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Fixes: edfbf8c307ff ("dt-bindings: mmc: sdhci-msm: Fix issues in yaml bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  .../devicetree/bindings/mmc/sdhci-msm.yaml    | 24 +++++++++----------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 0853d0c32dc7..fc6e5221985a 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -60,22 +60,22 @@ properties:
>      maxItems: 4
>      oneOf:
>        - items:
> -          - const: hc_mem
> +          - const: hc
>        - items:
> -          - const: hc_mem
> -          - const: core_mem
> +          - const: hc
> +          - const: core
>        - items:
> -          - const: hc_mem
> -          - const: cqe_mem
> +          - const: hc
> +          - const: cqhci
>        - items:
> -          - const: hc_mem
> -          - const: cqe_mem
> -          - const: ice_mem
> +          - const: hc
> +          - const: cqhci
> +          - const: ice
>        - items:
> -          - const: hc_mem
> -          - const: core_mem
> -          - const: cqe_mem
> -          - const: ice_mem
> +          - const: hc
> +          - const: core
> +          - const: cqhci
> +          - const: ice
>
>    clocks:
>      minItems: 3
> --
> 2.34.1
>
Bjorn Andersson Sept. 15, 2022, 3:36 a.m. UTC | #2 
On Tue, 12 Jul 2022 16:42:40 +0200, Krzysztof Kozlowski wrote:
> No dependencies.  DT bindings patches are independent from DTS, so they can go
> via separate tree.
> 
> Changes since v2
> ================
> 1. Add Rb tags.
> 2. Correct typo in subject of patch 2.
> 
> [...]

Applied, thanks!

[4/5] ARM: dts: qcom: align SDHCI reg-names with DT schema
      commit: 5eb82ddb7273bd34a36c05df271f34919eeea675
[5/5] ARM: dts: qcom: align SDHCI clocks with DT schema
      commit: 49c19337d0aca2e7f362d3c1a1c6f09c2dcfdae9

Best regards,