mbox series

[v7,0/3] dt-bindings: arm: qcom: qcom,board-id and qcom,msm-id

Message ID 20220830065744.161163-1-krzysztof.kozlowski@linaro.org
Headers show
Series dt-bindings: arm: qcom: qcom,board-id and qcom,msm-id | expand

Message

Krzysztof Kozlowski Aug. 30, 2022, 6:57 a.m. UTC 
Hi,

Changes since v6
================
1. Rebase (new IDs).
2. qcom_board_id2 -> qcom_board_id_named (Bjorn).
3. Add Rb tags.

Changes since v5
================
1. Dual-license qcom,ids.h (Rob).
2. Minor corrections in comments.

Changes since v4
================
1. Change the qcom,board-id oneOf (oneOf at higher level) so newer dtschema is happy.

Changes since v3
================
1. Patch #1: Define all SoC IDs, based on Qualcomm socid driver (Konrad). Keep
   Dmitry Rb tag, even though it is quite a change.
2. New patch #2: use bindings in the socid driver.  The patch fails on checkpatch:
   "Macros with complex values should be enclosed in parentheses"
   but that's expected considering the macro contents.

Changes since v2
================
1. Adjust description of new fields after review (Dmitry).
2. Change name of msm8996 define (Dmitry).
3. Add Rb tags.

Changes since v1
================
1. Make the qcom,board-id and qcom,msm-id properties deprecated and limited to
   certain SoCs (Rob).
2. Extend the qcom,board-id schema to match OnePlus variant - four elements -
   and drop DTS patches splitting four into two touples (Stephan).

Description
===========
The discussion [1] brought several arguments for keeping the qcom,board-id and
qcom,msm-id properties.  Keeping means we should document them, so the DT
schema checks pass.

I revived old patch [2] with several changes and improvements.  The commit msg
hopefully collects feedback from the discussion.

Best regards,
Krzysztof

[1] https://lore.kernel.org/r/a3c932d1-a102-ce18-deea-18cbbd05ecab@linaro.org/
[2] https://lore.kernel.org/all/1425503602-24916-1-git-send-email-galak@codeaurora.org/

Krzysztof Kozlowski (3):
  dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id
  soc: qcom: socinfo: create soc_id table from bindings
  arm64: dts: qcom: msm8992-xiaomi-libra: split qcom,msm-id into tuples

 .../devicetree/bindings/arm/qcom.yaml         | 120 ++++++++
 .../boot/dts/qcom/msm8992-xiaomi-libra.dts    |   2 +-
 drivers/soc/qcom/socinfo.c                    | 265 +++++++++---------
 include/dt-bindings/arm/qcom,ids.h            | 155 ++++++++++
 4 files changed, 412 insertions(+), 130 deletions(-)
 create mode 100644 include/dt-bindings/arm/qcom,ids.h

Comments

Krzysztof Kozlowski Aug. 30, 2022, 9:30 a.m. UTC | #1 
On 30/08/2022 09:57, Krzysztof Kozlowski wrote:
> The qcom,msm-id is an uint32 matrix, so a list of tuples.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch can be ignored. I missed that v6 was applied (there were no
changes between v6 and v7 here).

Best regards,
Krzysztof