mbox series

[0/3] phy: qcom-qmp-pcie: shorten function prefixes

Message ID 20220906074550.4383-1-johan+linaro@kernel.org
Headers show
Series phy: qcom-qmp-pcie: shorten function prefixes | expand

Message

Johan Hovold Sept. 6, 2022, 7:45 a.m. UTC 
The QMP PHY driver function prefixes have become unnecessarily long
(e.g. after the recent driver split) and hurt readability.

This series shortens the "qcom_qmp_phy_pcie" prefix to "qmp_pcie" (QMP
likely stands for "Qualcomm Multi PHY" or similar anyway) and clean up
the code somewhat.

Once merged I can do the same conversion of the other four QMP drivers.

Johan



Dmitry Baryshkov (1):
  phy: qcom-qmp-pcie: drop if (table) conditions

Johan Hovold (2):
  phy: qcom-qmp-pcie: shorten function prefixes
  phy: qcom-qmp: drop dual-lane comments

 drivers/phy/qualcomm/phy-qcom-qmp-combo.c |   1 -
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c  | 145 ++++++++++------------
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c   |   1 -
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c   |   1 -
 4 files changed, 63 insertions(+), 85 deletions(-)

Comments

Vinod Koul Sept. 13, 2022, 2:53 p.m. UTC | #1 
On 06-09-22, 09:45, Johan Hovold wrote:
> The QMP PHY driver function prefixes have become unnecessarily long
> (e.g. after the recent driver split) and hurt readability.
> 
> This series shortens the "qcom_qmp_phy_pcie" prefix to "qmp_pcie" (QMP
> likely stands for "Qualcomm Multi PHY" or similar anyway) and clean up
> the code somewhat.

Applied, thanks

> 
> Once merged I can do the same conversion of the other four QMP drivers.

Patches welcome!
Johan Hovold Sept. 14, 2022, 6:11 a.m. UTC | #2 
On Tue, Sep 13, 2022 at 08:23:52PM +0530, Vinod Koul wrote:
> On 06-09-22, 09:45, Johan Hovold wrote:
> > The QMP PHY driver function prefixes have become unnecessarily long
> > (e.g. after the recent driver split) and hurt readability.
> > 
> > This series shortens the "qcom_qmp_phy_pcie" prefix to "qmp_pcie" (QMP
> > likely stands for "Qualcomm Multi PHY" or similar anyway) and clean up
> > the code somewhat.

> > Once merged I can do the same conversion of the other four QMP drivers.
> 
> Patches welcome!

I went ahead and did the corresponding changes to the rest of the QMP
drivers so the result should already be in you inbox:

	https://lore.kernel.org/lkml/20220907110728.19092-1-johan+linaro@kernel.org/

Johan