mbox series

[0/2] Add interconnect support for QDU1000/QRU1000 SoCs

Message ID 20221001030602.28232-1-quic_molvera@quicinc.com
Headers show
Series Add interconnect support for QDU1000/QRU1000 SoCs | expand

Message

Melody Olvera Oct. 1, 2022, 3:06 a.m. UTC 
Add dt bindings and driver support for the Qualcomm QDU1000 and QRU1000
SoCs.

The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf

Melody Olvera (2):
  dt-bindings: interconnect: Add QDU1000/QRU1000 dt bindings
  interconnect: qcom: Add QDU1000/QRU1000 interconnect driver

 .../bindings/interconnect/qcom,rpmh.yaml      |    8 +
 drivers/interconnect/qcom/Kconfig             |    9 +
 drivers/interconnect/qcom/Makefile            |    2 +
 drivers/interconnect/qcom/qdru1000.c          | 1091 +++++++++++++++++
 drivers/interconnect/qcom/qdru1000.h          |   95 ++
 .../dt-bindings/interconnect/qcom,qdru1000.h  |   98 ++
 6 files changed, 1303 insertions(+)
 create mode 100644 drivers/interconnect/qcom/qdru1000.c
 create mode 100644 drivers/interconnect/qcom/qdru1000.h
 create mode 100644 include/dt-bindings/interconnect/qcom,qdru1000.h


base-commit: 987a926c1d8a40e4256953b04771fbdb63bc7938

Comments

Dmitry Baryshkov Oct. 1, 2022, 7:13 a.m. UTC | #1 
On Sat, 1 Oct 2022 at 06:08, Melody Olvera <quic_molvera@quicinc.com> wrote:
>
> Add interconnect provider driver for Qualcomm QDU1000 and QRU1000
> platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  drivers/interconnect/qcom/Kconfig    |    9 +
>  drivers/interconnect/qcom/Makefile   |    2 +
>  drivers/interconnect/qcom/qdru1000.c | 1091 ++++++++++++++++++++++++++
>  drivers/interconnect/qcom/qdru1000.h |   95 +++
>  4 files changed, 1197 insertions(+)
>  create mode 100644 drivers/interconnect/qcom/qdru1000.c
>  create mode 100644 drivers/interconnect/qcom/qdru1000.h
>
> diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> index 25d5b4baf6f6..760f855d7618 100644
> --- a/drivers/interconnect/qcom/Kconfig
> +++ b/drivers/interconnect/qcom/Kconfig
> @@ -200,5 +200,14 @@ config INTERCONNECT_QCOM_SM8450
>           This is a driver for the Qualcomm Network-on-Chip on SM8450-based
>           platforms.
>
> +config INTERCONNECT_QCOM_QDRU1000
> +       tristate "Qualcomm QDU1000/QRU1000 interconnect driver"
> +       depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
> +       select INTERCONNECT_QCOM_RPMH
> +       select INTERCONNECT_QCOM_BCM_VOTER
> +       help
> +         This is a driver for the Qualcomm Network-on-Chip on QDU1000-based
> +         and QRU1000-based platforms.
> +
>  config INTERCONNECT_QCOM_SMD_RPM
>         tristate
> diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom/Makefile
> index 8e357528185d..85b7f0de473d 100644
> --- a/drivers/interconnect/qcom/Makefile
> +++ b/drivers/interconnect/qcom/Makefile
> @@ -25,6 +25,7 @@ qnoc-sm8150-objs                      := sm8150.o
>  qnoc-sm8250-objs                       := sm8250.o
>  qnoc-sm8350-objs                       := sm8350.o
>  qnoc-sm8450-objs                       := sm8450.o
> +qnoc-qdru1000-objs                     := qdru1000.o

Alphabetic sorting

>  icc-smd-rpm-objs                       := smd-rpm.o icc-rpm.o
>
>  obj-$(CONFIG_INTERCONNECT_QCOM_BCM_VOTER) += icc-bcm-voter.o
> @@ -49,4 +50,5 @@ obj-$(CONFIG_INTERCONNECT_QCOM_SM8150) += qnoc-sm8150.o
>  obj-$(CONFIG_INTERCONNECT_QCOM_SM8250) += qnoc-sm8250.o
>  obj-$(CONFIG_INTERCONNECT_QCOM_SM8350) += qnoc-sm8350.o
>  obj-$(CONFIG_INTERCONNECT_QCOM_SM8450) += qnoc-sm8450.o
> +obj-$(CONFIG_INTERCONNECT_QCOM_QDRU1000) += qnoc-qdru1000.o

Alphabetic sorting.
Krzysztof Kozlowski Oct. 1, 2022, 9:31 a.m. UTC | #2 
On 01/10/2022 05:06, Melody Olvera wrote:
> Add interconnect IDs for Qualcomm QDU1000 and QRU1000 platforms.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  .../bindings/interconnect/qcom,rpmh.yaml      |  8 ++
>  .../dt-bindings/interconnect/qcom,qdru1000.h  | 98 +++++++++++++++++++
>  2 files changed, 106 insertions(+)
>  create mode 100644 include/dt-bindings/interconnect/qcom,qdru1000.h
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> index a429a1ed1006..c524d92ee203 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> @@ -132,6 +132,14 @@ properties:
>        - qcom,sm8450-nsp-noc
>        - qcom,sm8450-pcie-anoc
>        - qcom,sm8450-system-noc
> +      - qcom,qdu1000-clk-virt
> +      - qcom,qdu1000-gem-noc
> +      - qcom,qdu1000-mc-virt
> +      - qcom,qdu1000-system-noc
> +      - qcom,qru1000-clk-virt
> +      - qcom,qru1000-gem-noc
> +      - qcom,qru1000-mc-virt
> +      - qcom,qru1000-system-noc

Not a correct order.

>  
>    '#interconnect-cells': true
>  
> diff --git a/include/dt-bindings/interconnect/qcom,qdru1000.h b/include/dt-bindings/interconnect/qcom,qdru1000.h
> new file mode 100644
> index 000000000000..2bdfa0c15d2c
> --- /dev/null
> +++ b/include/dt-bindings/interconnect/qcom,qdru1000.h
> @@ -0,0 +1,98 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */

Dual license.


Best regards,
Krzysztof
Melody Olvera Oct. 4, 2022, 8:02 p.m. UTC | #3 
On 10/1/2022 4:31 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> Add interconnect IDs for Qualcomm QDU1000 and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  .../bindings/interconnect/qcom,rpmh.yaml      |  8 ++
>>  .../dt-bindings/interconnect/qcom,qdru1000.h  | 98 +++++++++++++++++++
>>  2 files changed, 106 insertions(+)
>>  create mode 100644 include/dt-bindings/interconnect/qcom,qdru1000.h
>>
>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
>> index a429a1ed1006..c524d92ee203 100644
>> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
>> @@ -132,6 +132,14 @@ properties:
>>        - qcom,sm8450-nsp-noc
>>        - qcom,sm8450-pcie-anoc
>>        - qcom,sm8450-system-noc
>> +      - qcom,qdu1000-clk-virt
>> +      - qcom,qdu1000-gem-noc
>> +      - qcom,qdu1000-mc-virt
>> +      - qcom,qdu1000-system-noc
>> +      - qcom,qru1000-clk-virt
>> +      - qcom,qru1000-gem-noc
>> +      - qcom,qru1000-mc-virt
>> +      - qcom,qru1000-system-noc
> Not a correct order.
Will fix to alphabetical.
>
>>  
>>    '#interconnect-cells': true
>>  
>> diff --git a/include/dt-bindings/interconnect/qcom,qdru1000.h b/include/dt-bindings/interconnect/qcom,qdru1000.h
>> new file mode 100644
>> index 000000000000..2bdfa0c15d2c
>> --- /dev/null
>> +++ b/include/dt-bindings/interconnect/qcom,qdru1000.h
>> @@ -0,0 +1,98 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
> Dual license.
Will add second license.
>
>
> Best regards,
> Krzysztof
Thanks,
Melody
Melody Olvera Oct. 4, 2022, 8:02 p.m. UTC | #4 
On 10/1/2022 2:13 AM, Dmitry Baryshkov wrote:
> On Sat, 1 Oct 2022 at 06:08, Melody Olvera <quic_molvera@quicinc.com> wrote:
>> Add interconnect provider driver for Qualcomm QDU1000 and QRU1000
>> platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  drivers/interconnect/qcom/Kconfig    |    9 +
>>  drivers/interconnect/qcom/Makefile   |    2 +
>>  drivers/interconnect/qcom/qdru1000.c | 1091 ++++++++++++++++++++++++++
>>  drivers/interconnect/qcom/qdru1000.h |   95 +++
>>  4 files changed, 1197 insertions(+)
>>  create mode 100644 drivers/interconnect/qcom/qdru1000.c
>>  create mode 100644 drivers/interconnect/qcom/qdru1000.h
>>
>> diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
>> index 25d5b4baf6f6..760f855d7618 100644
>> --- a/drivers/interconnect/qcom/Kconfig
>> +++ b/drivers/interconnect/qcom/Kconfig
>> @@ -200,5 +200,14 @@ config INTERCONNECT_QCOM_SM8450
>>           This is a driver for the Qualcomm Network-on-Chip on SM8450-based
>>           platforms.
>>
>> +config INTERCONNECT_QCOM_QDRU1000
>> +       tristate "Qualcomm QDU1000/QRU1000 interconnect driver"
>> +       depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
>> +       select INTERCONNECT_QCOM_RPMH
>> +       select INTERCONNECT_QCOM_BCM_VOTER
>> +       help
>> +         This is a driver for the Qualcomm Network-on-Chip on QDU1000-based
>> +         and QRU1000-based platforms.
>> +
>>  config INTERCONNECT_QCOM_SMD_RPM
>>         tristate
>> diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom/Makefile
>> index 8e357528185d..85b7f0de473d 100644
>> --- a/drivers/interconnect/qcom/Makefile
>> +++ b/drivers/interconnect/qcom/Makefile
>> @@ -25,6 +25,7 @@ qnoc-sm8150-objs                      := sm8150.o
>>  qnoc-sm8250-objs                       := sm8250.o
>>  qnoc-sm8350-objs                       := sm8350.o
>>  qnoc-sm8450-objs                       := sm8450.o
>> +qnoc-qdru1000-objs                     := qdru1000.o
> Alphabetic sorting
Will fix.
>
>>  icc-smd-rpm-objs                       := smd-rpm.o icc-rpm.o
>>
>>  obj-$(CONFIG_INTERCONNECT_QCOM_BCM_VOTER) += icc-bcm-voter.o
>> @@ -49,4 +50,5 @@ obj-$(CONFIG_INTERCONNECT_QCOM_SM8150) += qnoc-sm8150.o
>>  obj-$(CONFIG_INTERCONNECT_QCOM_SM8250) += qnoc-sm8250.o
>>  obj-$(CONFIG_INTERCONNECT_QCOM_SM8350) += qnoc-sm8350.o
>>  obj-$(CONFIG_INTERCONNECT_QCOM_SM8450) += qnoc-sm8450.o
>> +obj-$(CONFIG_INTERCONNECT_QCOM_QDRU1000) += qnoc-qdru1000.o
> Alphabetic sorting.
Will fix.
>
>
Thanks,
Melody