mbox series

[0/3] phy: qcom-qmp: misc cleanups

Message ID 20221111094239.11547-1-johan+linaro@kernel.org
Headers show
Series phy: qcom-qmp: misc cleanups | expand

Message

Johan Hovold Nov. 11, 2022, 9:42 a.m. UTC 
Here are three cleanups to the non-combo QMP drivers for smaller issues
found while reworking the combo driver.

Johan


Johan Hovold (3):
  phy: qcom-qmp: drop unused type header
  phy: qcom-qmp-usb: drop redundant clock allocation
  phy: qcom-qmp-pcie: drop redundant clock allocation

 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c |  2 --
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c         | 10 +++-------
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c          |  2 --
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c          | 10 +++-------
 4 files changed, 6 insertions(+), 18 deletions(-)

Comments

Dmitry Baryshkov Nov. 12, 2022, 7:52 a.m. UTC | #1 
On 11/11/2022 12:42, Johan Hovold wrote:
> The PHY type defines are no longer used in the PCIe, UFS and USB QMP
> drivers so drop the corresponding include.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 2 --
>   drivers/phy/qualcomm/phy-qcom-qmp-pcie.c         | 2 --
>   drivers/phy/qualcomm/phy-qcom-qmp-ufs.c          | 2 --
>   drivers/phy/qualcomm/phy-qcom-qmp-usb.c          | 2 --
>   4 files changed, 8 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Dmitry Baryshkov Nov. 14, 2022, 9:51 a.m. UTC | #2 
On 11/11/2022 12:42, Johan Hovold wrote:
> Since the QMP driver split, there is no reason to allocate the
> fixed-rate pipe clock structure separately from the driver data.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>