mbox series

[0/2] Add SM4250 RPM power domain support

Message ID 20221127112204.1486337-1-bhupesh.sharma@linaro.org
Headers show
Series Add SM4250 RPM power domain support | expand

Message

Bhupesh Sharma Nov. 27, 2022, 11:22 a.m. UTC 
Add RPM power domain support for SM4250.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> 

Bhupesh Sharma (2):
  dt-bindings: power: rpmpd: Add SM4250 support
  soc: qcom: rpmpd: Add SM4250 support

 .../devicetree/bindings/power/qcom,rpmpd.yaml  |  1 +
 drivers/soc/qcom/rpmpd.c                       | 18 ++++++++++++++++++
 include/dt-bindings/power/qcom-rpmpd.h         | 10 ++++++++++
 3 files changed, 29 insertions(+)

Comments

Bjorn Andersson Dec. 6, 2022, 6:18 p.m. UTC | #1 
On Sun, 27 Nov 2022 16:52:02 +0530, Bhupesh Sharma wrote:
> Add RPM power domain support for SM4250.
> 
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: power: rpmpd: Add SM4250 support
      commit: 45ac44ed10e58cf9b510e6552317ed7d2602346f
[2/2] soc: qcom: rpmpd: Add SM4250 support
      commit: 5b617b1b10c1c6a4365d8f956032e95c53b8e388

Best regards,
Konrad Dybcio Dec. 6, 2022, 7:35 p.m. UTC | #2 
On 06/12/2022 19:18, Bjorn Andersson wrote:
> On Sun, 27 Nov 2022 16:52:02 +0530, Bhupesh Sharma wrote:
>> Add RPM power domain support for SM4250.
>>
>> Cc: Bjorn Andersson <andersson@kernel.org>
>> Cc: Rajendra Nayak <rnayak@codeaurora.org>
>> Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/2] dt-bindings: power: rpmpd: Add SM4250 support
>        commit: 45ac44ed10e58cf9b510e6552317ed7d2602346f
> [2/2] soc: qcom: rpmpd: Add SM4250 support
>        commit: 5b617b1b10c1c6a4365d8f956032e95c53b8e388
> 
> Best regards,
This may deserve a revert.. it's a 1:1 copy of 6115, which, well..
is the same SoC, lower binned. And they share a common dts.

Konrad
Bhupesh Sharma Dec. 6, 2022, 7:56 p.m. UTC | #3 
On Wed, 7 Dec 2022 at 01:05, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 06/12/2022 19:18, Bjorn Andersson wrote:
> > On Sun, 27 Nov 2022 16:52:02 +0530, Bhupesh Sharma wrote:
> >> Add RPM power domain support for SM4250.
> >>
> >> Cc: Bjorn Andersson <andersson@kernel.org>
> >> Cc: Rajendra Nayak <rnayak@codeaurora.org>
> >> Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> >>
> >> [...]
> >
> > Applied, thanks!
> >
> > [1/2] dt-bindings: power: rpmpd: Add SM4250 support
> >        commit: 45ac44ed10e58cf9b510e6552317ed7d2602346f
> > [2/2] soc: qcom: rpmpd: Add SM4250 support
> >        commit: 5b617b1b10c1c6a4365d8f956032e95c53b8e388
> >
> > Best regards,
> This may deserve a revert.. it's a 1:1 copy of 6115, which, well..
> is the same SoC, lower binned. And they share a common dts.

I agree with Konrad here. Sorry, I was waiting for official
confirmation from Qualcomm, but these are indeed similar SoCs which
should share the common dts.

Thanks,
Bhupesh