| Message ID | 20221216232606.2123341-1-echanude@redhat.com |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: enable sa8540p-ride rtc | expand |
On 17.12.2022 00:26, Eric Chanudet wrote: > pm8450a.dtsi was introduced for the descriptions of sa8540p based boards. > Rename the dtsi to make this relationship explicit. > For the descriptions of PMICs used on SA8540p based boards, I suppose? > Signed-off-by: Eric Chanudet <echanude@redhat.com> > --- The change itself looks perfectly fine though! Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} | 0 > arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} (100%) > > diff --git a/arch/arm64/boot/dts/qcom/pm8450a.dtsi b/arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi > similarity index 100% > rename from arch/arm64/boot/dts/qcom/pm8450a.dtsi > rename to arch/arm64/boot/dts/qcom/sa8540p-pmics.dtsi > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > index 6c547f1b13dc..77d499702ea8 100644 > --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > @@ -10,7 +10,7 @@ > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > > #include "sa8540p.dtsi" > -#include "pm8450a.dtsi" > +#include "sa8540p-pmics.dtsi" > > / { > model = "Qualcomm SA8540P Ride";
On Sat, Dec 17, 2022 at 03:36:58PM +0100, Konrad Dybcio wrote: > On 17.12.2022 00:26, Eric Chanudet wrote: > > pm8450a.dtsi was introduced for the descriptions of sa8540p based boards. > > Rename the dtsi to make this relationship explicit. > > > For the descriptions of PMICs used on SA8540p based boards, I suppose? Absolutely, thanks! Amended in v4: https://lore.kernel.org/linux-arm-msm/20221219191000.2570545-1-echanude@redhat.com
Enable sa8540p-ride rtc on pmic@0. sa8540p base boards share the same pmics description, currently in pm8450a.dtsi. Rename the file to make this explicit and use it in both sa8540p-ride.dts and sa8295p-adp.dts. Add the missing offset where appropriate for the alarm register bank in other qcom,pm8941-rtc description. Changes since v2: - rename pm8450a.dtsi to sa8540p-pmics.dtsi. Changes since v1: - Add "alarm" register bank offset at 0x6100 in qcom,pm8941-rtc descriptions. Eric Chanudet (4): arm64: dts: qcom: rename pm8450a dtsi to sa8540p-pmics arm64: dts: qcom: sa8450p-pmics: add rtc node arm64: dts: qcom: sa8295p-adp: use sa8540p-pmics arm64: dts: qcom: pm8941-rtc add alarm register arch/arm64/boot/dts/qcom/pm8150.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm8916.dtsi | 3 +- arch/arm64/boot/dts/qcom/pm8950.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmp8074.dtsi | 2 +- arch/arm64/boot/dts/qcom/pms405.dtsi | 2 +- arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 79 +------------------ .../qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} | 8 ++ arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +- 9 files changed, 17 insertions(+), 85 deletions(-) rename arch/arm64/boot/dts/qcom/{pm8450a.dtsi => sa8540p-pmics.dtsi} (90%)