Message ID | 20230104115348.25046-1-stephan@gerhold.net |
---|---|
Headers | show |
Series | soc: qcom: socinfo: Add a bunch of older SoCs | expand |
On Wed, 04 Jan 2023 12:53:46 +0100, Stephan Gerhold wrote: > QRD (Qualcomm Reference Design) = 0xb = 11 is used on many devices that > were originally derived from some reference design provided by Qualcomm. > > Examples of existing devices in Linux would be: > - msm8916-longcheer-l8150/l8910, msm8916-wingtech-wt88047 > - msm8953-xiaomi-daisy/tissot/vince > - msm8998-fxtec-pro1 > - sm4250-oneplus-billie2 > > Add it to qcom,ids.h so the qcom,board-id properties can be rewritten > more clearly using the macros in a future patch set, i.e. > > qcom,board-id = <QCOM_BOARD_ID(QRD, 1, 0) 0> instead of > qcom,board-id = <0x1000b 0x00> > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- > include/dt-bindings/arm/qcom,ids.h | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Sun, Jan 08, 2023 at 03:40:52PM -0600, Rob Herring wrote: > On Wed, Jan 04, 2023 at 12:53:47PM +0100, Stephan Gerhold wrote: > > Sync the SoC IDs in qcom,ids.h with relevant entries from Qualcomm's LK > > bootloader [1] that is used for almost all older Qualcomm SoCs. > > > > Several of these are already supported, e.g.: > > - MSM8960 -> APQ8060, MSM8260, ... > > - MSM8976 -> APQ8076 > > - MSM8956 -> APQ8056 > > Others are currently being worked on, e.g.: > > - MSM8909(W) -> APQ8009(W), MSM8905, MSM8209, ... > > - MSM8939 -> MSM8239, ... > > > > And even all remaining ones added are close enough to what is already > > supported so that future support is realistic (if someone steps up to > > do the work). > > > > Add all of them at once to avoid having to add them one by one in the > > future. This will also benefit other projects making use of the same > > dt-bindings, e.g. bootloaders where adding support for all these SoCs > > is a bit easier than on Linux. > > The promise was in accepting the properties upstream is we'd only be > adding these for bootloaders with dtbs that we can't otherwise update or > change. Do all of those meet this criteria? Seems unlikely. > Independent of the question about qcom,msm-id and qcom,board-id, I would like these constants for the socinfo driver (as shown in patch 4). Would you prefer that we keep a separate list in Linux? Thanks, Bjorn
On Wed, 4 Jan 2023 12:53:44 +0100, Stephan Gerhold wrote: > Sync the SoC IDs in qcom,ids.h with relevant entries from Qualcomm's LK > bootloader that is used for almost all older Qualcomm SoCs. This is > meant to reduce the effort for future SoC bring-up (to avoid having to > send a separate patch series for each new SoC) and will also benefit > other projects using the same dt-bindings, e.g. bootloaders where > adding support for all these SoCs is a bit easier than on Linux. > > [...] Applied, thanks! [1/4] soc: qcom: socinfo: Fix soc_id order commit: 017a7c11a8a29e266aa40c6d1bf2ba83f880f719 [2/4] dt-bindings: arm: qcom,ids: Add QRD board ID commit: 8b949c0e2ce59c376818bc3f80db4b94b06981b7 [3/4] dt-bindings: arm: qcom,ids: Add a bunch of older SoCs commit: 56abffc793befb19f30ec9d4bec24343529377f1 [4/4] soc: qcom: socinfo: Add a bunch of older SoCs commit: 40017cebb111eed65bddfa993df7b0636be98de8 Best regards,