From patchwork Tue Apr 4 23:56:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jessica Zhang X-Patchwork-Id: 670089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF39C761AF for ; Tue, 4 Apr 2023 23:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236655AbjDDX4y (ORCPT ); Tue, 4 Apr 2023 19:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236660AbjDDX4w (ORCPT ); Tue, 4 Apr 2023 19:56:52 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E468444A1 for ; Tue, 4 Apr 2023 16:56:50 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 334NqBBG012095; Tue, 4 Apr 2023 23:56:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : subject : date : message-id : mime-version : content-type : content-transfer-encoding : to : cc; s=qcppdkim1; bh=pCq3YbB/dFxpGpngIvPOG0gpCus7QHZ89lO9X5tJRns=; b=UHrZfpHqdGR/HAIyV1ynRo826xhiRNk64tXlzaxe6IryRtqMlaBaa5ZPNd53xUWZNFeR rJrE60JTyMs+HLxrxfTaTjIit9EWsiumHHhpBlOubQ9dP18ki4M15AX4vb9VFK7Bxpg9 9MXc4XOqvNwjxZNBBqZlEGMW9aWVYijNCMJMbXas+RXW8sBRmPTatVmUNn6CvUYKdYqG w10RJx2ggyrj9WfT4F6aoTK+dgxUyCl7hUFakM7LlS52JmZSHiDSZyslL/68+0YrLU1T VDgIpXYpILFghvpcIJBPECjrCufstsOeHrphDRbJii4V6NB2DgVdTTDgfAbpBNYaF/q4 GQ== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3prwc782a5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Apr 2023 23:56:43 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 334NugWR022569 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Apr 2023 23:56:42 GMT Received: from jesszhan-linux.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 4 Apr 2023 16:56:42 -0700 From: Jessica Zhang Subject: [PATCH v3 0/6] Introduce MSM-specific DSC helpers Date: Tue, 4 Apr 2023 16:56:12 -0700 Message-ID: <20230329-rfc-msm-dsc-helper-v3-0-6bec0d277a83@quicinc.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIABy5LGQC/4WOuw7CMBAEfyVyzaHEJgFTISFRUFKCKOLzGVsiD 2yIQFH+HScdFFDu6mb2ehbIOwpsnfTMU+eCa+oYxCxhaMv6QuB0zIynXKSCS/AGoQoV6IBg6dq SB7nKSpmTNkqnLIKqDATKlzXaEd0fv4HDbjvetZ6Me07jp3PM1oV741/TL102tj9nuwxSMIIWS 2lyqQq9uT0cuhrn2FRsFHb8v4RHicBMIOlcFIp/SoZheAP4tqBRIwEAAA== To: CC: Marijn Suijten , Konrad Dybcio , Daniel Vetter , Rob Clark , Abhinav Kumar , "Dmitry Baryshkov" , Sean Paul , , , "Jessica Zhang" X-Mailer: b4 0.13-dev-00303 X-Developer-Signature: v=1; a=ed25519-sha256; t=1680652601; l=2892; i=quic_jesszhan@quicinc.com; s=20230329; h=from:subject:message-id; bh=f6SM0J1iUdEEg5ghYwhuSxmHm0GTS2IqCKaPQcL/8Do=; b=EBSsVsnilAHqFmL4ZrhvttfAprH73KD8M6KRjzT8SfHmtRA1GzpTHTQcqWdhOxQWfYFBiK55O 6dcJyUmurKPARlTSh4B7ZsHFDQS9ZeE10JIxSBPxZof3HMzqZIjUTCB X-Developer-Key: i=quic_jesszhan@quicinc.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ONKgIkBBDYxW5g4Zx7UAbNaOkibSjLKC X-Proofpoint-ORIG-GUID: ONKgIkBBDYxW5g4Zx7UAbNaOkibSjLKC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-04_12,2023-04-04_05,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304040217 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org There are some overlap in calculations for MSM-specific DSC variables between DP and DSI. In addition, the calculations for initial_scale_value and det_thresh_flatness that are defined within the DSC 1.2 specifications, but aren't yet included in drm_dsc_helper.c. This series moves these calculations to a shared msm_dsc_helper.c file and defines drm_dsc_helper methods for initial_scale_value and det_thresh_flatness. Note: For now, the MSM specific helper methods are only called for the DSI path, but will called for DP once DSC 1.2 support for DP has been added. Depends on: "drm/i915: move DSC RC tables to drm_dsc_helper.c" [1] [1] https://patchwork.freedesktop.org/series/114472/ --- Changes in v3: - Cleaned up unused parameters - Reworded some calculations for clarity - Changed get_bytes_per_soft_slice() to a public method - Added comment documentation to MSM DSC helpers - Changed msm_dsc_get_eol_byte_num() to *_get_bytes_per_intf() - Split dsi_timing_setup() hdisplay calculation to a separate patch - Dropped 78c8b81d57d8 ("drm/display/dsc: Add flatness and initial scale value calculations") patch as it was absorbed in Dmitry's DSC series [1] - Link to v2: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v2-0-3c13ced536b2@quicinc.com Changes in v2: - Changed det_thresh_flatness to flatness_det_thresh - Moved msm_dsc_helper files to msm/ directory - Fixed type mismatch issues in MSM DSC helpers - Dropped MSM_DSC_SLICE_PER_PKT macro - Removed get_comp_ratio() helper - Style changes to improve readability - Use drm_dsc_get_bpp_int() instead of DSC_BPP macro - Picked up Fixes tags for patches 3/5 and 4/5 - Picked up Reviewed-by for patch 4/5 - Split eol_byte_num and pkt_per_line calculation into a separate patch - Moved pclk_per_line calculation into `if (dsc)` block in dsi_timing_setup() - Link to v1: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v1-0-f3e479f59b6d@quicinc.com --- Jessica Zhang (6): drm/msm: Add MSM-specific DSC helper methods drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness drm/msm/dpu: Fix slice_last_group_size calculation drm/msm/dsi: Use MSM and DRM DSC helper methods drm/msm/dsi: update hdisplay calculation for dsi_timing_setup drm/msm/dsi: Fix calculations pkt_per_line drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 9 ++-- drivers/gpu/drm/msm/dsi/dsi_host.c | 22 ++++++++-- drivers/gpu/drm/msm/msm_dsc_helper.c | 47 ++++++++++++++++++++ drivers/gpu/drm/msm/msm_dsc_helper.h | 70 ++++++++++++++++++++++++++++++ 5 files changed, 142 insertions(+), 7 deletions(-) --- base-commit: 56777fc93a145afcf71b92ba4281250f59ba6d9b change-id: 20230329-rfc-msm-dsc-helper-981a95edfbd0 Best regards,