| Message ID | 20230417145536.414490-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | arm64: qcom: fix the reboot reason handling on sa8775p | expand |
On Mon, Apr 17, 2023 at 04:55:36PM +0200, Bartosz Golaszewski wrote: > From: Parikshit Pareek <quic_ppareek@quicinc.com> > > Introduce sdam_0 node, which is to be used via nvmem for power on > reasons during reboot. Add supported PoN reaons supported via sdam_0 > node. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) Tested-by: Eric Chanudet <echanude@redhat.com> > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > index 5abdc239d3a6..3c3b6287cd27 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > @@ -88,6 +88,14 @@ trip1 { > }; > }; > }; > + > + reboot-mode { > + compatible = "nvmem-reboot-mode"; > + nvmem-cells = <&reboot_reason>; > + nvmem-cell-names = "reboot-mode"; > + mode-recovery = <0x01>; > + mode-bootloader = <0x02>; > + }; > }; > > &spmi_bus { > @@ -133,6 +141,19 @@ pmm8654au_0_gpios: gpio@8800 { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + pmm8654au_0_sdam_0: nvram@7100 { > + compatible = "qcom,spmi-sdam"; > + reg = <0x7100>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x7100 0x100>; > + > + reboot_reason: reboot-reason@48 { > + reg = <0x48 0x1>; > + bits = <1 7>; > + }; > + }; > }; > > pmm8654au_1: pmic@2 { > -- > 2.37.2 >
On Mon, 17 Apr 2023 16:55:33 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > SA8775P uses nvmem to pass the reboot reason magic value to the bootloader. > Remove the reboot modes from the PON node and introduce an SDAM node passed > to the nvmem-reboot-mode driver. While at it: convert the bindings for > nvmem-reboot-mode to YAML and enable it for arm64 in defconfig. > > [...] Applied, thanks! [1/3] arm64: dts: qcom: sa8775p: pmic: remove the PON modes commit: 40d5835998705c28b985b1325114114c6007546e [3/3] arm64: dts: qcom: sa8775p: pmic: add the sdam_0 node commit: 6c92689a0a57b40c758a12c1ca668d6a36a805a6 Best regards,
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> SA8775P uses nvmem to pass the reboot reason magic value to the bootloader. Remove the reboot modes from the PON node and introduce an SDAM node passed to the nvmem-reboot-mode driver. While at it: convert the bindings for nvmem-reboot-mode to YAML and enable it for arm64 in defconfig. v1 -> v2: - dropped the defconfig patch as it went upstream already - in patch 1: explained better why we need to drop the reboot-modes from the PON node - fixed formatting and order of properties in dt-bindings - fixed naming of nodes in device tree Bartosz Golaszewski (1): dt-bindings: power: reset: convert nvmem-reboot-mode bindings to YAML Parikshit Pareek (2): arm64: dts: qcom: sa8775p: pmic: remove the PON modes arm64: dts: qcom: sa8775p: pmic: add the sdam_0 node .../power/reset/nvmem-reboot-mode.txt | 26 ---------- .../power/reset/nvmem-reboot-mode.yaml | 52 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 23 +++++++- 3 files changed, 73 insertions(+), 28 deletions(-) delete mode 100644 Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.txt create mode 100644 Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml