mbox series

[0/2] mfd: pm8008: fix module autoloading

Message ID 20230526091646.17318-1-johan+linaro@kernel.org
Headers show
Series mfd: pm8008: fix module autoloading | expand

Message

Johan Hovold May 26, 2023, 9:16 a.m. UTC 
This series adds the missing module device table alias needed for module
autoloading to the pm8008 driver and drops a bogus i2c module alias
which has never been used.

Johan


Johan Hovold (2):
  mfd: pm8008: fix module autoloading
  mfd: pm8008: drop bogus i2c module alias

 drivers/mfd/qcom-pm8008.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio May 26, 2023, 9:22 a.m. UTC | #1 
On 26.05.2023 11:16, Johan Hovold wrote:
> Add the missing module device table alias to that the driver can be
> autoloaded when built as a module.
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Cc: stable@vger.kernel.org      # 5.14
Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
5.13 would be more fitting here?

Konrad
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  drivers/mfd/qcom-pm8008.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index 837246aab4ac..29ec3901564b 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -199,6 +199,7 @@ static const struct of_device_id pm8008_match[] = {
>  	{ .compatible = "qcom,pm8008", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, pm8008_match);
>  
>  static struct i2c_driver pm8008_mfd_driver = {
>  	.driver = {
Johan Hovold May 26, 2023, 9:25 a.m. UTC | #2 
On Fri, May 26, 2023 at 11:22:27AM +0200, Konrad Dybcio wrote:
> On 26.05.2023 11:16, Johan Hovold wrote:
> > Add the missing module device table alias to that the driver can be
> > autoloaded when built as a module.
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Cc: stable@vger.kernel.org      # 5.14

> Looks like the commit referenced in Fixes is from 5.13-rc1, perhaps
> 5.13 would be more fitting here?

No, I just double checked. This driver was not present 5.13.

Johan