mbox series

[v3,0/3] spi-geni-qcom: Add SPI device mode support for GENI based QuPv3

Message ID 20230622135955.941-1-quic_ptalari@quicinc.com
Headers show
Series spi-geni-qcom: Add SPI device mode support for GENI based QuPv3 | expand

Message

Praveen Talari June 22, 2023, 1:59 p.m. UTC
This series adds spi device mode functionality to geni based Qupv3.
The common header file contains spi slave related registers and masks.

Praveen Talari (3):
  soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
  spi: dt-bindings: qcom,spi-geni-qcom: Add SPI device mode support for
    GENI based QuPv3
  spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
---
v2 -> v3:
- Modified commit message
- Addressed comment on dt-binding
	
v1 -> v2:
- Added dt-binding change for spi slave
- Modified commit message
- Addressed review comments in driver

 .../bindings/spi/qcom,spi-geni-qcom.yaml      |  4 ++
 drivers/spi/spi-geni-qcom.c                   | 57 +++++++++++++++++--
 include/linux/soc/qcom/geni-se.h              |  9 +++
 3 files changed, 64 insertions(+), 6 deletions(-)

Comments

Krzysztof Kozlowski June 23, 2023, 8:47 a.m. UTC | #1
On 22/06/2023 15:59, Praveen Talari wrote:
> Add a property to configure QUPv3 SE as SPI Device mode.
> 
> Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
> ---
> v2 -> v3:
> - modified commit message to use device mode instead of slave mode
> ---
>  Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index 2e20ca313ec1..5c7d0293bbf7 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -66,6 +66,10 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  qcom,slv-ctrl:
> +    description: configure QUPv3 SE as Device mode

There is already property for this. Look at spi-controller.yaml. If it
is not enough, explain WHY.

Best regards,
Krzysztof