mbox series

[v4,0/3] Fixes for qcom-snps-femto-v2 PHY driver

Message ID 20230629144542.14906-1-athierry@redhat.com
Headers show
Series Fixes for qcom-snps-femto-v2 PHY driver | expand

Message

Adrien Thierry June 29, 2023, 2:45 p.m. UTC
This series contains a few fixes for the qcom-snps-femto-v2 driver, mostly
clock-related.

v3 -> v4
- remove commit that added system sleep PM ops
- add commit "phy: qcom-snps-femto-v2: keep cfg_ahb_clk enabled during
  runtime suspend"
- "phy: qcom-snps-femto-v2: properly enable ref clock"
  - dropped "HACK:" comment (Bjorn Andersson)
  - check for IS_ERR() for the optional cfg_ahb clock (Bjorn Andersson)
  - don't print an error message in case clk_bulk_prepare() fails (Bjorn
    Andersson)

v2 -> v3
- "phy: qcom-snps-femto-v2: add system sleep PM ops" - add link to
  downstream driver used as reference (Andrew Halaney)
- add commit "phy: qcom-snps-femto-v2: use
  qcom_snps_hsphy_do_suspend/resume error code" to make sure PM ops don't
  always return 0 (Andrew Halaney)

v1 -> v2
- keep cfg_ahb clock and use clk_bulk API to handle both cfg_ahb and ref
  clocks (Bjorn Andersson)
- add system sleep PM callbacks (Bjorn Andersson)
- add Link: and Fixes: tag (Andrew Halaney)

Adrien Thierry (3):
  phy: qcom-snps-femto-v2: keep cfg_ahb_clk enabled during runtime
    suspend
  phy: qcom-snps-femto-v2: properly enable ref clock
  phy: qcom-snps-femto-v2: use qcom_snps_hsphy_suspend/resume error code

 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 78 ++++++++++++-------
 1 file changed, 50 insertions(+), 28 deletions(-)

Comments

Vinod Koul July 11, 2023, 11:25 a.m. UTC | #1
On Thu, 29 Jun 2023 10:45:37 -0400, Adrien Thierry wrote:
> This series contains a few fixes for the qcom-snps-femto-v2 driver, mostly
> clock-related.
> 
> v3 -> v4
> - remove commit that added system sleep PM ops
> - add commit "phy: qcom-snps-femto-v2: keep cfg_ahb_clk enabled during
>   runtime suspend"
> - "phy: qcom-snps-femto-v2: properly enable ref clock"
>   - dropped "HACK:" comment (Bjorn Andersson)
>   - check for IS_ERR() for the optional cfg_ahb clock (Bjorn Andersson)
>   - don't print an error message in case clk_bulk_prepare() fails (Bjorn
>     Andersson)
> 
> [...]

Applied, thanks!

[1/3] phy: qcom-snps-femto-v2: keep cfg_ahb_clk enabled during runtime suspend
      commit: 825c6d29f129e3e74dc2b4a7435bc64ff34ab5f6
[2/3] phy: qcom-snps-femto-v2: properly enable ref clock
      commit: d621660a1d5bba54494367a2fa8c5bb294ad002b
[3/3] phy: qcom-snps-femto-v2: use qcom_snps_hsphy_suspend/resume error code
      commit: 0383f66b80733c90fd841836ca541ad4c1fc203f

Best regards,