mbox series

[0/7] arm64: dts: qcom: sm8450-hdk: improve thermal monitoring

Message ID 20230630061315.4027453-1-dmitry.baryshkov@linaro.org
Headers show
Series arm64: dts: qcom: sm8450-hdk: improve thermal monitoring | expand

Message

Dmitry Baryshkov June 30, 2023, 6:13 a.m. UTC 
Improve thermal monitoring on 8450-HDK board. First set of patches fix
c&p typos in PMIC include files (mea culpa). The rest of patches enable
ADC-TM usage on the SM8450 HDK.

Dmitry Baryshkov (7):
  arm64: dts: qcom: pm8350: fix thermal zone name
  arm64: dts: qcom: pm8350b: fix thermal zone name
  arm64: dts: qcom: pmr735b: fix thermal zone name
  arm64: dts: qcom: pmk8350: fix ADC-TM compatible string
  arm64: dts: qcom: sm8450-hdk: remove pmr735b PMIC inclusion
  arm64: dts: qcom: sm8450-hdk: define DIE_TEMP channels
  arm64: dts: qcom: sm8450-hdk: add ADC-TM thermal zones

 arch/arm64/boot/dts/qcom/pm8350.dtsi    |   2 +-
 arch/arm64/boot/dts/qcom/pm8350b.dtsi   |   2 +-
 arch/arm64/boot/dts/qcom/pmk8350.dtsi   |   2 +-
 arch/arm64/boot/dts/qcom/pmr735b.dtsi   |   2 +-
 arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 288 +++++++++++++++++++++++-
 5 files changed, 291 insertions(+), 5 deletions(-)

Comments

Konrad Dybcio June 30, 2023, 8:11 a.m. UTC | #1 
On 30.06.2023 08:13, Dmitry Baryshkov wrote:
> The name of the thermal zone in pm8350.dtsi (pm8350c-thermal) conflicts
> with the thermal zone in pm8350c.dtsi. Rename the thermal zone according
> to the chip name.
> 
> Fixes: 7a79b95f4288 ("arm64: dts: qcom: pm8350: add temp sensor and thermal zone config")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
DTC really needs some sus overwrite warnings!

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/pm8350.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8350.dtsi b/arch/arm64/boot/dts/qcom/pm8350.dtsi
> index 2dfeb99300d7..9ed9ba23e81e 100644
> --- a/arch/arm64/boot/dts/qcom/pm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8350.dtsi
> @@ -8,7 +8,7 @@
>  
>  / {
>  	thermal-zones {
> -		pm8350_thermal: pm8350c-thermal {
> +		pm8350_thermal: pm8350-thermal {
>  			polling-delay-passive = <100>;
>  			polling-delay = <0>;
>  			thermal-sensors = <&pm8350_temp_alarm>;
Konrad Dybcio June 30, 2023, 8:12 a.m. UTC | #2 
On 30.06.2023 08:13, Dmitry Baryshkov wrote:
> The name of the thermal zone in pmr735b.dtsi (pmr735a-thermal) conflicts
> with the thermal zone in pmr735a.dtsi. Rename the thermal zone according
> to the chip name.
> 
> Fixes: 6f3426b3dea4 ("arm64: dts: qcom: pmr735b: add temp sensor and thermal zone config")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/pmr735b.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pmr735b.dtsi b/arch/arm64/boot/dts/qcom/pmr735b.dtsi
> index ec24c4478005..f7473e247322 100644
> --- a/arch/arm64/boot/dts/qcom/pmr735b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmr735b.dtsi
> @@ -8,7 +8,7 @@
>  
>  / {
>  	thermal-zones {
> -		pmr735a_thermal: pmr735a-thermal {
> +		pmr735b_thermal: pmr735b-thermal {
>  			polling-delay-passive = <100>;
>  			polling-delay = <0>;
>  			thermal-sensors = <&pmr735b_temp_alarm>;
Konrad Dybcio June 30, 2023, 8:13 a.m. UTC | #3 
On 30.06.2023 08:13, Dmitry Baryshkov wrote:
> The 8450-HDK doesn't use PMR735B PMIC. Drop its inclusion to remove the
> warning during the HDK bootup.
> 
> Fixes: 30464456a1ea ("arm64: dts: qcom: sm8450-hdk: add pmic files")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
That's.. strange.. Did you confirm this with schematics, or even better,
socinfo?

Konrad
>  arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index bc4c125d1832..dabb7e872f38 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -14,7 +14,6 @@
>  #include "pm8450.dtsi"
>  #include "pmk8350.dtsi"
>  #include "pmr735a.dtsi"
> -#include "pmr735b.dtsi"
>  
>  / {
>  	model = "Qualcomm Technologies, Inc. SM8450 HDK";