From patchwork Tue Jul 11 12:17:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 701602 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4675C001DD for ; Tue, 11 Jul 2023 12:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231620AbjGKMSc (ORCPT ); Tue, 11 Jul 2023 08:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbjGKMSb (ORCPT ); Tue, 11 Jul 2023 08:18:31 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 968B0E5F for ; Tue, 11 Jul 2023 05:18:27 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b6fdaf6eefso87498901fa.0 for ; Tue, 11 Jul 2023 05:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689077906; x=1691669906; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=ge+hjy1ytS3fWV6a0cnAiNI+XNr+wbfujfaDkKlcW1Y=; b=lKGVu4/leGvJTRgUrgFiHw0Xqd08JRXEdUBnLtOufAfgIMn7SPWxrOrNBNKMfsnioR +MTqd/mpBGAIF8ftjonFVh6XzyRm4JZnsDpB1wdipbSk7+CIebXTmGqYjpjjZxvsRYLt yxJ0p1hbGvul44m3GWLQa1GneolSJjYOBOTfyi95zHULpH5LT0nigldAQt9JLneMbyQA eR3S8QkcpjM0lTn9PeBUtdQp4ZuvdYQ8tp3v0hWk2MwtpaukiKA+SZjb+Ejh106ZAkpk 8PNE7V3N1x0jSEGQ/GQiCPIYqOabGFccMavoeQzbhokUqH3eTEsA/bjgROlyiv6WhlHc 8crw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689077906; x=1691669906; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ge+hjy1ytS3fWV6a0cnAiNI+XNr+wbfujfaDkKlcW1Y=; b=acaBsUbLWsbcWQNK707OrMHBvfDw3buL80A5Wr733TOWcYtqX/+daq0YE9fYpEl7i4 KgteMNlqruGWj0nBu51mcIZa+dyrOXMNOVhaWItrXJXBEqqOkkZhJEWVWa7ofaYway/R LKeBGl7cWoyZjx8Ojm2fSYlFzNmAp1O0HJGaSgqr/b9BGtZCnRkyCbt7Db6uE/BSeHSB XdPI4xhl7BNxstft2XaIynzGm/y0jDa40HXO0XrtfjrfkMn+lhLikdLEVzOzs2hRWtrH ig8GOpc2ovWMdqDDVTqdfz6y2ZPwV2sof2qVVNgZDb4yZUcUZbd2u79IL1NzgAE06fCu aFFQ== X-Gm-Message-State: ABy/qLa682W7isAa0yqTWNNyqPXWhPu4J2WcOZE0JkfK+L5nA9TY3MQu +rDieo5/VnnWa0WK1lPPKpzjAcO0kbcLrK/oGm/tYw== X-Google-Smtp-Source: APBJJlEe7jF73xVl9Xnl+Gn0QpIn+S2PUKPPg/0Lj/trUSzp9bNR52JqL2cta6wvrOqHJ7cTqdyIDA== X-Received: by 2002:a2e:9216:0:b0:2b6:ec2b:659 with SMTP id k22-20020a2e9216000000b002b6ec2b0659mr12236809ljg.17.1689077905830; Tue, 11 Jul 2023 05:18:25 -0700 (PDT) Received: from [192.168.1.101] (abyl96.neoplus.adsl.tpnet.pl. [83.9.31.96]) by smtp.gmail.com with ESMTPSA id d18-20020a2e96d2000000b002b708450951sm435563ljj.88.2023.07.11.05.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 05:18:25 -0700 (PDT) From: Konrad Dybcio Subject: [PATCH 00/53] icc-rpmh multi-RSC voting groundwork Date: Tue, 11 Jul 2023 14:17:59 +0200 Message-Id: <20230708-topic-rpmh_icc_rsc-v1-0-b223bd2ac8dd@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAHhIrWQC/x2N0QrCMAxFf2Xk2UKsD5v+ishoY2oDsyuJijD27 wYfz7kc7gbGKmxwGTZQ/ojJ2hyOhwGopvbgIHdniBhPOOIUXmsXCtqfdRaiWY1Cmc6+YMkRR/A wJ+OQNTWqnrb3srjsykW+/6frbd9/lcHIh3kAAAA= To: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1689077904; l=7841; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Rei3R9n4uCU+u2iJ+J2m+Ko7NiZGPGkR7HWezlPw+hQ=; b=VpWSByJM2AvVTsGuUMxF9PX3d/YlFvF7k1f2BwyYhtmvirx+8MZ+C9lRN6l1gsja9k7POci2c LmuuJeAnqvnBq/QHVgrI4jt5neFMqEcH0znLMWQDoAhPEpr5v31Ieq3 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Many parts of Qualcomm SoCs are entirely independent of each other and can run when the other parts are off. The RPMh system architecture embraces this by giving each (loosely defined) subsystem its own connection (as in, physical wires) to the AOSS, terminated by per-subsystem RSCs (Resource State Coordinators) that barter for power, bandwidth etc. This series introduces the groundwork necessary for voting for resources through non-APPS RSCs. It should allow for lower-latency vote adjustments (e.g. for very high bandwidth / multiple displays) and could potentially allow for full APSS collapse while keeping e.g. MDSS operating (say refreshing an image from a RAM buffer). On top of that, a rather necessary and overdue cleanup is performed to stop adding more and more arguments to the insane preprocessor macros. Partially reverting (or reimplementing the revert) [1] will be necessary to coordinate the rather complex relationship between the DPU and RSC drivers. The "Point x paths to the x RSC" patches won't do anything (check the compatibility workaround qcom_icc_pre_aggregate()) until disp_rsc is properly described in the device tree, along with its BCM voter), but they prepare ground for when that happens. I was able to test sending requests through the DISP_RSC on SM8450, but I had to hack its clocks (_rscc_ in dispcc) to be always-on, as we don't have any clk handling for qcom,rpmh-rsc today. Boot-tested on SM8350 and SM8450, nothing exploded. [1] https://patchwork.kernel.org/project/dri-devel/patch/1521827074-28424-1-git-send-email-ryadav@codeaurora.org/ Dependencies: [2] https://lore.kernel.org/linux-arm-msm/113b50f8-35f6-73fc-4fc9-302262927c5e@quicinc.com/ [3] https://lore.kernel.org/linux-arm-msm/20230703-topic-8250_qup_icc-v2-0-9ba0a9460be2@linaro.org/ Signed-off-by: Konrad Dybcio --- Konrad Dybcio (53): dt-bindings: interconnect: qcom,icc: Introduce fixed BCM voter indices dt-bindings: interconnect: qcom,bcm-voter: Add qcom,bcm-voter-idx interconnect: qcom: icc-rpmh: Store direct BCM voter references interconnect: qcom: icc-rpmh: Retire dead code interconnect: qcom: icc-rpmh: Implement voting on non-APPS RSCs interconnect: qcom: sc7180: Retire DEFINE_QNODE interconnect: qcom: sdm670: Retire DEFINE_QNODE interconnect: qcom: sdm845: Retire DEFINE_QNODE interconnect: qcom: sdx55: Retire DEFINE_QNODE interconnect: qcom: sdx65: Retire DEFINE_QNODE interconnect: qcom: sm6350: Retire DEFINE_QNODE interconnect: qcom: sm8150: Retire DEFINE_QNODE interconnect: qcom: sm8250: Retire DEFINE_QNODE interconnect: qcom: sm8350: Retire DEFINE_QNODE interconnect: qcom: icc-rpmh: Retire DEFINE_QNODE interconnect: qcom: sc7180: Retire DEFINE_QBCM interconnect: qcom: sdm670: Retire DEFINE_QBCM interconnect: qcom: sdm845: Retire DEFINE_QBCM interconnect: qcom: sdx55: Retire DEFINE_QBCM interconnect: qcom: sdx65: Retire DEFINE_QBCM interconnect: qcom: sm6350: Retire DEFINE_QBCM interconnect: qcom: sm8150: Retire DEFINE_QBCM interconnect: qcom: sm8250: Retire DEFINE_QBCM interconnect: qcom: sm8350: Retire DEFINE_QBCM interconnect: qcom: icc-rpmh: Retire DEFINE_QBCM interconnect: qcom: qdu1000: Explicitly assign voter_idx interconnect: qcom: sa8775p: Explicitly assign voter_idx interconnect: qcom: sc7280: Explicitly assign voter_idx interconnect: qcom: sc8180x: Explicitly assign voter_idx interconnect: qcom: sc8280xp: Explicitly assign voter_idx interconnect: qcom: sm8450: Explicitly assign voter_idx interconnect: qcom: sm8550: Explicitly assign voter_idx arm64: dts: qcom: qdu1000: add qcom,bcm-voter-idx arm64: dts: qcom: sa8775p: add qcom,bcm-voter-idx arm64: dts: qcom: sc7180: add qcom,bcm-voter-idx arm64: dts: qcom: sc7280: add qcom,bcm-voter-idx arm64: dts: qcom: sc8180x: add qcom,bcm-voter-idx arm64: dts: qcom: sc8280xp: add qcom,bcm-voter-idx arm64: dts: qcom: sdm670: add qcom,bcm-voter-idx arm64: dts: qcom: sdm845: add qcom,bcm-voter-idx arm64: dts: qcom: sdx75: add qcom,bcm-voter-idx arm64: dts: qcom: sm6350: add qcom,bcm-voter-idx arm64: dts: qcom: sm8150: add qcom,bcm-voter-idx arm64: dts: qcom: sm8250: add qcom,bcm-voter-idx arm64: dts: qcom: sm8350: add qcom,bcm-voter-idx arm64: dts: qcom: sm8450: add qcom,bcm-voter-idx arm64: dts: qcom: sm8550: add qcom,bcm-voter-idx arm64: dts: qcom: sdx55: add qcom,bcm-voter-idx arm64: dts: qcom: sdx65: add qcom,bcm-voter-idx interconnect: qcom: sm8350: Point display paths to the display RSC interconnect: qcom: sm8450: Point display paths to the display RSC interconnect: qcom: sm8550: Point display paths to the display RSC interconnect: qcom: sm8550: Point camera paths to the camera RSC .../bindings/interconnect/qcom,bcm-voter.yaml | 10 + arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 1 + arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 1 + arch/arm64/boot/dts/qcom/qdu1000.dtsi | 2 + arch/arm64/boot/dts/qcom/sa8775p.dtsi | 1 + arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 + arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 + arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 + arch/arm64/boot/dts/qcom/sdm670.dtsi | 2 + arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 + arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 + arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 + arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 + arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 + arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 + arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 + arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 + drivers/interconnect/qcom/bcm-voter.c | 75 +- drivers/interconnect/qcom/bcm-voter.h | 9 - drivers/interconnect/qcom/icc-rpmh.c | 53 +- drivers/interconnect/qcom/icc-rpmh.h | 14 +- drivers/interconnect/qcom/qdu1000.c | 11 + drivers/interconnect/qcom/sa8775p.c | 28 + drivers/interconnect/qcom/sc7180.c | 1637 +++++++++++++++-- drivers/interconnect/qcom/sc7280.c | 27 + drivers/interconnect/qcom/sc8180x.c | 23 + drivers/interconnect/qcom/sc8280xp.c | 27 + drivers/interconnect/qcom/sdm670.c | 1410 +++++++++++++-- drivers/interconnect/qcom/sdm845.c | 1683 ++++++++++++++++-- drivers/interconnect/qcom/sdx55.c | 863 ++++++++- drivers/interconnect/qcom/sdx65.c | 850 ++++++++- drivers/interconnect/qcom/sm6350.c | 1551 +++++++++++++++-- drivers/interconnect/qcom/sm8150.c | 1714 ++++++++++++++++-- drivers/interconnect/qcom/sm8250.c | 1772 +++++++++++++++++-- drivers/interconnect/qcom/sm8350.c | 1830 ++++++++++++++++++-- drivers/interconnect/qcom/sm8450.c | 24 + drivers/interconnect/qcom/sm8550.c | 42 + include/dt-bindings/interconnect/qcom,icc.h | 8 + 39 files changed, 12320 insertions(+), 1370 deletions(-) --- base-commit: 82cee168d497ffcb79e4889fe3c7384788e89f4d change-id: 20230708-topic-rpmh_icc_rsc-f897080fb207 Best regards,