| Message ID | 20230829135818.2219438-1-quic_ipkumar@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable USB3 for IPQ5332 | expand |
On Tue, 29 Aug 2023 at 17:00, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > > Add SS UNIPHY and update controller node for USB3. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > This patch depends on the below series which adds support for USB2 in > IPQ5332 > https://lore.kernel.org/all/cover.1692699472.git.quic_varada@quicinc.com/ > > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 39 ++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index e6baf694488c..7fbe6c9f4784 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -158,6 +158,27 @@ usbphy0: phy@7b000 { > status = "disabled"; > }; > > + ssuniphy0: ssuniphy@4b0000 { > + compatible = "qcom,ipq5332-usb-ssphy"; > + reg = <0x4b0000 0x800>; > + clocks = <&gcc GCC_USB0_PIPE_CLK>, > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > + <&gcc GCC_PCIE3X1_PHY_AHB_CLK>; > + > + #clock-cells = <0>; > + clock-output-names = "usb_pcie_wrapper_pipe_clk"; > + > + clock-names = "pipe", > + "phy_cfg_ahb", > + "phy_ahb"; > + > + resets = <&gcc GCC_USB0_PHY_BCR>; > + reset-names = "por_rst"; > + #phy-cells = <0>; > + qcom,phy-mux-sel = <&tcsr 0x10540 0x1>; > + status = "disabled"; > + }; > + > qfprom: efuse@a4000 { > compatible = "qcom,ipq5332-qfprom", "qcom,qfprom"; > reg = <0x000a4000 0x721>; > @@ -313,30 +334,34 @@ usb: usb@8a00000 { > clocks = <&gcc GCC_USB0_MASTER_CLK>, > <&gcc GCC_SNOC_USB_CLK>, > <&gcc GCC_USB0_SLEEP_CLK>, > - <&gcc GCC_USB0_MOCK_UTMI_CLK>; > + <&gcc GCC_USB0_MOCK_UTMI_CLK>, > + <&gcc GCC_USB0_AUX_CLK>, > + <&gcc GCC_USB0_LFPS_CLK>; > + > clock-names = "core", > "iface", > "sleep", > - "mock_utmi"; > + "mock_utmi", > + "aux", > + "lfps"; > > resets = <&gcc GCC_USB_BCR>; > > - qcom,select-utmi-as-pipe-clk; > - > #address-cells = <1>; > #size-cells = <1>; > ranges; > > status = "disabled"; > > - usb2_0_dwc: usb@8a00000 { > + usb3_0_dwc: usb@8a00000 { At this point you have broken compilation of all ipq5332 DT files. Don't. The kernel should be bisectable. At each point, after each commit it should compile and work. > compatible = "snps,dwc3"; > reg = <0x08a00000 0xe000>; > clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; > clock-names = "ref"; > interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; > - phy-names = "usb2-phy"; > - phys = <&usbphy0>; > + phy-names = "usb2-phy", "usb3-phy"; > + phys = <&usbphy0>, <&ssuniphy0>; > + > tx-fifo-resize; > snps,is-utmi-l1-suspend; > snps,hird-threshold = /bits/ 8 <0x0>; > -- > 2.34.1 >
On 29/08/2023 15:58, Praveenkumar I wrote: > UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to > ipq4019 PHY. Hence renaming this driver to uniphy driver and can be > used for other SoC's which are having the similar UNIPHY. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > MAINTAINERS | 7 ++++--- > drivers/phy/qualcomm/Kconfig | 7 ++++--- > drivers/phy/qualcomm/Makefile | 2 +- > .../qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} | 0 > 4 files changed, 9 insertions(+), 7 deletions(-) > rename drivers/phy/qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ff1f273b4f36..7f4553c1a69a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17774,13 +17774,14 @@ F: Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml > F: drivers/mailbox/qcom-ipcc.c > F: include/dt-bindings/mailbox/qcom-ipcc.h > > -QUALCOMM IPQ4019 USB PHY DRIVER > +QUALCOMM UNIPHY DRIVER > M: Robert Marko <robert.marko@sartura.hr> > M: Luka Perkov <luka.perkov@sartura.hr> > +M: Praveenkumar I <quic_ipkumar@quicinc.com> > L: linux-arm-msm@vger.kernel.org > S: Maintained > -F: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > -F: drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c > +F: Documentation/devicetree/bindings/phy/qcom,uniphy.yaml You broke the path in your previous commit, but anyway this will go away. > +F: drivers/phy/qualcomm/phy-qcom-uniphy.c > > QUALCOMM IPQ4019 VQMMC REGULATOR DRIVER > M: Robert Marko <robert.marko@sartura.hr> > diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig > index d891058b7c39..e6981bc212b3 100644 > --- a/drivers/phy/qualcomm/Kconfig > +++ b/drivers/phy/qualcomm/Kconfig > @@ -28,12 +28,13 @@ config PHY_QCOM_EDP > Enable this driver to support the Qualcomm eDP PHY found in various > Qualcomm chipsets. > > -config PHY_QCOM_IPQ4019_USB > - tristate "Qualcomm IPQ4019 USB PHY driver" > +config PHY_QCOM_UNIPHY > + tristate "Qualcomm UNIPHY driver" > depends on OF && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > help > - Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s. > + Enable this driver to support the Qualcomm UNIPHY found in various > + Qualcomm chipsets. I don't quite get why this is renamed, either. Just because you re-use it? Re-usage is not affected with old name... Best regards, Krzysztof
On 29/08/2023 15:58, Praveenkumar I wrote: > Add SS UNIPHY and update controller node for USB3. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > This patch depends on the below series which adds support for USB2 in > IPQ5332 > https://lore.kernel.org/all/cover.1692699472.git.quic_varada@quicinc.com/ > > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 39 ++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index e6baf694488c..7fbe6c9f4784 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -158,6 +158,27 @@ usbphy0: phy@7b000 { > status = "disabled"; > }; > > + ssuniphy0: ssuniphy@4b0000 {
On 29/08/2023 15:58, Praveenkumar I wrote: > Enable UNIPHY driver for IPQ5322. This we see from the diff. You *must* say *why*, not *what*. Samsung IPQ5322 or NXP IPQ5322? Which boards need it? > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > --- > This patch depends on the below series which adds support for USB2 in > IPQ5332 > https://lore.kernel.org/all/cover.1692699472.git.quic_varada@quicinc.com/ > How does it depend? Obviously it is part of the series, but what is depending here? Best regards, Krzysztof
On 8/29/2023 10:37 PM, Krzysztof Kozlowski wrote: > On 29/08/2023 15:58, Praveenkumar I wrote: >> IPQ5332 has UNIPHY for USB and PCIe which is similar to the UNIPHY >> present in IPQ4019. Few extra settings like clock, reset delay, mux >> selection and voltage regulator are required for IPQ5332. Hence >> repurposed the IPQ4019 PHY driver for IPQ5332 UNIPHY. Few more Qualcomm >> SoCs are also having the UNIPHY which can use the same driver for both >> USB and PCIe PHY. >> >> Praveenkumar I (9): >> dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY >> phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver >> phy: qcom: uniphy: Update UNIPHY driver to be a common driver >> dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY >> dt-bindings: usb: dwc3: Update IPQ5332 compatible >> arm64: dts: qcom: ipq5332: Add USB3 related nodes >> arm64: dts: qcom: ipq5332: Enable USB SS UNIPHY > DTS does not go before drivers. DTS should be sent separately or as the > last patches. If you stuff it in the middle, means your patchset has > dependencies which it cannot have. Thus it is broken. Sorry, I ordered it wrongly. Will correct in the next patches. - Praveenkumar > > Best regards, > Krzysztof >
On 8/29/2023 10:37 PM, Krzysztof Kozlowski wrote: > On 29/08/2023 15:58, Praveenkumar I wrote: >> IPQ5332 has UNIPHY for USB and PCIe which is similar to the UNIPHY >> present in IPQ4019. Few extra settings like clock, reset delay, mux >> selection and voltage regulator are required for IPQ5332. Hence >> repurposed the IPQ4019 PHY driver for IPQ5332 UNIPHY. Few more Qualcomm >> SoCs are also having the UNIPHY which can use the same driver for both >> USB and PCIe PHY. >> >> Praveenkumar I (9): >> dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY >> phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver >> phy: qcom: uniphy: Update UNIPHY driver to be a common driver >> dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY >> dt-bindings: usb: dwc3: Update IPQ5332 compatible >> arm64: dts: qcom: ipq5332: Add USB3 related nodes >> arm64: dts: qcom: ipq5332: Enable USB SS UNIPHY > DTS does not go before drivers. DTS should be sent separately or as the > last patches. If you stuff it in the middle, means your patchset has > dependencies which it cannot have. Thus it is broken. Sorry, I ordered it wrongly. Will correct in the next patches. - Praveenkumar > > Best regards, > Krzysztof >
On Thu, 31 Aug 2023 at 14:54, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > > > On 8/29/2023 7:49 PM, Dmitry Baryshkov wrote: > > On Tue, 29 Aug 2023 at 16:59, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > >> UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to > >> ipq4019 PHY. Hence renaming this dt-binding to uniphy dt-binding and > >> can be used for other qualcomm SoCs which are having similar UNIPHY. > >> > >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > >> --- > >> .../phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} | 9 +++++++-- > >> 1 file changed, 7 insertions(+), 2 deletions(-) > >> rename Documentation/devicetree/bindings/phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} (78%) > >> > >> diff --git a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > >> similarity index 78% > >> rename from Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > >> rename to Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > >> index 09c614952fea..cbe2cc820009 100644 > >> --- a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > >> +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > >> @@ -1,13 +1,18 @@ > >> # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >> %YAML 1.2 > >> --- > >> -$id: http://devicetree.org/schemas/phy/qcom-usb-ipq4019-phy.yaml# > >> +$id: http://devicetree.org/schemas/phy/qcom,uniphy.yaml# > >> $schema: http://devicetree.org/meta-schemas/core.yaml# > >> > >> -title: Qualcom IPQ40xx Dakota HS/SS USB PHY > >> +title: Qualcomm UNIPHY > > We know that UNIPHY was a common design / IP block used for APQ8064 > > SATA and MSM8974 DSI and HDMI PHYs. Is this the same design, or was > > the name reused by the Qualcomm for some other PHYs? > > Several latest generations have USB QMP PHYs which are called 'uni-phy'. > This PHY is build on top of QCA Uniphy 22ull. A combo PHY used between > USB Gen3 / PCIe Gen3 controller. > It is different from USB QMP PHYs. So we have now three different items called Qualcomm uniphy. Could you please add some distinctive name? > > - Praveenkumar > >> maintainers: > >> - Robert Marko <robert.marko@sartura.hr> > >> + - Praveenkumar I <quic_ipkumar@quicinc.com> > >> + > >> +description: > >> + UNIPHY / COMBO PHY supports physical layer functionality for USB and PCIe on > >> + Qualcomm chipsets. > >> > >> properties: > >> compatible: > >> -- > >> 2.34.1 > >> > >
On 8/31/2023 5:47 PM, Dmitry Baryshkov wrote: > On Thu, 31 Aug 2023 at 14:54, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: >> >> On 8/29/2023 7:49 PM, Dmitry Baryshkov wrote: >>> On Tue, 29 Aug 2023 at 16:59, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: >>>> UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to >>>> ipq4019 PHY. Hence renaming this dt-binding to uniphy dt-binding and >>>> can be used for other qualcomm SoCs which are having similar UNIPHY. >>>> >>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>>> --- >>>> .../phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} | 9 +++++++-- >>>> 1 file changed, 7 insertions(+), 2 deletions(-) >>>> rename Documentation/devicetree/bindings/phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} (78%) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml >>>> similarity index 78% >>>> rename from Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml >>>> rename to Documentation/devicetree/bindings/phy/qcom,uniphy.yaml >>>> index 09c614952fea..cbe2cc820009 100644 >>>> --- a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml >>>> +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml >>>> @@ -1,13 +1,18 @@ >>>> # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> %YAML 1.2 >>>> --- >>>> -$id: http://devicetree.org/schemas/phy/qcom-usb-ipq4019-phy.yaml# >>>> +$id: http://devicetree.org/schemas/phy/qcom,uniphy.yaml# >>>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>>> >>>> -title: Qualcom IPQ40xx Dakota HS/SS USB PHY >>>> +title: Qualcomm UNIPHY >>> We know that UNIPHY was a common design / IP block used for APQ8064 >>> SATA and MSM8974 DSI and HDMI PHYs. Is this the same design, or was >>> the name reused by the Qualcomm for some other PHYs? >>> Several latest generations have USB QMP PHYs which are called 'uni-phy'. >> This PHY is build on top of QCA Uniphy 22ull. A combo PHY used between >> USB Gen3 / PCIe Gen3 controller. >> It is different from USB QMP PHYs. > So we have now three different items called Qualcomm uniphy. Could you > please add some distinctive name? There is one more target called IPQ5018 which is also having similar USB PHY built on top of Uniphy 28nm LP. That also can leverage this upcoming IPQ5332 USB PHY driver. Considering that, given a common name 'uniphy'. - Praveenkumar > >> - Praveenkumar >>>> maintainers: >>>> - Robert Marko <robert.marko@sartura.hr> >>>> + - Praveenkumar I <quic_ipkumar@quicinc.com> >>>> + >>>> +description: >>>> + UNIPHY / COMBO PHY supports physical layer functionality for USB and PCIe on >>>> + Qualcomm chipsets. >>>> >>>> properties: >>>> compatible: >>>> -- >>>> 2.34.1 >>>> > >
On Thu, 31 Aug 2023 at 15:30, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > > > On 8/31/2023 5:47 PM, Dmitry Baryshkov wrote: > > On Thu, 31 Aug 2023 at 14:54, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > >> > >> On 8/29/2023 7:49 PM, Dmitry Baryshkov wrote: > >>> On Tue, 29 Aug 2023 at 16:59, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: > >>>> UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to > >>>> ipq4019 PHY. Hence renaming this dt-binding to uniphy dt-binding and > >>>> can be used for other qualcomm SoCs which are having similar UNIPHY. > >>>> > >>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > >>>> --- > >>>> .../phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} | 9 +++++++-- > >>>> 1 file changed, 7 insertions(+), 2 deletions(-) > >>>> rename Documentation/devicetree/bindings/phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} (78%) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > >>>> similarity index 78% > >>>> rename from Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > >>>> rename to Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > >>>> index 09c614952fea..cbe2cc820009 100644 > >>>> --- a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > >>>> +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > >>>> @@ -1,13 +1,18 @@ > >>>> # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >>>> %YAML 1.2 > >>>> --- > >>>> -$id: http://devicetree.org/schemas/phy/qcom-usb-ipq4019-phy.yaml# > >>>> +$id: http://devicetree.org/schemas/phy/qcom,uniphy.yaml# > >>>> $schema: http://devicetree.org/meta-schemas/core.yaml# > >>>> > >>>> -title: Qualcom IPQ40xx Dakota HS/SS USB PHY > >>>> +title: Qualcomm UNIPHY > >>> We know that UNIPHY was a common design / IP block used for APQ8064 > >>> SATA and MSM8974 DSI and HDMI PHYs. Is this the same design, or was > >>> the name reused by the Qualcomm for some other PHYs? > >>> Several latest generations have USB QMP PHYs which are called 'uni-phy'. > >> This PHY is build on top of QCA Uniphy 22ull. A combo PHY used between > >> USB Gen3 / PCIe Gen3 controller. > >> It is different from USB QMP PHYs. > > So we have now three different items called Qualcomm uniphy. Could you > > please add some distinctive name? > There is one more target called IPQ5018 which is also having similar USB > PHY built on top of > Uniphy 28nm LP. That also can leverage this upcoming IPQ5332 USB PHY > driver. Considering that, > given a common name 'uniphy'. Just to verify, do we mean the same thing, when speaking about the 28nm LP UNIPHY? I was referencing the apq8064 SATA and msm8974 HDMI / DSI PHYs. See [1] and [2]. [1] https://patchwork.freedesktop.org/patch/544131/?series=118210&rev=2 [2] https://patchwork.freedesktop.org/patch/544125/?series=118210&rev=2 > > - Praveenkumar > > > >> - Praveenkumar > >>>> maintainers: > >>>> - Robert Marko <robert.marko@sartura.hr> > >>>> + - Praveenkumar I <quic_ipkumar@quicinc.com> > >>>> + > >>>> +description: > >>>> + UNIPHY / COMBO PHY supports physical layer functionality for USB and PCIe on > >>>> + Qualcomm chipsets. > >>>> > >>>> properties: > >>>> compatible: > >>>> -- > >>>> 2.34.1 > >>>> > > > >
On 8/31/2023 6:04 PM, Dmitry Baryshkov wrote: > On Thu, 31 Aug 2023 at 15:30, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: >> >> On 8/31/2023 5:47 PM, Dmitry Baryshkov wrote: >>> On Thu, 31 Aug 2023 at 14:54, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: >>>> On 8/29/2023 7:49 PM, Dmitry Baryshkov wrote: >>>>> On Tue, 29 Aug 2023 at 16:59, Praveenkumar I <quic_ipkumar@quicinc.com> wrote: >>>>>> UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to >>>>>> ipq4019 PHY. Hence renaming this dt-binding to uniphy dt-binding and >>>>>> can be used for other qualcomm SoCs which are having similar UNIPHY. >>>>>> >>>>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>>>>> --- >>>>>> .../phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} | 9 +++++++-- >>>>>> 1 file changed, 7 insertions(+), 2 deletions(-) >>>>>> rename Documentation/devicetree/bindings/phy/{qcom-usb-ipq4019-phy.yaml => qcom,uniphy.yaml} (78%) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml >>>>>> similarity index 78% >>>>>> rename from Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml >>>>>> rename to Documentation/devicetree/bindings/phy/qcom,uniphy.yaml >>>>>> index 09c614952fea..cbe2cc820009 100644 >>>>>> --- a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml >>>>>> +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml >>>>>> @@ -1,13 +1,18 @@ >>>>>> # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>>> %YAML 1.2 >>>>>> --- >>>>>> -$id: http://devicetree.org/schemas/phy/qcom-usb-ipq4019-phy.yaml# >>>>>> +$id: http://devicetree.org/schemas/phy/qcom,uniphy.yaml# >>>>>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>>>>> >>>>>> -title: Qualcom IPQ40xx Dakota HS/SS USB PHY >>>>>> +title: Qualcomm UNIPHY >>>>> We know that UNIPHY was a common design / IP block used for APQ8064 >>>>> SATA and MSM8974 DSI and HDMI PHYs. Is this the same design, or was >>>>> the name reused by the Qualcomm for some other PHYs? >>>>> Several latest generations have USB QMP PHYs which are called 'uni-phy'. >>>> This PHY is build on top of QCA Uniphy 22ull. A combo PHY used between >>>> USB Gen3 / PCIe Gen3 controller. >>>> It is different from USB QMP PHYs. >>> So we have now three different items called Qualcomm uniphy. Could you >>> please add some distinctive name? >> There is one more target called IPQ5018 which is also having similar USB >> PHY built on top of >> Uniphy 28nm LP. That also can leverage this upcoming IPQ5332 USB PHY >> driver. Considering that, >> given a common name 'uniphy'. > Just to verify, do we mean the same thing, when speaking about the > 28nm LP UNIPHY? > I was referencing the apq8064 SATA and msm8974 HDMI / DSI PHYs. See [1] and [2]. > > [1] https://patchwork.freedesktop.org/patch/544131/?series=118210&rev=2 > [2] https://patchwork.freedesktop.org/patch/544125/?series=118210&rev=2 No, this seems different from the PHY used on IPQ5018 / IPQ5332. PHY in QualcommIPQ targets requires minimal SW configuration for the bring up. >> - Praveenkumar >>>> - Praveenkumar >>>>>> maintainers: >>>>>> - Robert Marko <robert.marko@sartura.hr> >>>>>> + - Praveenkumar I <quic_ipkumar@quicinc.com> >>>>>> + >>>>>> +description: >>>>>> + UNIPHY / COMBO PHY supports physical layer functionality for USB and PCIe on >>>>>> + Qualcomm chipsets. >>>>>> >>>>>> properties: >>>>>> compatible: >>>>>> -- >>>>>> 2.34.1 >>>>>> >>> > >
On 8/29/2023 10:25 PM, Krzysztof Kozlowski wrote: > On 29/08/2023 15:58, Praveenkumar I wrote: >> UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to >> ipq4019 PHY. Hence renaming this driver to uniphy driver and can be >> used for other SoC's which are having the similar UNIPHY. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> --- >> MAINTAINERS | 7 ++++--- >> drivers/phy/qualcomm/Kconfig | 7 ++++--- >> drivers/phy/qualcomm/Makefile | 2 +- >> .../qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} | 0 >> 4 files changed, 9 insertions(+), 7 deletions(-) >> rename drivers/phy/qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index ff1f273b4f36..7f4553c1a69a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -17774,13 +17774,14 @@ F: Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml >> F: drivers/mailbox/qcom-ipcc.c >> F: include/dt-bindings/mailbox/qcom-ipcc.h >> >> -QUALCOMM IPQ4019 USB PHY DRIVER >> +QUALCOMM UNIPHY DRIVER >> M: Robert Marko <robert.marko@sartura.hr> >> M: Luka Perkov <luka.perkov@sartura.hr> >> +M: Praveenkumar I <quic_ipkumar@quicinc.com> >> L: linux-arm-msm@vger.kernel.org >> S: Maintained >> -F: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml >> -F: drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c >> +F: Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > You broke the path in your previous commit, but anyway this will go away. > >> +F: drivers/phy/qualcomm/phy-qcom-uniphy.c >> >> QUALCOMM IPQ4019 VQMMC REGULATOR DRIVER >> M: Robert Marko <robert.marko@sartura.hr> >> diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig >> index d891058b7c39..e6981bc212b3 100644 >> --- a/drivers/phy/qualcomm/Kconfig >> +++ b/drivers/phy/qualcomm/Kconfig >> @@ -28,12 +28,13 @@ config PHY_QCOM_EDP >> Enable this driver to support the Qualcomm eDP PHY found in various >> Qualcomm chipsets. >> >> -config PHY_QCOM_IPQ4019_USB >> - tristate "Qualcomm IPQ4019 USB PHY driver" >> +config PHY_QCOM_UNIPHY >> + tristate "Qualcomm UNIPHY driver" >> depends on OF && (ARCH_QCOM || COMPILE_TEST) >> select GENERIC_PHY >> help >> - Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s. >> + Enable this driver to support the Qualcomm UNIPHY found in various >> + Qualcomm chipsets. > I don't quite get why this is renamed, either. Just because you re-use > it? Re-usage is not affected with old name... Understood. As suggested by Dmitry Baryshkov, will add new driver for Qualcomm IPQ5332 USB Gen3 PHY driver. - Praveenkumar > > Best regards, > Krzysztof >