mbox series

[V3,0/4] Enable IPQ5018 USB2 support

Message ID 20230901092645.20522-1-quic_nsekar@quicinc.com
Headers show
Series Enable IPQ5018 USB2 support | expand

Message

Nitheesh Sekar Sept. 1, 2023, 9:26 a.m. UTC 
This patch series adds the relevant phy and controller
DT configurations for enabling USB2 host mode support
on IPQ5018.

Tested with a USB Mass storage device.

Depends on:
Link: https://lore.kernel.org/linux-arm-msm/20230831030503.17100-1-quic_nsekar@quicinc.com/

[V3]:
	Incorporated review comments with respect to
	naming USB related device tree nodes,
	dropped the 0 dealy inits and added the static const
	type for m31_ipq5018_regs.
	Sorted nodes in	board specific device tree file.

[V2]:
	Incorporated review comments regarding splitting the
	series as per subsytem, device tree naming conventions
	and ordereing of the nodes.

Nitheesh Sekar (4):
  dt-bindings: phy: qcom,m31: Add IPQ5018 compatible
  phy: qcom-m31: Add compatible, phy init sequence for IPQ5018
  arm64: dts: qcom: ipq5018: Add USB related nodes
  arm64: dts: qcom: ipq5018: Enable USB

 .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml  |  4 +-
 .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 12 +++++
 arch/arm64/boot/dts/qcom/ipq5018.dtsi         | 54 +++++++++++++++++++
 drivers/phy/qualcomm/phy-qcom-m31.c           | 49 +++++++++++++++++
 4 files changed, 118 insertions(+), 1 deletion(-)

Comments

Nitheesh Sekar Sept. 4, 2023, 5:12 a.m. UTC | #1 
On 9/2/2023 3:20 AM, Dmitry Baryshkov wrote:
> On Fri, 1 Sept 2023 at 12:27, Nitheesh Sekar <quic_nsekar@quicinc.com> wrote:
>> Add phy init sequence and compatible string for IPQ5018
>> chipset.
>>
>> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>
>> ---
>> V3:
>>          Dropped 0 delay inits.
>>          Added static const type for m31_ipq5018_regs.
>> V2:
>>          Updated the commit message.
>> ---
>>   drivers/phy/qualcomm/phy-qcom-m31.c | 49 +++++++++++++++++++++++++++++
>>   1 file changed, 49 insertions(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
>> index ed08072ca032..ceee38695d7d 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
>> @@ -82,6 +82,48 @@ struct m31_priv_data {
>>          unsigned int                    nregs;
>>   };
>>
>> +static const struct m31_phy_regs m31_ipq5018_regs[] = {
>> +       {
> C99 initializers, please?
Sorry. Missed it. Will update and post a new patchset.
>
>> +               USB_PHY_CFG0,
>> +               UTMI_PHY_OVERRIDE_EN
>> +       },
>> +       {
>> +               USB_PHY_UTMI_CTRL5,
>> +               POR_EN,
>> +               15
>> +       },
>> +       {
>> +               USB_PHY_FSEL_SEL,
>> +               FREQ_SEL
>> +       },
>> +       {
>> +               USB_PHY_HS_PHY_CTRL_COMMON0,
>> +               COMMONONN | FSEL | RETENABLEN
>> +       },
>> +       {
>> +               USB_PHY_REFCLK_CTRL,
>> +               CLKCORE
>> +       },
>> +       {
>> +               USB_PHY_UTMI_CTRL5,
>> +               POR_EN
>> +       },
>> +       {
>> +               USB_PHY_HS_PHY_CTRL2,
>> +               USB2_SUSPEND_N_SEL | USB2_SUSPEND_N | USB2_UTMI_CLK_EN
>> +       },
>> +       {
>> +               USB_PHY_UTMI_CTRL5
>> +       },
>> +       {
>> +               USB_PHY_HS_PHY_CTRL2,
>> +               USB2_SUSPEND_N | USB2_UTMI_CLK_EN
>> +       },
>> +       {
>> +               USB_PHY_CFG0
> What is the value written? While it didn't make sense to write 0
> delays, it is sensible to write 0 register values here.
Value to be written is 0. I will update this.
>
>> +       },
>> +};
>> +
>>   struct m31_phy_regs m31_ipq5332_regs[] = {
>>          {
>>                  USB_PHY_CFG0,
>> @@ -268,6 +310,12 @@ static int m31usb_phy_probe(struct platform_device *pdev)
>>          return PTR_ERR_OR_ZERO(phy_provider);
>>   }
>>
>> +static const struct m31_priv_data m31_ipq5018_data = {
>> +       .ulpi_mode = false,
>> +       .regs = m31_ipq5018_regs,
>> +       .nregs = ARRAY_SIZE(m31_ipq5018_regs),
>> +};
>> +
>>   static const struct m31_priv_data m31_ipq5332_data = {
>>          .ulpi_mode = false,
>>          .regs = m31_ipq5332_regs,
>> @@ -275,6 +323,7 @@ static const struct m31_priv_data m31_ipq5332_data = {
>>   };
>>
>>   static const struct of_device_id m31usb_phy_id_table[] = {
>> +       { .compatible = "qcom,ipq5018-usb-hsphy", .data = &m31_ipq5018_data },
>>          { .compatible = "qcom,ipq5332-usb-hsphy", .data = &m31_ipq5332_data },
>>          { },
>>   };
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>