| Message ID | 20231011-msm8226-msm8974-watchdog-v1-0-2c472818fbce@z3ntu.xyz |
|---|---|
| Headers | show |
| Series | Add watchdog nodes to msm8226 & msm8974 | expand |
On Wed, 11 Oct 2023 18:33:12 +0200, Luca Weiss wrote: > Document the compatible for the watchdog found on both SoCs, and add > them to the SoC dtsi file. And especially for the case where the > bootloader has already enabled the watchdog we need to start petting it > on time, otherwise the system gets rebooted. > > It's worth noting that the watchdog behaves a bit unexpectedly. > It appears the watchdog counts down significantly slower when there's no > load on the system and can last far longer than 30 seconds until they > bark. Only when putting load on the system, e.g. with stress-ng does the > watchdog interrupt fire and kill the system within an expected amount of > time. > > [...] Applied, thanks! [3/3] ARM: dts: qcom: msm8974: Add watchdog node commit: 95053f6bc8ffca438a261400d7c06bd74e3f106e Best regards,
On Sonntag, 3. Dezember 2023 05:54:39 CET Bjorn Andersson wrote: > On Wed, 11 Oct 2023 18:33:12 +0200, Luca Weiss wrote: > > Document the compatible for the watchdog found on both SoCs, and add > > them to the SoC dtsi file. And especially for the case where the > > bootloader has already enabled the watchdog we need to start petting it > > on time, otherwise the system gets rebooted. > > > > It's worth noting that the watchdog behaves a bit unexpectedly. > > It appears the watchdog counts down significantly slower when there's no > > load on the system and can last far longer than 30 seconds until they > > bark. Only when putting load on the system, e.g. with stress-ng does the > > watchdog interrupt fire and kill the system within an expected amount of > > time. > > > > [...] > > Applied, thanks! > > [3/3] ARM: dts: qcom: msm8974: Add watchdog node > commit: 95053f6bc8ffca438a261400d7c06bd74e3f106e Hi Bjorn, Any reason you didn't pick up the msm8226 patch? Doesn't seem to be just your ty email, I only see the msm8974 patch in https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/log/?h=arm32-for-6.8 Regards Luca > > Best regards,
Document the compatible for the watchdog found on both SoCs, and add them to the SoC dtsi file. And especially for the case where the bootloader has already enabled the watchdog we need to start petting it on time, otherwise the system gets rebooted. It's worth noting that the watchdog behaves a bit unexpectedly. It appears the watchdog counts down significantly slower when there's no load on the system and can last far longer than 30 seconds until they bark. Only when putting load on the system, e.g. with stress-ng does the watchdog interrupt fire and kill the system within an expected amount of time. This behavior has been observed on both msm8974 and msm8226 smartphones. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Matti Lehtimäki (3): dt-bindings: watchdog: qcom-wdt: Add MSM8226 and MSM8974 compatibles ARM: dts: qcom: msm8226: Add watchdog node ARM: dts: qcom: msm8974: Add watchdog node Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 ++ arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 8 ++++++++ arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 8 ++++++++ 3 files changed, 18 insertions(+) --- base-commit: 2933a1156742d8c47550493a77af8e2d81cf3c84 change-id: 20231011-msm8226-msm8974-watchdog-a88e45f4e2a4 Best regards,