| Message ID | 20231111204916.35835-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | mailbox/arm64: qcom: rework compatibles for fallback (continued) | expand |
On Sat, Nov 11, 2023 at 09:49:14PM +0100, Krzysztof Kozlowski wrote: > qcom,ipq8074-apcs-apps-global compatible is listed in two places: with > and without fallback. Drop the second case to match DTS. > > Fixes: 34d8775a0edc ("dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks for few variants") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index a38413f8d132..a22c8640dc0e 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -41,7 +41,6 @@ properties: > - const: syscon > - enum: > - qcom,ipq6018-apcs-apps-global > - - qcom,ipq8074-apcs-apps-global > - qcom,msm8996-apcs-hmss-global > - qcom,msm8998-apcs-hmss-global > - qcom,qcm2290-apcs-hmss-global > -- > 2.34.1 >
On 11/11/2023 21:49, Krzysztof Kozlowski wrote: > Hi, > > Changes since v4 > ================ > v3: https://lore.kernel.org/linux-devicetree/20230322174148.810938-1-krzysztof.kozlowski@linaro.org/ > v4: https://lore.kernel.org/linux-devicetree/20230327140752.163009-1-krzysztof.kozlowski@linaro.org/ > > Important: v3 and v4 are quite different. Jassi, Any comments from your side? Can you pick this patchset? Best regards, Krzysztof
On Fri, Dec 8, 2023 at 3:52 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 11/11/2023 21:49, Krzysztof Kozlowski wrote: > > Hi, > > > > Changes since v4 > > ================ > > v3: https://lore.kernel.org/linux-devicetree/20230322174148.810938-1-krzysztof.kozlowski@linaro.org/ > > v4: https://lore.kernel.org/linux-devicetree/20230327140752.163009-1-krzysztof.kozlowski@linaro.org/ > > > > Important: v3 and v4 are quite different. > > Jassi, > > Any comments from your side? Can you pick this patchset? > Thanks for the ping, though I hadn't overlooked. I want to wait enough for platform owners to ack or comment. Picked now. Cheers.
Hi, Changes since v4 ================ v3: https://lore.kernel.org/linux-devicetree/20230322174148.810938-1-krzysztof.kozlowski@linaro.org/ v4: https://lore.kernel.org/linux-devicetree/20230327140752.163009-1-krzysztof.kozlowski@linaro.org/ Important: v3 and v4 are quite different. v3 did not reach full consensus, so I prepared v4 doing a subset of the original change. Then DTS pieces from the v3 were applied, without bindings and driver. OTOH, bindings and driver were applied from v4. So we have DTS from v3 and driver+bindings from v4. This leaves us in inconsistent state and several warnings: ['qcom,msm8976-apcs-kpss-global', 'qcom,msm8994-apcs-kpss-global', 'syscon'] is too long ['qcom,msm8998-apcs-hmss-global', 'qcom,msm8994-apcs-kpss-global'] is too long ['qcom,sm6115-apcs-hmss-global', 'qcom,msm8994-apcs-kpss-global'] is too long ['qcom,sdm660-apcs-hmss-global', 'qcom,msm8994-apcs-kpss-global'] is too long ['qcom,sm6125-apcs-hmss-global', 'qcom,msm8994-apcs-kpss-global'] is too long Bring back changes from v3, to align bindings and driver with DTS. Changes since v3 ================ 1. Narrow the scope of the patches after feedback from Dmitry - only few variants are made compatible. Changes since v2 ================ 1. Split fixes to separate patchset which is now dependency: https://lore.kernel.org/linux-arm-msm/20230322173559.809805-1-krzysztof.kozlowski@linaro.org/T/#t 2. Add Ack 3. No other changes, as discussion with Dmitry did not reach conclusion on incompatibility. Changes since v1 ================ 1. Rebase 2. Make msm8994 fallback for several variants, not msm8953, because the latter actually might take some clocks. 3. Two new patches for SDX55. 4. Minor corrections in bindings style. v1: https://lore.kernel.org/all/20230202161856.385825-1-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof Krzysztof Kozlowski (3): dt-bindings: mailbox: qcom,apcs-kpss-global: drop duplicated qcom,ipq8074-apcs-apps-global dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks mailbox: qcom-apcs-ipc: re-organize compatibles with fallbacks .../mailbox/qcom,apcs-kpss-global.yaml | 62 +++++++++++++------ drivers/mailbox/qcom-apcs-ipc-mailbox.c | 10 +-- 2 files changed, 48 insertions(+), 24 deletions(-)