mbox series

[RFC,v2,0/5] soc: qcom: add in-kernel pd-mapper implementation

Message ID 20240301-qcom-pd-mapper-v2-0-5d12a081d9d1@linaro.org
Headers show
Series soc: qcom: add in-kernel pd-mapper implementation | expand

Message

Dmitry Baryshkov Feb. 29, 2024, 11 p.m. UTC
Protection domain mapper is a QMI service providing mapping between
'protection domains' and services supported / allowed in these domains.
For example such mapping is required for loading of the WiFi firmware or
for properly starting up the UCSI / altmode / battery manager support.

The existing userspace implementation has several issue. It doesn't play
well with CONFIG_EXTRA_FIRMWARE, it doesn't reread the JSON files if the
firmware location is changed (or if the firmware was not available at
the time pd-mapper was started but the corresponding directory is
mounted later), etc.

However this configuration is largely static and common between
different platforms. Provide in-kernel service implementing static
per-platform data.

NOTE: this is an RFC / RFC, the domain mapping data might be inaccurate
(especially for SM6xxx and SC7xxx platforms), which is reflected by
several TODO and FIXME comments in the code.

Changes since RFC v1:
- Swapped num_domains / domains (Konrad)
- Fixed an issue with battery not working on sc8280xp
- Added missing configuration for QCS404

Dmitry Baryshkov (5):
  soc: qcom: add pd-mapper implementation
  remoteproc: qcom: pas: correct data indentation
  remoteproc: qcom: adsp: add configuration for in-kernel pdm
  remoteproc: qcom: mss: add configuration for in-kernel pdm
  remoteproc: qcom: pas: add configuration for in-kernel pdm

 drivers/remoteproc/Kconfig          |   3 +
 drivers/remoteproc/qcom_q6v5_adsp.c |  67 +++++
 drivers/remoteproc/qcom_q6v5_mss.c  |  84 ++++++
 drivers/remoteproc/qcom_q6v5_pas.c  | 418 +++++++++++++++++++++++-----
 drivers/soc/qcom/Kconfig            |  10 +
 drivers/soc/qcom/Makefile           |   2 +
 drivers/soc/qcom/qcom_pdm.c         | 302 ++++++++++++++++++++
 drivers/soc/qcom/qcom_pdm_msg.c     | 189 +++++++++++++
 drivers/soc/qcom/qcom_pdm_msg.h     |  66 +++++
 include/linux/soc/qcom/pd_mapper.h  |  35 +++
 10 files changed, 1108 insertions(+), 68 deletions(-)
 create mode 100644 drivers/soc/qcom/qcom_pdm.c
 create mode 100644 drivers/soc/qcom/qcom_pdm_msg.c
 create mode 100644 drivers/soc/qcom/qcom_pdm_msg.h
 create mode 100644 include/linux/soc/qcom/pd_mapper.h

--
2.39.2

---
Dmitry Baryshkov (5):
      soc: qcom: add pd-mapper implementation
      remoteproc: qcom: pas: correct data indentation
      remoteproc: qcom: adsp: add configuration for in-kernel pdm
      remoteproc: qcom: mss: add configuration for in-kernel pdm
      remoteproc: qcom: pas: add configuration for in-kernel pdm

 drivers/remoteproc/Kconfig          |   3 +
 drivers/remoteproc/qcom_q6v5_adsp.c |  87 ++++++-
 drivers/remoteproc/qcom_q6v5_mss.c  |  84 +++++++
 drivers/remoteproc/qcom_q6v5_pas.c  | 483 ++++++++++++++++++++++++++++++------
 drivers/soc/qcom/Kconfig            |  10 +
 drivers/soc/qcom/Makefile           |   2 +
 drivers/soc/qcom/qcom_pdm.c         | 300 ++++++++++++++++++++++
 drivers/soc/qcom/qcom_pdm_msg.c     | 188 ++++++++++++++
 drivers/soc/qcom/qcom_pdm_msg.h     |  66 +++++
 include/linux/soc/qcom/pd_mapper.h  |  35 +++
 10 files changed, 1176 insertions(+), 82 deletions(-)
---
base-commit: 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e
change-id: 20240301-qcom-pd-mapper-e12d622d4ad0

Best regards,

Comments

Dmitry Baryshkov March 1, 2024, 12:50 a.m. UTC | #1
On Fri, 1 Mar 2024 at 01:00, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Protection domain mapper is a QMI service providing mapping between
> 'protection domains' and services supported / allowed in these domains.
> For example such mapping is required for loading of the WiFi firmware or
> for properly starting up the UCSI / altmode / battery manager support.
>
> The existing userspace implementation has several issue. It doesn't play
> well with CONFIG_EXTRA_FIRMWARE, it doesn't reread the JSON files if the
> firmware location is changed (or if the firmware was not available at
> the time pd-mapper was started but the corresponding directory is
> mounted later), etc.
>
> However this configuration is largely static and common between
> different platforms. Provide in-kernel service implementing static
> per-platform data.
>
> NOTE: this is an RFC / RFC, the domain mapping data might be inaccurate
> (especially for SM6xxx and SC7xxx platforms), which is reflected by
> several TODO and FIXME comments in the code.
>
> Changes since RFC v1:
> - Swapped num_domains / domains (Konrad)
> - Fixed an issue with battery not working on sc8280xp

After sending this RFC I have stumbled upon another issue on sc8280xp
/ X13s. I'll send v3 after finding a way to fix it.

> - Added missing configuration for QCS404
>> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>