| Message ID | 20240619-icc_bw_voting_from_ethqos-v1-0-6112948b825e@quicinc.com |
|---|---|
| Headers | show |
| Series | Add interconnect support for qcom_ethqos driver. | expand |
On 6/19/2024 4:13 PM, Andrew Lunn wrote: > On Wed, Jun 19, 2024 at 03:41:29PM -0700, Sagar Cheluvegowda wrote: >> Add interconnect support in qcom-ethqos driver to vote for bus >> bandwidth based on the current speed of the driver. >> This change adds support for two different paths - one from ethernet >> to DDR and the other from Apps to ethernet. > > What do you mean by Apps? > Apps means application processor. >> Vote from each interconnect client is aggregated and the on-chip >> interconnect hardware is configured to the most appropriate >> bandwidth profile. >> >> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> >> --- >> .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> index e254b21fdb59..682e68f37dbd 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c >> @@ -7,6 +7,7 @@ >> #include <linux/platform_device.h> >> #include <linux/phy.h> >> #include <linux/phy/phy.h> >> +#include <linux/interconnect.h> > > If you look at these includes, you should notice they are > alphabetical. > Agreed, let me update it in v2 of this series. >> +static void ethqos_set_icc_bw(struct qcom_ethqos *ethqos, unsigned int speed) >> +{ >> + icc_set_bw(ethqos->axi_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); >> + icc_set_bw(ethqos->ahb_icc_path, Mbps_to_icc(speed), Mbps_to_icc(speed)); >> +} >> + >> static void ethqos_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) >> { >> struct qcom_ethqos *ethqos = priv; >> >> ethqos->speed = speed; >> ethqos_update_link_clk(ethqos, speed); >> + ethqos_set_icc_bw(ethqos, speed); >> ethqos_configure(ethqos); >> } >> >> @@ -813,6 +824,14 @@ static int qcom_ethqos_probe(struct platform_device *pdev) >> return dev_err_probe(dev, PTR_ERR(ethqos->link_clk), >> "Failed to get link_clk\n"); >> >> + ethqos->axi_icc_path = devm_of_icc_get(dev, "axi_icc_path"); >> + if (IS_ERR(ethqos->axi_icc_path)) >> + return PTR_ERR(ethqos->axi_icc_path); >> + >> + ethqos->ahb_icc_path = devm_of_icc_get(dev, "ahb_icc_path"); >> + if (IS_ERR(ethqos->axi_icc_path)) >> + return PTR_ERR(ethqos->axi_icc_path); >> + > > This all looks pretty generic. Any reason why this is just in the > Qualcomm device, and not at a higher level so it could be used for all > stmmac devices if the needed properties are found in DT? > > Andrew ICC is a software framework to access the NOC bus topology of the system, all though "axi" and "ahb" buses seem generic but the topologies of these NOC's are specific to the vendors of synopsys chipset hence this framework might not be applicable to all the vendors of stmmac driver. Sagar
> > This all looks pretty generic. Any reason why this is just in the > > Qualcomm device, and not at a higher level so it could be used for all > > stmmac devices if the needed properties are found in DT? > > > > Andrew > ICC is a software framework to access the NOC bus topology of the > system, all though "axi" and "ahb" buses seem generic but the > topologies of these NOC's are specific to the vendors of synopsys chipset hence > this framework might not be applicable to all the vendors of stmmac driver. There are however a number of SoCs using synopsys IP. Am i right in says they could all make use of this? Do we really want them to one by one copy/paste what you have here to other vendor specific parts of stmmac? This code looks in DT. If there are no properties in DT, it does nothing. So in general it should be safe, right? Andrew
Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> --- Sagar Cheluvegowda (3): net: stmmac: Add interconnect support in qcom-ethqos driver net: stmmac: Bring down the clocks to lower frequencies when mac link goes down dt-bindings: net: qcom: ethernet: Add interconnect properties .../devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++++++ .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 19 +++++++++++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++ 3 files changed, 30 insertions(+) --- base-commit: 8a92980606e3585d72d510a03b59906e96755b8a change-id: 20240610-icc_bw_voting_from_ethqos-12f5c6ed46c2 Best regards,