| Message ID | 20241015081603.30643-1-quic_qqzhou@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for APPS SMMU on QCS615 | expand |
On 15/10/2024 10:15, Qingqing Zhou wrote: > Enable APPS SMMU function on QCS615 platform. APPS SMMU is required > for address translation in devices including Ethernet/UFS/USB and > so on. > > Add the SCM node for SMMU probing normally. SMMU driver probe will > check qcom_scm ready or not, without SCM node, SMMU driver probe will > defer. > The dmesg log without SCM node: > platform 15000000.iommu: deferred probe pending: arm-smmu: qcom_scm not ready > > With the SCM node, SMMU can probe normally, but SCM driver still fails > to probe because of one SCM bug: > qcom_scm firmware:scm: error (____ptrval____): Failed to enable the TrustZone memory allocator > qcom_scm firmware:scm: probe with driver qcom_scm failed with error 4 > The above SCM bug is fixed by: > https://lore.kernel.org/all/20241005140150.4109700-2-quic_kuldsing@quicinc.com/ > But above patch doesn't impact building of current patch series, this patch > series can build successfully without above patch. > > Dependency: > https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/ > > Changes in v2: > - Address the comments on bindings from Krzysztof. Which comments? Be specific what changed. Best regards, Krzysztof
在 10/15/2024 4:21 PM, Krzysztof Kozlowski 写道: > On 15/10/2024 10:16, Qingqing Zhou wrote: >> Add the compatible for Qualcomm QCS615 SCM. >> >> Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com> > > I give up on this. > > Please reach internally to get proper guidance how to send patches and > what to do with tags. Oh, sorry for missing your ack tag, will add in next version. And thanks for your review. > > I am not going to do the work twice. > > Best regards, > Krzysztof >
在 10/15/2024 4:20 PM, Krzysztof Kozlowski 写道: > On 15/10/2024 10:15, Qingqing Zhou wrote: >> Enable APPS SMMU function on QCS615 platform. APPS SMMU is required >> for address translation in devices including Ethernet/UFS/USB and >> so on. >> >> Add the SCM node for SMMU probing normally. SMMU driver probe will >> check qcom_scm ready or not, without SCM node, SMMU driver probe will >> defer. >> The dmesg log without SCM node: >> platform 15000000.iommu: deferred probe pending: arm-smmu: qcom_scm not ready >> >> With the SCM node, SMMU can probe normally, but SCM driver still fails >> to probe because of one SCM bug: >> qcom_scm firmware:scm: error (____ptrval____): Failed to enable the TrustZone memory allocator >> qcom_scm firmware:scm: probe with driver qcom_scm failed with error 4 >> The above SCM bug is fixed by: >> https://lore.kernel.org/all/20241005140150.4109700-2-quic_kuldsing@quicinc.com/ >> But above patch doesn't impact building of current patch series, this patch >> series can build successfully without above patch. >> >> Dependency: >> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/ >> >> Changes in v2: >> - Address the comments on bindings from Krzysztof. > > Which comments? Be specific what changed. Got it, will change into "Add QCS615 into compatibles disallowing clocks in arm,smmu.yaml to address the comments in arm,smmu bindings patch from Krzysztof." in next version. Is it fine? > > Best regards, > Krzysztof >