| Message ID | 20241109-x1e80100-fix-address-size-cells-missing-warnings-v1-0-c1e173369657@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Fix missing address/size cells warnings | expand |
On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@linaro.org> wrote: > > The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells > handling") now forces the parent nodes to specify #adddress-cells > and #size-cells, otherwise it will throw a warning. > > So add the #address-cells and #size-cells properties to the pmk8550_pon node > to get rid of those warnings. > > Cc: <stable+noautosel@kernel.org> # Depends on commit 4b28a0dec185 > Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi > index 5b54ee79f048e3208cbcd6f91e0cec073420fe63..5b9d67c340dc7a4550c9c7f16269542e400e4ee4 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi > @@ -205,6 +205,9 @@ pmk8550_pon: pon@1300 { > reg = <0x1300>, <0x800>; > reg-names = "hlos", "pbs"; > > + #address-cells = <1>; This is incorrect, nodes under pon don't have reg and don't use addressing. > + #size-cells = <0>; > + > pon_pwrkey: pwrkey { > compatible = "qcom,pmk8350-pwrkey"; > interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>; > > -- > 2.34.1 >
On Sat, Nov 09, 2024 at 12:49:16AM +0200, Dmitry Baryshkov wrote: > On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@linaro.org> wrote: > > > > The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells > > handling") now forces all parent nodes to describe the #adress-cells > > and #size-cells, otherwise it will throw a warning. > > > > Note that this patch is currently only in -next. > > > > Fix all warnings on the X Elite by adding these two properties to all > > parent nodes that don't have them. > > The individual patches are incorrect per my understanding. None of > those child nodes use addressing, so adding #address-cells = <1> is > incorrect. Maybe it should be #address-cells = <0>, but that looks a > bit ridiculous to me. Yeah, the warnings are bogus. Rob merged a fix last night: https://lore.kernel.org/lkml/20241108193547.2647986-2-robh@kernel.org/ so this should be resolved in linux-next on Monday or so. Johan
The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells handling") now forces all parent nodes to describe the #adress-cells and #size-cells, otherwise it will throw a warning. Note that this patch is currently only in -next. Fix all warnings on the X Elite by adding these two properties to all parent nodes that don't have them. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- Abel Vesa (3): arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to firmware node arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to ADSP GPR nodes arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 3 +++ arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++++++++ 2 files changed, 13 insertions(+) --- base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a change-id: 20241108-x1e80100-fix-address-size-cells-missing-warnings-1cfba11bfdbd Best regards,