mbox series

[v3,0/4] Update LPASS Audio clock driver for QCM6490 board

Message ID 20250212-lpass_qcm6490_resets-v3-0-0b1cfb35b38e@quicinc.com
Headers show
Series Update LPASS Audio clock driver for QCM6490 board | expand

Message

Taniya Das Feb. 12, 2025, 8:22 a.m. UTC
This series updates the low pass audio clock controller driver for reset
functionality. The patches are split from the below series.
https://lore.kernel.org/all/20240318053555.20405-1-quic_tdas@quicinc.com/

The QCM6490 board requires only the reset functionality from the LPASS
subsystem. Thus separate out the driver probe to provide the same on the
QCM6490 boards.

[v3]:
Changes in [v3] compared to [v2]:
- update to Documentation bindings adding constraints. [Krzysztof]
- split the DT patch for "Update protected clocks list" for QCM6490 IDP
https://lore.kernel.org/linux-devicetree/20250206-protected_clock_qcm6490-v1-1-5923e8c47ab5@quicinc.com/

[v2]:
Changes in [v2] compared to [v1]:
 - Updated the lpass_audio_cc_sc7280 probe to get the match_data for both SC7280 and QCM6490.
 - Separate regmap for resets [Konrad]
 - Split the lpassaudiocc compatible and GCC protected clocks list changes. [Dmitry]
 - Link to V1: https://lore.kernel.org/all/20240531102252.26061-1-quic_tdas@quicinc.com/T/

[v1]
  - Add a separate platform driver for QCM6490 resets.
  - Add device tree changes for protected clocks for GCC and LPASS AudioCC
    compatible update.

Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
Taniya Das (4):
      dt-bindings: clock: qcom: Add compatible for QCM6490 boards
      clk: qcom: lpassaudiocc-sc7280: Add support for LPASS resets for QCM6490
      arm64: dts: qcom: qcm6490-idp: Update the LPASS audio node
      arm64: dts: qcom: qcs6490-rb3gen2: Update the LPASS audio node

 .../bindings/clock/qcom,sc7280-lpasscorecc.yaml    | 14 +++++++++++++
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts           |  5 +++++
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts       |  5 +++++
 drivers/clk/qcom/lpassaudiocc-sc7280.c             | 23 ++++++++++++++++++----
 4 files changed, 43 insertions(+), 4 deletions(-)
---
base-commit: 808eb958781e4ebb6e9c0962af2e856767e20f45
change-id: 20250206-lpass_qcm6490_resets-204f86622a5c

Best regards,

Comments

Krzysztof Kozlowski Feb. 13, 2025, 8:15 a.m. UTC | #1
On Wed, Feb 12, 2025 at 01:52:19PM +0530, Taniya Das wrote:
> @@ -130,6 +131,19 @@ allOf:
>          reg:
>            maxItems: 1
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,qcm6490-lpassaudiocc
> +
> +    then:

You need to constrain everything, also clocks. See all other examples.

Best regards,
Krzysztof
Taniya Das Feb. 13, 2025, 9:16 a.m. UTC | #2
On 2/13/2025 1:45 PM, Krzysztof Kozlowski wrote:
> On Wed, Feb 12, 2025 at 01:52:19PM +0530, Taniya Das wrote:
>> @@ -130,6 +131,19 @@ allOf:
>>          reg:
>>            maxItems: 1
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: qcom,qcm6490-lpassaudiocc
>> +
>> +    then:
> 
> You need to constrain everything, also clocks. See all other examples.
> 

Sure, I will take care to update in the next patch.

> Best regards,
> Krzysztof
>