mbox series

[v2,0/2] Add Xiaomi Redmi Note 8 support

Message ID 20250308013019.10321-1-semfault@disroot.org
Headers show
Series Add Xiaomi Redmi Note 8 support | expand

Message

Gabriel Gonzales March 8, 2025, 1:30 a.m. UTC
This patchset introduces support for the Redmi Note 8 (codenamed ginkgo). This series is a follow-up to v1 (message-id in in-reply-to header) which was sent without a cover letter.

Changes in v2:
- Add missing cover letter
- Fix up commit message for schema

Gabriel Gonzales (2):
  dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
  arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts    | 294 ++++++++++++++++++
 3 files changed, 296 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts

Comments

Rob Herring March 10, 2025, 2:36 p.m. UTC | #1
On Sat, 08 Mar 2025 09:30:10 +0800, Gabriel Gonzales wrote:
> This patchset introduces support for the Redmi Note 8 (codenamed ginkgo). This series is a follow-up to v1 (message-id in in-reply-to header) which was sent without a cover letter.
> 
> Changes in v2:
> - Add missing cover letter
> - Fix up commit message for schema
> 
> Gabriel Gonzales (2):
>   dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
>   arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
> 
>  .../devicetree/bindings/arm/qcom.yaml         |   1 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts    | 294 ++++++++++++++++++
>  3 files changed, 296 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> 
> --
> 2.48.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250308013019.10321-1-semfault@disroot.org:

arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #address-cells: 2 was expected
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #size-cells: 2 was expected
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #address-cells: 2 was expected
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #size-cells: 2 was expected
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
Krzysztof Kozlowski March 11, 2025, 8:12 a.m. UTC | #2
On Tue, Mar 11, 2025 at 08:33:47AM +0800, Gabriel Gonzales wrote:
> Document the Xiaomi Redmi Note 8 (codenamed ginkgo),
> which is based off the SM6125 SoC.
> 
> Signed-off-by: Gabriel Gonzales <semfault@disroot.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

How did you resolve my first comment to your v2?

Best regards,
Krzysztof