| Message ID | 20250313130918.4238-1-quic_kaushalk@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable QPIC BAM and QPIC NAND support for SDX75 | expand |
On 3/13/25 2:09 PM, Kaushal Kumar wrote: > Enable QPIC BAM devicetree node for Qualcomm SDX75-IDP board. > > Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> > --- There's not reason for this to be a separate commit Konrad
On 13/03/2025 14:09, Kaushal Kumar wrote: > SDX75 BAM DMA controller has DMA-coherent support so define > it in the properties section, without which 'dtbs_check' > reports the following error: > > controller@1c9c000: 'dma-coherent' does not match any of the > regexes: 'pinctrl-[0-9]+' How can I reproduce it? > Fixes tag? > Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> > --- > Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > index 3ad0d9b1fbc5..c4dd6a503964 100644 > --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > @@ -39,6 +39,8 @@ properties: > "#dma-cells": > const: 1 > > + dma-coherent: true > + Which devices are DMA coherent? Best regards, Krzysztof
On 3/13/2025 8:00 PM, Konrad Dybcio wrote: > On 3/13/25 2:09 PM, Kaushal Kumar wrote: >> Hello, >> >> This series adds and enables devicetree nodes for QPIC BAM >> and QPIC NAND for Qualcomm SDX75 platform. >> >> This patch series depends on the below patches: >> https://lore.kernel.org/linux-spi/20250310120906.1577292-5-quic_mdalam@quicinc.com/T/ >> >> Kaushal Kumar (6): >> dt-bindings: mtd: qcom,nandc: Document the SDX75 NAND >> dt-bindings: dma: qcom,bam: Document dma-coherent property >> ARM: dts: qcom: sdx75: Add QPIC BAM support >> ARM: dts: qcom: sdx75: Add QPIC NAND support >> ARM: dts: qcom: sdx75-idp: Enable QPIC BAM support >> ARM: dts: qcom: sdx75-idp: Enable QPIC NAND support > subjects: sdx75 is arm64 and the prefix in that dir is: > > arm64: dts: qcom: <soc/board>: foo Agree, will update in v2. > > Konrad
On 3/13/2025 8:07 PM, Konrad Dybcio wrote: > On 3/13/25 2:09 PM, Kaushal Kumar wrote: >> Enable QPIC BAM devicetree node for Qualcomm SDX75-IDP board. >> >> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> >> --- > There's not reason for this to be a separate commit Okay, will combine it along with nand enablement in v2. > > Konrad
On 3/13/2025 8:20 PM, Krzysztof Kozlowski wrote: > On 13/03/2025 14:09, Kaushal Kumar wrote: >> SDX75 BAM DMA controller has DMA-coherent support so define >> it in the properties section, without which 'dtbs_check' >> reports the following error: >> >> controller@1c9c000: 'dma-coherent' does not match any of the >> regexes: 'pinctrl-[0-9]+' > How can I reproduce it? It is not an existing error. It is the error that would come unless the new property is defined. Will remove this part of commit text in v2. > Fixes tag? > >> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com> >> --- >> Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> index 3ad0d9b1fbc5..c4dd6a503964 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml >> @@ -39,6 +39,8 @@ properties: >> "#dma-cells": >> const: 1 >> >> + dma-coherent: true >> + > Which devices are DMA coherent? Will update it under a bam version check in v2. > > > Best regards, > Krzysztof